Manual changes to Developer module

Author: lbajsarowicz

app/code/Magento/Developer/Test/Unit/Console/Command/DevTestsRunCommandTest.php

@@ -48,7 +48,7 @@ public function testExecuteBadType()
         {
             $commandTester = new CommandTester($this->command);
             $commandTester->execute([DevTestsRunCommand::INPUT_ARG_TYPE => 'bad']);
-            $this->assertContains('Invalid type: "bad"', $commandTester->getDisplay());
+            $this->assertStringContainsString('Invalid type: "bad"', $commandTester->getDisplay());
         }
 
         public function testPassArgumentsToPHPUnit()
@@ -64,12 +64,12 @@ public function testPassArgumentsToPHPUnit()
                     '-' . DevTestsRunCommand::INPUT_OPT_COMMAND_ARGUMENTS_SHORT => '--list-suites',
                 ]
             );
-            $this->assertContains(
+            $this->assertStringContainsString(
                 'phpunit  --list-suites',
                 $commandTester->getDisplay(),
                 'Parameters should be passed to PHPUnit'
             );
-            $this->assertContains(
+            $this->assertStringContainsString(
                 'PASSED (',
                 $commandTester->getDisplay(),
                 'PHPUnit runs should have passed'
@@ -89,12 +89,12 @@ public function testPassArgumentsToPHPUnitNegative()
                     '-' . DevTestsRunCommand::INPUT_OPT_COMMAND_ARGUMENTS_SHORT => '--list-suites',
                 ]
             );
-            $this->assertContains(
+            $this->assertStringContainsString(
                 'phpunit  --list-suites',
                 $commandTester->getDisplay(),
                 'Parameters should be passed to PHPUnit'
             );
-            $this->assertContains(
+            $this->assertStringContainsString(
                 'FAILED - ',
                 $commandTester->getDisplay(),
                 'PHPUnit runs should have passed'

app/code/Magento/Developer/Test/Unit/Console/Command/TablesWhitelistGenerateCommandTest.php

@@ -40,11 +40,11 @@ protected function setUp(): void
      * Test case for success scenario
      *
      * @param string $arguments
-     * @param string $expected
+     * @param int $expected
      *
      * @dataProvider successDataProvider
      */
-    public function testCommandSuccess(string $arguments, string $expected)
+    public function testCommandSuccess(string $arguments, int $expected)
     {
         $this->whitelistGenerator->expects($this->once())
             ->method('generate')
@@ -59,13 +59,13 @@ public function testCommandSuccess(string $arguments, string $expected)
      * Test case for failure scenario
      *
      * @param string $arguments
-     * @param string $expected
+     * @param int $expected
      * @param \Exception|ConfigException $exception
      * @param string $output
      *
      * @dataProvider failureDataProvider
      */
-    public function testCommandFailure(string $arguments, string $expected, $exception, string $output)
+    public function testCommandFailure(string $arguments, int $expected, $exception, string $output)
     {
         $this->whitelistGenerator->expects($this->once())
             ->method('generate')

app/code/Magento/Developer/Test/Unit/Console/Command/XmlConverterCommandTest.php

@@ -72,7 +72,7 @@ public function testExecute()
                 XmlConverterCommand::PROCESSOR_ARGUMENT => 'file.xsl'
             ]
         );
-        $this->assertContains('result', $commandTester->getDisplay());
+        $this->assertStringContainsString('result', $commandTester->getDisplay());
     }
 
     public function testWrongParameter()