Skip to content

Commit dded342

Browse files
committed
MC-18157: [Incorrect Escaping] Add proper escaping to translation phrases marked with @NoEscape tag
1 parent 7ffabd0 commit dded342

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

app/code/Magento/Bundle/view/frontend/templates/catalog/product/view/type/bundle/options.phtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ $options = $block->decorateArray($block->getOptions($stripSelection));
2626
</script>
2727
<fieldset class="fieldset fieldset-bundle-options">
2828
<legend id="customizeTitle" class="legend title">
29-
<span><?= /* @noEscape */ __('Customize %1', $helper->productAttribute($product, $product->getName(), 'name')) ?></span>
29+
<span><?= $block->escapeHtml(__('Customize %1', $helper->productAttribute($product, $product->getName(), 'name'))) ?></span>
3030
</legend><br />
3131
<?= $block->getChildHtml('product_info_bundle_options_top') ?>
3232
<?php foreach ($options as $option) : ?>

app/code/Magento/Catalog/view/frontend/templates/product/gallery.phtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
id="product-gallery-image"
3535
class="image"
3636
data-mage-init='{"catalogGallery":{}}'/>
37-
<div class="buttons-set"><a href="#" class="button" role="close-window"><span><?= /* @noEscape */ __('Close Window') ?></span></a></div>
37+
<div class="buttons-set"><a href="#" class="button" role="close-window"><span><?= $block->escapeHtml(__('Close Window')) ?></span></a></div>
3838
<?php if ($block->getPreviousImageUrl() || $block->getNextImageUrl()) :?>
3939
<div class="nav">
4040
<?php if ($_prevUrl = $block->getPreviousImageUrl()) :?>

app/code/Magento/Downloadable/view/adminhtml/templates/product/edit/downloadable.phtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ var uploaderTemplate = '<div class="no-display" id="[[idName]]-template">' +
210210
<input type="checkbox" data-action="change-type-product-downloadable" class="admin__control-checkbox"
211211
name="is_downloadable" id="is-downloaodable" <?= $block->isDownloadable() ? 'checked="checked"' : ''?> />
212212
<label class="admin__field-label" for="is-downloaodable">
213-
<span><?= /* @noEscape */ __('Is this a downloadable Product?'); ?></span>
213+
<span><?= $block->escapeHtml(__('Is this a downloadable Product?')); ?></span>
214214
</label>
215215
</div>
216216
<div class="entry-edit" id="product_info_tabs_downloadable_items">

app/code/Magento/Downloadable/view/adminhtml/templates/product/edit/downloadable/samples.phtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ $block->getConfigJson();
5151
</table>
5252
</div>
5353
<div class="admin__field-note">
54-
<?= /* @noEscape */ __('Alphanumeric, dash and underscore characters are recommended for filenames. Improper characters are replaced with \'_\'.') ?>
54+
<?= $block->escapeHtml(__('Alphanumeric, dash and underscore characters are recommended for filenames. Improper characters are replaced with \'_\'.')) ?>
5555
</div>
5656
</div>
5757
</div>

0 commit comments

Comments
 (0)