github-issue; #2228; Encode xml entities in tag attributes

sergey-solo · sergey-solo · commit de8028e3db97 · 2019-08-28T14:32:54.000+03:00
diff --git a/lib/internal/Magento/Framework/Simplexml/Element.php b/lib/internal/Magento/Framework/Simplexml/Element.php
@@ -245,7 +245,7 @@ public function asNiceXml($filename = '', $level = 0)
         $attributes = $this->attributes();
         if ($attributes) {
             foreach ($attributes as $key => $value) {
-                $out .= ' ' . $key . '="' . str_replace('"', '\"', (string)$value) . '"';
+                $out .= ' ' . $key . '="' . str_replace('"', '\"', $this->xmlentities($value)) . '"';
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -245,7 +245,7 @@ public function asNiceXml($filename = '', $level = 0)`
`245`	`245`	`$attributes = $this->attributes();`
`246`	`246`	`if ($attributes) {`
`247`	`247`	`foreach ($attributes as $key => $value) {`
`248`		`- $out .= ' ' . $key . '="' . str_replace('"', '\"', (string)$value) . '"';`
	`248`	`+ $out .= ' ' . $key . '="' . str_replace('"', '\"', $this->xmlentities($value)) . '"';`
`249`	`249`	`}`
`250`	`250`	`}`
`251`	`251`