ACP2E-3233: Admin can still place order even without payment method

Chhandak.Barua · Chhandak.Barua · commit e0b7464aaae5 · 2024-09-17T19:45:25.000+05:30
diff --git a/app/code/Magento/Sales/Model/AdminOrder/Create.php b/app/code/Magento/Sales/Model/AdminOrder/Create.php
@@ -1810,6 +1810,8 @@ public function importPostData($data)
 
         if (isset($data['payment_method'])) {
             $this->setPaymentMethod($data['payment_method']);
+       } else {
+            $this->setPaymentMethod('');
         }
 
         if (isset($data['coupon']['code'])) {
@@ -2180,7 +2182,6 @@ protected function _validate()
                 $this->_errors[] = __('The shipping method is missing. Select the shipping method and try again.');
             }
         }
-
         if (!$this->getQuote()->getPayment()->getMethod()) {
             $this->_errors[] = __("The payment method isn't selected. Enter the payment method and try again.");
         } else {

Original file line number	Diff line number	Diff line change
`@@ -1810,6 +1810,8 @@ public function importPostData($data)`
`1810`	`1810`
`1811`	`1811`	`if (isset($data['payment_method'])) {`
`1812`	`1812`	`$this->setPaymentMethod($data['payment_method']);`
	`1813`	`+ } else {`
	`1814`	`+ $this->setPaymentMethod('');`
`1813`	`1815`	`}`
`1814`	`1816`
`1815`	`1817`	`if (isset($data['coupon']['code'])) {`
`@@ -2180,7 +2182,6 @@ protected function _validate()`
`2180`	`2182`	`$this->_errors[] = __('The shipping method is missing. Select the shipping method and try again.');`
`2181`	`2183`	`}`
`2182`	`2184`	`}`
`2183`		`-`
`2184`	`2185`	`if (!$this->getQuote()->getPayment()->getMethod()) {`
`2185`	`2186`	`$this->_errors[] = __("The payment method isn't selected. Enter the payment method and try again.");`
`2186`	`2187`	`} else {`