Skip to content

Commit e27f4d2

Browse files
committed
Merge remote-tracking branch 'honey/MAGETWO-95111-Creating-new-storeview-validation' into BugFixPR
2 parents 9cd633c + 0827687 commit e27f4d2

File tree

4 files changed

+25
-3
lines changed

4 files changed

+25
-3
lines changed

app/code/Magento/Backend/view/adminhtml/web/js/validate-store.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ define([
6767
* 'Confirm' action handler.
6868
*/
6969
confirm: function () {
70+
$('body').trigger('processStart');
7071
dataPost().postData(requestData);
7172
}
7273
}

app/code/Magento/Store/Test/Mftf/ActionGroup/AdminCreateStoreViewActionGroup.xml

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,17 @@
2424
<waitForElementVisible selector="{{AdminConfirmationModalSection.ok}}" stepKey="waitForModal" />
2525
<see selector="{{AdminConfirmationModalSection.title}}" userInput="Warning message" stepKey="seeWarning" />
2626
<click selector="{{AdminConfirmationModalSection.ok}}" stepKey="dismissModal" />
27-
<waitForElementVisible selector="{{AdminStoresGridSection.storeFilterTextField}}" stepKey="waitForPageReolad"/>
27+
<waitForElementNotVisible selector="{{AdminNewStoreViewActionsSection.loadingMask}}" stepKey="waitForElementVisible"/>
28+
</actionGroup>
29+
<!--Save the Store view-->
30+
<actionGroup name="AdminCreateStoreViewActionSaveGroup">
31+
<waitForLoadingMaskToDisappear stepKey="waitForGridLoad"/>
32+
<waitForElementVisible selector="{{AdminStoresGridSection.websiteFilterTextField}}" stepKey="waitForStoreGridToReload2"/>
2833
<see userInput="You saved the store view." stepKey="seeSavedMessage" />
2934
</actionGroup>
35+
<!--Save the same Store view code for code validation-->
36+
<actionGroup name="AdminCreateStoreViewCodeUniquenessActionGroup">
37+
<waitForLoadingMaskToDisappear stepKey="waitForForm"/>
38+
<see userInput="Store with the same code already exists." stepKey="seeMessage" />
39+
</actionGroup>
3040
</actionGroups>

app/code/Magento/Store/Test/Mftf/Section/AdminNewStoreViewActionsSection.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,6 @@
1111
<element name="delete" type="button" selector="#delete" timeout="30"/>
1212
<element name="resetButton" type="button" selector="#reset" timeout="30"/>
1313
<element name="saveButton" type="button" selector="#save" timeout="60"/>
14+
<element name="loadingMask" type="text" selector=".loading-mask"/>
1415
</section>
1516
</sections>

app/code/Magento/Store/Test/Mftf/Test/AdminCreateStoreViewTest.xml

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,25 @@
1515
<description value="Admin should be able to create a store view"/>
1616
<group value="storeView"/>
1717
<severity value="AVERAGE"/>
18+
<testCaseId value="MAGETWO-95111"/>
1819
</annotations>
1920
<before>
2021
<actionGroup ref="LoginActionGroup" stepKey="login"/>
22+
<actionGroup ref="AdminCreateStoreViewActionGroup" stepKey="createStoreView" />
23+
<!--<createData stepKey="b2" entity="customStoreGroup"/>-->
2124
</before>
22-
<actionGroup ref="AdminCreateStoreViewActionGroup" stepKey="createStoreView" />
23-
<!--Confirm new store view on Store Grid-->
25+
<!--Save store view on Store Grid-->
26+
<actionGroup ref="AdminCreateStoreViewActionSaveGroup" stepKey="createStoreViewSave" />
27+
<!--Confirm new store view created on Store Grid-->
2428
<fillField selector="{{AdminStoresGridSection.storeFilterTextField}}" userInput="{{customStore.name}}" stepKey="fillStoreViewFilter"/>
2529
<click selector="{{AdminStoresGridSection.searchButton}}" stepKey="clickSearch" />
2630
<waitForPageLoad stepKey="waitForPageLoad"/>
2731
<see selector="{{AdminStoresGridSection.storeNameInFirstRow}}" userInput="{{customStore.name}}" stepKey="seeNewStoreView" />
32+
<!--Creating the same store view to validate the code uniqueness on store form-->
33+
<actionGroup ref="AdminCreateStoreViewActionGroup" stepKey="createStoreView2" />
34+
<actionGroup ref="AdminCreateStoreViewCodeUniquenessActionGroup" stepKey="createStoreViewCode" />
35+
<after>
36+
<actionGroup ref="logout" stepKey="logout"/>
37+
</after>
2838
</test>
2939
</tests>

0 commit comments

Comments
 (0)