Skip to content

Commit e2b98b7

Browse files
bubasumabubasuma
committed
ACP2E-2053: Unable to save products with different attribute sets in Async bulk REST API
1 parent 13e54e1 commit e2b98b7

File tree

6 files changed

+282
-17
lines changed

6 files changed

+282
-17
lines changed

‎app/code/Magento/Catalog/Model/ResourceModel/AbstractResource.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ protected function _isApplicableAttribute($object, $attribute)
8787
{
8888
$applyTo = $attribute->getApplyTo() ?: [];
8989
return (count($applyTo) == 0 || in_array($object->getTypeId(), $applyTo))
90-
&& $attribute->isInSet($object->getAttributeSetId());
90+
&& $attribute->isInSet($object->getAttributeSetId() ?? $this->getEntityType()->getDefaultAttributeSetId());
9191
}
9292

9393
/**

‎app/code/Magento/Catalog/Test/Fixture/AttributeSet.php

Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
1+
<?php
2+
/**
3+
* Copyright © Magento, Inc. All rights reserved.
4+
* See COPYING.txt for license details.
5+
*/
6+
declare(strict_types=1);
7+
8+
namespace Magento\Catalog\Test\Fixture;
9+
10+
use Magento\Catalog\Api\Data\ProductAttributeInterface;
11+
use Magento\Eav\Model\Config;
12+
use Magento\Framework\DataObject;
13+
use Magento\TestFramework\Fixture\Api\ServiceFactory;
14+
use Magento\TestFramework\Fixture\Data\ProcessorInterface;
15+
16+
class AttributeSet extends \Magento\Eav\Test\Fixture\AttributeSet
17+
{
18+
private const ENTITY_TYPE = ProductAttributeInterface::ENTITY_TYPE_CODE;
19+
20+
public function __construct(
21+
ServiceFactory $serviceFactory,
22+
ProcessorInterface $dataProcessor,
23+
private readonly Config $eavConfig
24+
) {
25+
parent::__construct($serviceFactory, $dataProcessor);
26+
}
27+
28+
/**
29+
* {@inheritdoc}
30+
*/
31+
public function apply(array $data = []): ?DataObject
32+
{
33+
return parent::apply(
34+
array_merge(
35+
[
36+
'entity_type_code' => self::ENTITY_TYPE,
37+
'skeleton_id' => $this->eavConfig->getEntityType(self::ENTITY_TYPE)->getDefaultAttributeSetId(),
38+
],
39+
$data
40+
)
41+
);
42+
}
43+
}

‎app/code/Magento/Catalog/Test/Unit/Model/ResourceModel/AbstractTest.php

Lines changed: 71 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,57 @@
1010
*/
1111
namespace Magento\Catalog\Test\Unit\Model\ResourceModel;
1212

13+
use Magento\Catalog\Model\Factory;
1314
use Magento\Catalog\Model\Product;
1415
use Magento\Catalog\Model\ResourceModel\AbstractResource;
1516
use Magento\Eav\Model\Entity\Attribute\AbstractAttribute;
17+
use Magento\Eav\Model\Entity\Attribute\Set;
18+
use Magento\Eav\Model\Entity\Attribute\UniqueValidationInterface;
19+
use Magento\Eav\Model\Entity\Context;
1620
use Magento\Framework\DataObject;
17-
use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
21+
use Magento\Store\Model\StoreManagerInterface;
22+
use PHPUnit\Framework\MockObject\MockObject;
1823
use PHPUnit\Framework\TestCase;
1924

2025
class AbstractTest extends TestCase
2126
{
27+
/**
28+
* @var Context|MockObject
29+
*/
30+
private $context;
31+
32+
/**
33+
* @var StoreManagerInterface|MockObject
34+
*/
35+
private $storeManager;
36+
37+
/**
38+
* @var Factory|MockObject
39+
*/
40+
private $modelFactory;
41+
42+
/**
43+
* @var UniqueValidationInterface|MockObject
44+
*/
45+
private $uniqueValidator;
46+
47+
/**
48+
* @var AbstractResource|MockObject
49+
*/
50+
private $model;
51+
52+
/**
53+
* @inheritDoc
54+
*/
55+
protected function setUp(): void
56+
{
57+
parent::setUp();
58+
$this->context = $this->createMock(Context::class);
59+
$this->storeManager = $this->createMock(StoreManagerInterface::class);
60+
$this->modelFactory = $this->createMock(Factory::class);
61+
$this->uniqueValidator = $this->createMock(UniqueValidationInterface::class);
62+
}
63+
2264
/**
2365
* Get attribute list
2466
*
@@ -47,8 +89,6 @@ protected function _getAttributes()
4789

4890
public function testWalkAttributes()
4991
{
50-
$objectManager = new ObjectManager($this);
51-
5292
$code = 'test_attr';
5393
$set = 10;
5494
$storeId = 100;
@@ -85,17 +125,33 @@ public function testWalkAttributes()
85125

86126
$attributes[$code] = $attribute;
87127

88-
/** @var AbstractResource $model */
89-
$arguments = $objectManager->getConstructArguments(
90-
AbstractResource::class
91-
);
92-
$model = $this->getMockBuilder(AbstractResource::class)
93-
->setMethods(['getAttributesByCode'])
94-
->setConstructorArgs($arguments)
95-
->getMock();
96-
97-
$model->expects($this->once())->method('getAttributesByCode')->willReturn($attributes);
98-
99-
$model->walkAttributes('backend/afterSave', [$object]);
128+
$attrSetEntity = $this->createMock(Set::class);
129+
$this->context->method('getAttributeSetEntity')
130+
->willReturn($attrSetEntity);
131+
$attrSetEntity->expects($this->once())
132+
->method('addSetInfo')
133+
->with($entityType, $attributes, $set);
134+
135+
$this->model = $this->getMockBuilder(AbstractResource::class)
136+
->setConstructorArgs(
137+
[
138+
$this->context,
139+
$this->storeManager,
140+
$this->modelFactory,
141+
[],
142+
$this->uniqueValidator
143+
]
144+
)
145+
->onlyMethods(['getAttributesByCode', 'getEntityType'])
146+
->getMockForAbstractClass();
147+
148+
$this->model->expects($this->once())
149+
->method('getAttributesByCode')
150+
->willReturn($attributes);
151+
$this->model->expects($this->once())
152+
->method('getEntityType')
153+
->willReturn($entityType);
154+
155+
$this->model->walkAttributes('backend/afterSave', [$object]);
100156
}
101157
}

‎app/code/Magento/Eav/Model/Entity/AbstractEntity.php

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -650,8 +650,14 @@ public function walkAttributes($partMethod, array $args = [], $collectExceptionM
650650
}
651651
$results = [];
652652
$suffix = $this->getAttributesCacheSuffix($args[0]);
653+
$attributes = $this->getAttributesByScope($suffix);
654+
foreach ($args as $arg) {
655+
if ($arg instanceof DataObject && $arg->getAttributeSetId()) {
656+
$this->_attrSetEntity->addSetInfo($this->getEntityType(), $attributes, $arg->getAttributeSetId());
657+
}
658+
}
653659
$instance = null;
654-
foreach ($this->getAttributesByScope($suffix) as $attrCode => $attribute) {
660+
foreach ($attributes as $attrCode => $attribute) {
655661
if (isset($args[0]) && is_object($args[0]) && !$this->_isApplicableAttribute($args[0], $attribute)) {
656662
continue;
657663
}

‎app/code/Magento/Eav/Test/Fixture/AttributeSet.php

Lines changed: 70 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,70 @@
1+
<?php
2+
/**
3+
* Copyright © Magento, Inc. All rights reserved.
4+
* See COPYING.txt for license details.
5+
*/
6+
declare(strict_types=1);
7+
8+
namespace Magento\Eav\Test\Fixture;
9+
10+
use Magento\Eav\Api\AttributeSetManagementInterface;
11+
use Magento\Eav\Api\AttributeSetRepositoryInterface;
12+
use Magento\Framework\DataObject;
13+
use Magento\TestFramework\Fixture\Api\ServiceFactory;
14+
use Magento\TestFramework\Fixture\RevertibleDataFixtureInterface;
15+
use Magento\TestFramework\Fixture\Data\ProcessorInterface;
16+
17+
class AttributeSet implements RevertibleDataFixtureInterface
18+
{
19+
private const DEFAULT_DATA = [
20+
'attribute_set_id' => null,
21+
'attribute_set_name' => 'attribute_set%uniqid%',
22+
'sort_order' => 0,
23+
'entity_type_code' => null,
24+
'skeleton_id' => null,
25+
];
26+
27+
/**
28+
* @param ServiceFactory $serviceFactory
29+
* @param ProcessorInterface $dataProcessor
30+
*/
31+
public function __construct(
32+
private readonly ServiceFactory $serviceFactory,
33+
private readonly ProcessorInterface $dataProcessor
34+
) {
35+
}
36+
37+
/**
38+
* {@inheritdoc}
39+
* @param array $data Parameters. Same format as AttributeSet::DEFAULT_DATA.
40+
*/
41+
public function apply(array $data = []): ?DataObject
42+
{
43+
$data = array_merge(self::DEFAULT_DATA, $data);
44+
$skeletonId = $data['skeleton_id'];
45+
$entityTypeCode = $data['entity_type_code'];
46+
unset($data['skeleton_id'], $data['entity_type_code']);
47+
$service = $this->serviceFactory->create(AttributeSetManagementInterface::class, 'create');
48+
49+
return $service->execute(
50+
[
51+
'attributeSet' => $this->dataProcessor->process($this, $data),
52+
'entityTypeCode' => $entityTypeCode,
53+
'skeletonId' => $skeletonId,
54+
]
55+
);
56+
}
57+
58+
/**
59+
* @inheritdoc
60+
*/
61+
public function revert(DataObject $data): void
62+
{
63+
$service = $this->serviceFactory->create(AttributeSetRepositoryInterface::class, 'deleteById');
64+
$service->execute(
65+
[
66+
'attributeSetId' => $data->getAttributeSetId()
67+
]
68+
);
69+
}
70+
}

‎dev/tests/integration/testsuite/Magento/Catalog/Model/ProductRepositoryTest.php

Lines changed: 90 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@
1111
use Magento\Catalog\Api\ProductRepositoryInterface;
1212
use Magento\Catalog\Model\Product\Media\ConfigInterface;
1313
use Magento\Catalog\Model\ResourceModel\Product as ProductResource;
14+
use Magento\Catalog\Test\Fixture\AttributeSet as AttributeSetFixture;
1415
use Magento\Catalog\Test\Fixture\Product as ProductFixture;
16+
use Magento\Customer\Model\Group;
1517
use Magento\Framework\Api\SearchCriteriaBuilder;
1618
use Magento\Framework\App\Filesystem\DirectoryList;
1719
use Magento\Framework\Exception\CouldNotSaveException;
@@ -427,6 +429,94 @@ public function testConsecutivePartialProductsUpdateInStoreView(): void
427429
$this->assertEquals($product2Store1Price, $product2->getPrice());
428430
}
429431

432+
#[
433+
AppArea('adminhtml'),
434+
DataFixture(AttributeSetFixture::class, as: 'attribute_set2'),
435+
DataFixture(
436+
ProductFixture::class,
437+
[
438+
'tier_prices' => [
439+
[
440+
'customer_group_id' => Group::NOT_LOGGED_IN_ID,
441+
'qty' => 2,
442+
'value' => 7.5
443+
]
444+
]
445+
],
446+
'product1'
447+
),
448+
DataFixture(
449+
ProductFixture::class,
450+
[
451+
'attribute_set_id' => '$attribute_set2.attribute_set_id$',
452+
'tier_prices' => [
453+
[
454+
'customer_group_id' => Group::NOT_LOGGED_IN_ID,
455+
'qty' => 4,
456+
'value' => 8
457+
]
458+
]
459+
],
460+
'product2'
461+
),
462+
]
463+
public function testConsecutiveProductsUpdateWithDifferentAttributeSets(): void
464+
{
465+
$product1 = $this->fixtures->get('product1');
466+
$product2 = $this->fixtures->get('product2');
467+
$store1 = $this->storeManager->getStore('default')->getId();
468+
$this->storeManager->setCurrentStore($store1);
469+
$product1UpdatedName = $product1->getName() . ' for default store view';
470+
$product2UpdatedName = $product2->getName() . ' for default store view';
471+
$this->productRepository->save(
472+
$this->getProductInstance(
473+
[
474+
'sku' => $product1->getSku(),
475+
'name' => $product1UpdatedName,
476+
]
477+
)
478+
);
479+
$this->productRepository->save(
480+
$this->getProductInstance(
481+
[
482+
'sku' => $product2->getSku(),
483+
'name' => $product2UpdatedName,
484+
]
485+
)
486+
);
487+
$product1 = $this->productRepository->get($product1->getSku(), true, $store1, true);
488+
$this->assertEquals($product1UpdatedName, $product1->getName());
489+
$this->assertCount(1, $product1->getTierPrices());
490+
$this->assertEquals(
491+
[
492+
'customer_group_id' => Group::NOT_LOGGED_IN_ID,
493+
'qty' => 2,
494+
'value' => 7.5
495+
],
496+
[
497+
'customer_group_id' => $product1->getTierPrices()[0]->getCustomerGroupId(),
498+
'qty' => $product1->getTierPrices()[0]->getQty(),
499+
'value' => $product1->getTierPrices()[0]->getValue()
500+
]
501+
);
502+
503+
$product2 = $this->productRepository->get($product2->getSku(), true, $store1, true);
504+
$this->assertEquals($product2UpdatedName, $product2->getName());
505+
$this->assertCount(1, $product2->getTierPrices());
506+
$this->assertEquals(
507+
[
508+
'customer_group_id' => Group::NOT_LOGGED_IN_ID,
509+
'qty' => 4,
510+
'value' => 8
511+
],
512+
[
513+
'customer_group_id' => $product2->getTierPrices()[0]->getCustomerGroupId(),
514+
'qty' => $product2->getTierPrices()[0]->getQty(),
515+
'value' => $product2->getTierPrices()[0]->getValue()
516+
]
517+
);
518+
}
519+
430520
/**
431521
* Get Simple Product Data
432522
*

0 commit comments

Comments
 (0)