Skip to content

Commit e62316b

Browse files
committed
MAGETWO-54779: [GitHub] Image size for Product Watermarks can't be set #5270
- modifying js file for simplicity as per code review
1 parent e4fb73e commit e62316b

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

app/code/Magento/Catalog/view/adminhtml/web/component/image-size-field.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ define([
2323

2424
m = dataAttrRange.exec(value);
2525

26-
return m && m.length === 3 && m[1] > 0 && m[2] > 0;
26+
return !!(m && m[1] > 0 && m[2] > 0);
2727
},
2828
$.mage.__('The value is not within the specified format eg: 200x300')
2929
);
@@ -33,11 +33,10 @@ define([
3333
/**
3434
* Checks for relevant value
3535
*
36-
* @param {*} value
3736
* @returns {Boolean}
3837
*/
39-
isRangeCorrect: function (value) {
40-
return validator('validate-image-size-range', value);
38+
isRangeCorrect: function () {
39+
return validator('validate-image-size-range', this.value()).passed;
4140
}
4241
});
4342
});

0 commit comments

Comments
 (0)