AC-10718::PHPUnit 10 upgrade Error: Call to undefined method PHPUnit 10 upgrade Error: Call to undefined method withConsecutive()() - Fix unit tests

Author: jayrangnani-gl

app/code/Magento/Authorization/Test/Unit/Model/Acl/Loader/RuleTest.php

@@ -94,6 +94,7 @@ static function ($value) {
      * Test populating acl rule from cache.
      *
      * @return void
+     * @SuppressWarnings(PHPMD.CyclomaticComplexity)
      */
     public function testPopulateAclFromCache(): void
     {

app/code/Magento/Catalog/Test/Unit/Model/ResourceModel/Product/ImageTest.php

@@ -118,10 +118,10 @@ public function testGetCountAllProductImages(int $imagesCount): void
         $selectMock = $this->getVisibleImagesSelectMock();
         $selectMock->expects($this->exactly(2))
             ->method('reset')
-            ->willReturnCallback(fn($param) => match ([$param]) {
-                ['columns'] =>$selectMock,
-                ['distinct'] => $selectMock
-            });
+            ->withConsecutive(
+                ['columns'],
+                ['distinct']
+            )->willReturnSelf();
         $selectMock->expects($this->once())
             ->method('columns')
             ->with(new \Zend_Db_Expr('count(distinct value)'))
@@ -158,10 +158,10 @@ public function testGetCountUsedProductImages(int $imagesCount): void
         $selectMock = $this->getUsedImagesSelectMock();
         $selectMock->expects($this->exactly(2))
             ->method('reset')
-            ->willReturnCallback(fn($param) => match ([$param]) {
-                ['columns'] =>$selectMock,
-                ['distinct'] => $selectMock
-            });
+            ->withConsecutive(
+                ['columns'],
+                ['distinct']
+            )->willReturnSelf();
         $selectMock->expects($this->once())
             ->method('columns')
             ->with(new \Zend_Db_Expr('count(distinct value)'))
@@ -338,7 +338,7 @@ protected function getBatchIteratorCallback(
      * Data Provider
      * @return array
      */
-    public static function dataProvider(): array
+    public function dataProvider(): array
     {
         return [
             [300, 300],

app/code/Magento/Catalog/Test/Unit/Pricing/Price/CustomOptionPriceTest.php

@@ -402,10 +402,10 @@ public function testGetSelectedOptions(): void
         $this->product->setCustomOptions($customOptions);
         $this->product
             ->method('getOptionById')
-            ->willReturnCallback(function ($arg) use ($optionId1, $optionMock) {
+            ->willReturnCallback(function ($arg) use ($optionId1, $optionId2, $optionMock) {
                 if ($arg == $optionId1) {
                     return $optionMock;
-                } elseif ($arg == $optionId1) {
+                } elseif ($arg == $optionId2) {
                     return null;
                 }
             });

app/code/Magento/Quote/Test/Unit/Model/QuoteManagementTest.php

@@ -1267,6 +1267,7 @@ protected function setPropertyValue(&$object, $property, $value)
      *
      * @return void
      * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+     * @SuppressWarnings(PHPMD.CyclomaticComplexity)
      */
     public function testSubmitForCustomer(): void
     {
@@ -1397,6 +1398,7 @@ private function createPartialMockForAbstractClass(string $className, array $met
      * @return void
      *
      * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+     * @SuppressWarnings(PHPMD.CyclomaticComplexity)
      */
     public function testSubmitWithLockException(): void
     {

app/code/Magento/Sales/Test/Unit/Controller/Adminhtml/Order/Invoice/UpdateQtyTest.php

@@ -213,7 +213,7 @@ public function testExecute(): void
             ->willReturnCallback(function ($arg1, $arg2) use ($orderId, $invoiceData) {
                 if ($arg1 == 'order_id') {
                     return $orderId;
-                } elseif ($arg1 == 'invoice' && is_null($arg2)) {
+                } elseif ($arg1 == 'invoice' && empty($arg2)) {
                     return $invoiceData;
                 }
             });

app/code/Magento/Theme/Test/Unit/Helper/StorageTest.php

@@ -202,10 +202,10 @@ public function testGetThumbnailPath(): void
         $thumbnailPath = '/' . implode(
             '/',
             [
-                \Magento\Theme\Model\Wysiwyg\Storage::TYPE_IMAGE,
-                \Magento\Theme\Model\Wysiwyg\Storage::THUMBNAIL_DIRECTORY,
-                $image
-            ]
+                    \Magento\Theme\Model\Wysiwyg\Storage::TYPE_IMAGE,
+                    \Magento\Theme\Model\Wysiwyg\Storage::THUMBNAIL_DIRECTORY,
+                    $image
+                ]
         );
 
         $this->customization->expects(
@@ -374,14 +374,9 @@ public function testGetRelativeUrl(): void
         };
         $this->urlDecoder
             ->method('decode')
-            ->willReturnCallback(function ($arg) use ($decode, $notRoot, $filename) {
-                if ($arg == $notRoot) {
-                    return $this->returnCallback($decode);
-                }
-                if ($arg == $filename) {
-                    return $this->returnCallback($decode);
-                }
-            });
+            ->withConsecutive([$notRoot], [$filename])
+            ->willReturnOnConsecutiveCalls($this->returnCallback($decode), $this->returnCallback($decode));
+
         $this->assertEquals(
             '../image/not/a/root/filename.ext',
             $this->helper->getRelativeUrl()
@@ -391,7 +386,7 @@ public function testGetRelativeUrl(): void
     /**
      * @return array
      */
-    public static function getStorageTypeForNameDataProvider(): array
+    public function getStorageTypeForNameDataProvider(): array
     {
         return [
             'font' => [\Magento\Theme\Model\Wysiwyg\Storage::TYPE_FONT, Storage::FONTS],
@@ -497,7 +492,7 @@ public function testGetCurrentPath(
     /**
      * @return array
      */
-    public static function getCurrentPathDataProvider(): array
+    public function getCurrentPathDataProvider(): array
     {
         $rootPath = '/' . \Magento\Theme\Model\Wysiwyg\Storage::TYPE_IMAGE;
 
@@ -517,10 +512,14 @@ private function initializeDefaultRequestMock(): void
     {
         $this->request
             ->method('getParam')
-            ->willReturnCallback(fn($param) => match ([$param]) {
-                [Storage::PARAM_THEME_ID] => 6,
-                [Storage::PARAM_CONTENT_TYPE] => \Magento\Theme\Model\Wysiwyg\Storage::TYPE_IMAGE
-            });
+            ->withConsecutive(
+                [Storage::PARAM_THEME_ID],
+                [Storage::PARAM_CONTENT_TYPE]
+            )
+            ->willReturnOnConsecutiveCalls(
+                6,
+                \Magento\Theme\Model\Wysiwyg\Storage::TYPE_IMAGE
+            );
     }
 
     /**