MAGETWO-56849: Clean Up JS files code styles based on black list

omiroshnichenko · omiroshnichenko · commit e8fd64f29404 · 2017-02-10T10:46:26.000+02:00
diff --git a/app/code/Magento/Checkout/view/frontend/web/js/view/shipping.js b/app/code/Magento/Checkout/view/frontend/web/js/view/shipping.js
@@ -244,8 +244,8 @@ define([
                 emailValidationResult = customer.isLoggedIn(),
                 field;
 
-                if (!quote.shippingMethod()) {
-                    this.errorValidationMessage($t('Please specify a shipping method.'));
+            if (!quote.shippingMethod()) {
+                this.errorValidationMessage($t('Please specify a shipping method.'));
 
                 return false;
             }
diff --git a/app/code/Magento/ConfigurableProduct/view/adminhtml/web/js/configurable.js b/app/code/Magento/ConfigurableProduct/view/adminhtml/web/js/configurable.js
@@ -314,6 +314,7 @@ define([
 
         /**
          * Reload price.
+         *
          * @return {undefined|Number}
          */
         reloadPrice: function () {
@@ -324,7 +325,7 @@ define([
                 i, selected;
 
             if (this.config.disablePriceReload) {
-                return;
+                return undefined;
             }
 
             for (i = this.settings.length - 1; i >= 0; i--) {
diff --git a/app/code/Magento/Customer/view/frontend/web/js/view/authentication-popup.js b/app/code/Magento/Customer/view/frontend/web/js/view/authentication-popup.js
@@ -66,30 +66,29 @@ define([
             }
         },
 
-            /**
-             * Provide login action
-             *
-             * @return {Boolean}
-             */
-            login: function (formUiElement, event) {
-                var loginData = {},
-                    formElement = $(event.currentTarget),
-                    formDataArray = formElement.serializeArray();
-
-                event.stopPropagation();
-                formDataArray.forEach(function (entry) {
-                    loginData[entry.name] = entry.value;
-                });
+        /**
+         * Provide login action
+         *
+         * @return {Boolean}
+         */
+        login: function (formUiElement, event) {
+            var loginData = {},
+                formElement = $(event.currentTarget),
+                formDataArray = formElement.serializeArray();
 
-                if (formElement.validation() &&
-                    formElement.validation('isValid')
-                ) {
-                    this.isLoading(true);
-                    loginAction(loginData);
-                }
+            event.stopPropagation();
+            formDataArray.forEach(function (entry) {
+                loginData[entry.name] = entry.value;
+            });
 
-                return false;
+            if (formElement.validation() &&
+                formElement.validation('isValid')
+            ) {
+                this.isLoading(true);
+                loginAction(loginData);
             }
-        });
-    }
-);
+
+            return false;
+        }
+    });
+});
diff --git a/app/code/Magento/Ui/view/base/web/js/form/form.js b/app/code/Magento/Ui/view/base/web/js/form/form.js
@@ -38,7 +38,8 @@ define([
      * @returns {Object}
      */
     function collectData(items) {
-        var result = {};
+        var result = {},
+            name;
 
         items = Array.prototype.slice.call(items);
 
@@ -55,7 +56,7 @@ define([
                     break;
 
                 case 'select-multiple':
-                    var name = item.name.substring(0,(item.name.length - 2)); //remove [] from the name ending
+                    name = item.name.substring(0, item.name.length - 2); //remove [] from the name ending
                     result[name] = _.pluck(item.selectedOptions, 'value');
                     break;
 
diff --git a/dev/tests/js/jasmine/tests/app/code/Magento/Ui/base/js/form/client.test.js b/dev/tests/js/jasmine/tests/app/code/Magento/Ui/base/js/form/client.test.js
@@ -79,7 +79,7 @@ define([
                 params = {
                     url: obj.urls.beforeSave,
                     data: _.extend(data, {
-                        form_key: 'magentoFormKey'
+                        'form_key': 'magentoFormKey'
                     }),
                     success: jasmine.any(Function),
                     complete: jasmine.any(Function)
@@ -102,7 +102,7 @@ define([
 
                 expect($.ajax).not.toHaveBeenCalled();
             });
-            it('Check call "beforeSave" method. Check "success" ajax callback with success response.' , function () {
+            it('Check call "beforeSave" method. Check "success" ajax callback with success response.', function () {
                 var request;
 
                 $.ajax = jasmine.createSpy().and.callFake(function (req) {
@@ -112,11 +112,13 @@ define([
                 obj.urls.beforeSave = 'requestPath';
                 obj.save();
 
-                expect(request({error: false})).toBe(true);
+                expect(request({
+                    error: false
+                })).toBe(true);
                 expect($('body').notification).not.toHaveBeenCalledWith('clear');
             });
 
-            it('Check call "beforeSave" method. Check "success" ajax callback with error response.' , function () {
+            it('Check call "beforeSave" method. Check "success" ajax callback with error response.', function () {
                 var request,
                     notificationArguments;
 
@@ -140,7 +142,7 @@ define([
                 })).toBeUndefined();
                 expect($('body').notification.calls.allArgs()).toEqual([['clear'], ['add', notificationArguments]]);
             });
-            it('Check call "beforeSave" method. Check "complete" ajax callback.' , function () {
+            it('Check call "beforeSave" method. Check "complete" ajax callback.', function () {
                 var request;
 
                 $.ajax = jasmine.createSpy().and.callFake(function (req) {
diff --git a/dev/tests/js/jasmine/tests/app/code/Magento/Ui/base/js/form/element/multiselect.test.js b/dev/tests/js/jasmine/tests/app/code/Magento/Ui/base/js/form/element/multiselect.test.js
@@ -15,7 +15,8 @@ define([
                 on: jasmine.createSpy()
             },
             'Magento_Ui/js/lib/registry/registry': {
-                get: function() {
+                /** Method stub. */
+                get: function () {
                     return {
                         get: jasmine.createSpy(),
                         set: jasmine.createSpy()
diff --git a/dev/tests/js/jasmine/tests/lib/mage/misc.test.js b/dev/tests/js/jasmine/tests/lib/mage/misc.test.js
@@ -25,6 +25,7 @@ define([
                 data = {
                     key: 'value-prepared-before-save'
                 };
+
             expect(utils.filterFormData(data, suffix, separator)).toEqual(data);
             expect(utils.filterFormData(data, suffix)).toEqual(data);
             expect(utils.filterFormData(data)).toEqual(data);
diff --git a/lib/web/mage/adminhtml/browser.js b/lib/web/mage/adminhtml/browser.js
@@ -125,7 +125,7 @@ define([
 
         /**
          * @param {jQuery.Event} event
-         * @param {Object}data
+         * @param {Object} data
          * @private
          */
         _selectNode: function (event, data) {
@@ -151,7 +151,7 @@ define([
         },
 
         /**
-         * @param {Obejct} element
+         * @param {Object} element
          * @param {*} value
          */
         insertAtCursor: function (element, value) {
@@ -181,7 +181,7 @@ define([
         },
 
         /**
-         * @param {Obejct} node
+         * @param {Object} node
          */
         loadFileList: function (node) {
             var contentBlock = this.element.find('#contents');
@@ -285,7 +285,7 @@ define([
          *  in document:
          *  - element with target ID
          *
-         * return HTMLelement | null
+         * return {HTMLElement|null}
          */
         getTargetElement: function () {
             var opener, targetElementId;
@@ -303,7 +303,7 @@ define([
         /**
          * Return opener Window object if it exists, not closed and editor is active
          *
-         * return object | null
+         * return {Object|null}
          */
         getMediaBrowserOpener: function () {
             if (typeof tinyMCE != 'undefined' &&
diff --git a/lib/web/mage/adminhtml/events.js b/lib/web/mage/adminhtml/events.js
@@ -101,9 +101,9 @@ define([
                             if (this.arrEvents[evtName][i].asynch) {
                                 eventArgs = arguments[1];
                                 method = this.arrEvents[evtName][i].method.bind(this);
-                                setTimeout(function () { //eslint-disable-line no-loop-func, no-extra-bind
+                                setTimeout(function () { //eslint-disable-line no-loop-func
                                     method(eventArgs);
-                                }.bind(this), 10);
+                                }, 10);
                             } else {
                                 result = this.arrEvents[evtName][i].method(arguments[1]);
                             }
diff --git a/lib/web/mage/adminhtml/form.js b/lib/web/mage/adminhtml/form.js
@@ -133,8 +133,8 @@ define([
             this.config = regions.config;
             delete regions.config;
             this.regions = regions;
-            this.disableAction = typeof disableAction == 'undefined' ? 'hide' : disableAction;
-            this.clearRegionValueOnDisable = typeof clearRegionValueOnDisable == 'undefined' ?
+            this.disableAction = typeof disableAction === 'undefined' ? 'hide' : disableAction;
+            this.clearRegionValueOnDisable = typeof clearRegionValueOnDisable === 'undefined' ?
                 false : clearRegionValueOnDisable;
 
             if (this.regionSelectEl.options.length <= 1) {
diff --git a/lib/web/mage/adminhtml/grid.js b/lib/web/mage/adminhtml/grid.js
@@ -685,7 +685,7 @@ define([
         },
 
         /**
-         * @param {*} gridIds
+         * @param {Array} gridIds
          */
         setGridIds: function (gridIds) {
             this.gridIds = gridIds;
@@ -761,7 +761,7 @@ define([
         },
 
         /**
-         * @param {*}grid
+         * @param {*} grid
          * @param {*} row
          */
         onGridRowInit: function (grid, row) {
@@ -1377,7 +1377,7 @@ define([
         },
 
         /**
-         * @param {String}callbackName
+         * @param {String} callbackName
          * @param {Function} callback
          */
         setOldCallback: function (callbackName, callback) {
diff --git a/lib/web/mage/backend/editablemultiselect.js b/lib/web/mage/backend/editablemultiselect.js
@@ -17,16 +17,17 @@ define([
      * This class is defined in global scope ('var' is not needed).
      *
      *  @param {Object} settings - settings object.
-     *  {String} settings[add_button_caption] caption of the 'Add New Value' button
-     *  {String} settings[new_url] URL to which new request has to be submitted
-     *  {String} settings[save_url] URL to which save request has to be submitted
-     *  {String} settings[delete_url] URL to which delete request has to be submitted
-     *  {String} settings[delete_confirm_message] confirmation message that is shown to user during delete operation
-     *  {String} settings[target_select_id] HTML ID of target select element
-     *  {Hash} settings[submit_data] extra parameters to send with new/edit/delete requests
-     *  {String} settings[entity_value_name] name of the request parameter that represents select option text
-     *  {String} settings[entity_id_name] name of the request parameter that represents select option value
-     *  {Boolean} settings[is_entry_editable] flag that shows if user can add/edit/remove data
+     *  @param {String} settings.add_button_caption - caption of the 'Add New Value' button
+     *  @param {String} settings.new_url - URL to which new request has to be submitted
+     *  @param {String} settings.save_url - URL to which save request has to be submitted
+     *  @param {String} settings.delete_url - URL to which delete request has to be submitted
+     *  @param {String} settings.delete_confirm_message - confirmation message that is shown to user during
+     *      delete operation
+     *  @param {String} settings.target_select_id - HTML ID of target select element
+     *  @param {Hash} settings.submit_data - extra parameters to send with new/edit/delete requests
+     *  @param {String} settings.entity_value_name - name of the request parameter that represents select option text
+     *  @param {String} settings.entity_id_name - name of the request parameter that represents select option value
+     *  @param {Boolean} settings.is_entry_editable - flag that shows if user can add/edit/remove data
      *
      * @constructor
      */
diff --git a/lib/web/mage/backend/menu.js b/lib/web/mage/backend/menu.js
@@ -158,7 +158,6 @@
             // Clicks outside of a menu collapse any open menus
             this._on(this.document, {
                 /**
-                 *
                  * @param {jQuery.Event} event
                  */
                 click: function (event) {
@@ -584,7 +583,8 @@
         // it closes all menus.  If passed an argument, it will search for menus BELOW
         /**
          * With no arguments, closes the currently active menu - if nothing is active
-         * it closes all menus.  If passed an argument, it will search for menus BELOW
+         * it closes all menus.  If passed an argument, it will search for menus BELOW.
+         *
          * @param {*} startMenu
          * @private
          */
@@ -651,14 +651,14 @@
         },
 
         /**
-         * @return {null|*|Boolean}
+         * @return {null|Boolean}
          */
         isFirstItem: function () {
             return this.active && !this.active.prevAll('.ui-menu-item').length;
         },
 
         /**
-         * @return {*|null|Boolean}
+         * @return {null|Boolean}
          */
         isLastItem: function () {
             return this.active && !this.active.nextAll('.ui-menu-item').length;
diff --git a/lib/web/mage/backend/suggest.js b/lib/web/mage/backend/suggest.js
@@ -595,7 +595,7 @@
                 term: this._term,
 
                 /**
-                 * @param {Obejct} item
+                 * @param {Object} item
                  * @return {String}
                  */
                 optionData: function (item) {
@@ -608,7 +608,7 @@
         },
 
         /**
-         * @param {Objetc} item
+         * @param {Object} item
          * @return {Boolean}
          * @private
          */
diff --git a/lib/web/mage/backend/validation.js b/lib/web/mage/backend/validation.js
@@ -161,7 +161,8 @@
         },
 
         /**
-         * Process ajax success
+         * Process ajax success.
+         *
          * @protected
          * @param {Object} response
          */
@@ -175,7 +176,7 @@
         },
 
         /**
-         * Submitting a form
+         * Submitting a form.
          * @private
          */
         _submit: function () {
@@ -185,6 +186,7 @@
 
         /**
          * Displays errors after backend validation.
+         *
          * @param {Object} data - Data that came from backend.
          */
         _showErrors: function (data) {
diff --git a/lib/web/mage/collapsible.js b/lib/web/mage/collapsible.js
@@ -355,7 +355,7 @@ define([
         },
 
         /**
-         * @param {*}prop
+         * @param {*} prop
          * @private
          */
         _animate: function (prop) {
diff --git a/lib/web/mage/dropdown.js b/lib/web/mage/dropdown.js
@@ -215,7 +215,7 @@ define([
         },
 
         /**
-         * @param {Obejct} handler
+         * @param {Object} handler
          * @private
          */
         _mouseLeave: function (handler) {
diff --git a/lib/web/mage/dropdowns.js b/lib/web/mage/dropdowns.js
@@ -62,7 +62,7 @@ define([
         /**
          * Reset all dropdowns.
          *
-         * @param {Object}param
+         * @param {Object} param
          */
         this.reset = function (param) {
             var params = param || {},
diff --git a/lib/web/mage/edit-trigger.js b/lib/web/mage/edit-trigger.js
diff --git a/lib/web/mage/tabs.js b/lib/web/mage/tabs.js
diff --git a/lib/web/mage/terms.js b/lib/web/mage/terms.js
diff --git a/lib/web/mage/utils/arrays.js b/lib/web/mage/utils/arrays.js
diff --git a/lib/web/mage/utils/misc.js b/lib/web/mage/utils/misc.js
diff --git a/lib/web/mage/validation.js b/lib/web/mage/validation.js
diff --git a/lib/web/mage/webapi.js b/lib/web/mage/webapi.js
diff --git a/lib/web/mage/zoom.js b/lib/web/mage/zoom.js

Original file line number	Diff line number	Diff line change
`@@ -244,8 +244,8 @@ define([`
`244`	`244`	`emailValidationResult = customer.isLoggedIn(),`
`245`	`245`	`field;`
`246`	`246`
`247`		`- if (!quote.shippingMethod()) {`
`248`		`- this.errorValidationMessage($t('Please specify a shipping method.'));`
	`247`	`+ if (!quote.shippingMethod()) {`
	`248`	`+ this.errorValidationMessage($t('Please specify a shipping method.'));`
`249`	`249`
`250`	`250`	`return false;`
`251`	`251`	`}`