Replace two calls to str_replace() by single strtr()

andrey-legayev · andrey-legayev · commit e917b007ed8a · 2019-10-17T23:27:17.000+03:00
I've tested: str_replace() is slower than strtr() in this case
diff --git a/lib/internal/Magento/Framework/Phrase/Renderer/Translate.php b/lib/internal/Magento/Framework/Phrase/Renderer/Translate.php
@@ -50,8 +50,7 @@ public function render(array $source, array $arguments)
     {
         $text = end($source);
         /* If phrase contains escaped quotes then use translation for phrase with non-escaped quote */
-        $text = str_replace('\"', '"', $text);
-        $text = str_replace("\\'", "'", $text);
+        $text = strtr($text, ['\"' => '"', "\\'" => "'"]);
 
         try {
             $data = $this->translator->getData();

Original file line number	Diff line number	Diff line change
`@@ -50,8 +50,7 @@ public function render(array $source, array $arguments)`
`50`	`50`	`{`
`51`	`51`	`$text = end($source);`
`52`	`52`	`/* If phrase contains escaped quotes then use translation for phrase with non-escaped quote */`
`53`		`- $text = str_replace('\"', '"', $text);`
`54`		`- $text = str_replace("\\'", "'", $text);`
	`53`	`+ $text = strtr($text, ['\"' => '"', "\\'" => "'"]);`
`55`	`54`
`56`	`55`	`try {`
`57`	`56`	`$data = $this->translator->getData();`