MAGETWO-97866: [Magento Cloud] news_from_date and news_to_date dates incorrect in database with scheduled updates

Due to unstable work of intl parsing on different platforms

Author: rostyslav-hymon

app/code/Magento/Cron/Model/Schedule.php

@@ -62,8 +62,8 @@ class Schedule extends \Magento\Framework\Model\AbstractModel
      * @param \Magento\Framework\Model\ResourceModel\AbstractResource $resource
      * @param \Magento\Framework\Data\Collection\AbstractDb $resourceCollection
      * @param array $data
-     * @param TimezoneInterface $timezoneConverter
-     * @param DateTimeFactory $dateTimeFactory
+     * @param TimezoneInterface|null $timezoneConverter
+     * @param DateTimeFactory|null $dateTimeFactory
      */
     public function __construct(
         \Magento\Framework\Model\Context $context,
@@ -125,7 +125,7 @@ public function trySchedule()
         if (!is_numeric($time)) {
             //convert time from UTC to admin store timezone
             //we assume that all schedules in configuration (crontab.xml and DB tables) are in admin store timezone
-            $dateTimeUtc = $this->dateTimeFactory->create($time, new \DateTimeZone('UTC'));
+            $dateTimeUtc = $this->dateTimeFactory->create($time);
             $time = $dateTimeUtc->getTimestamp();
         }
         $time = $storeDateTime->setTimestamp($time);

app/code/Magento/Cron/Test/Unit/Model/ScheduleTest.php

@@ -206,14 +206,14 @@ public function testTrySchedule($scheduledAt, $cronExprArr, $expected): void
             ->willReturn('UTC');
 
         $this->dateTimeFactory->method('create')
-            ->willReturn(new \DateTime(null, new \DateTimeZone('UTC')));
+            ->willReturn(new \DateTime());
 
         /** @var \Magento\Cron\Model\Schedule $model */
         $model = $this->helper->getObject(
             \Magento\Cron\Model\Schedule::class,
             [
                 'timezoneConverter' => $this->timezoneConverter,
-                'dateTimeFactory' => $this->dateTimeFactory
+                'dateTimeFactory' => $this->dateTimeFactory,
             ]
         );
 
@@ -242,14 +242,14 @@ public function testTryScheduleWithConversionToAdminStoreTime(): void
             ->willReturn('UTC');
 
         $this->dateTimeFactory->method('create')
-            ->willReturn(new \DateTime(null, new \DateTimeZone('UTC')));
+            ->willReturn(new \DateTime());
 
         /** @var \Magento\Cron\Model\Schedule $model */
         $model = $this->helper->getObject(
             \Magento\Cron\Model\Schedule::class,
             [
                 'timezoneConverter' => $this->timezoneConverter,
-                'dateTimeFactory' => $this->dateTimeFactory
+                'dateTimeFactory' => $this->dateTimeFactory,
             ]
         );
 
@@ -272,7 +272,7 @@ public function testTryScheduleWithConversionToAdminStoreTime(): void
     public function tryScheduleDataProvider(): array
     {
         $date = '2011-12-13 14:15:16';
-        $timestamp = (new \DateTime($date, new \DateTimeZone('UTC')))->getTimestamp();
+        $timestamp = (new \DateTime($date))->getTimestamp();
         $day = 'Monday';
         return [
             [$date, [], false],
@@ -286,7 +286,7 @@ public function tryScheduleDataProvider(): array
             [$timestamp, ['*', '14', '*', '*', '*'], true],
             [$timestamp, ['*', '*', '13', '*', '*'], true],
             [$timestamp, ['*', '*', '*', '12', '*'], true],
-            [(new \DateTime($day, new \DateTimeZone('UTC')))->getTimestamp(), ['*', '*', '*', '*', '1'], true],
+            [(new \DateTime($day))->getTimestamp(), ['*', '*', '*', '*', '1'], true],
         ];
     }