MAGETWO-99867: Braintree - 3D Secure 2.0 Support for 2.3

Author: viktym

dev/tests/functional/tests/app/Magento/Braintree/Test/Block/Form/Secure3d.php

@@ -19,9 +19,23 @@ class Secure3d extends Form
     /**
      * 3D Secure iFrame locator.
      *
-     * @var array
+     * @var string
+     */
+    protected $braintree3dSecure = "//iframe[contains(@id, 'braintreethreedsecurelanding')]";
+
+    /**
+     * AuthWindow locator.
+     *
+     * @var string
      */
-    protected $braintree3dSecure = "//iframe[contains(@src, 'braintreegateway.com/3ds')]";
+    private $authWindow3dSecure = "//iframe[contains(@id, 'authWindow')]";
+
+    /**
+     * Password field locator.
+     *
+     * @var string
+     */
+    private $passwordField = "//*[@name='external.field.password']";
 
     /**
      * Submit button button css selector.
@@ -33,12 +47,12 @@ class Secure3d extends Form
     /**
      * Switch to 3D Secure iFrame.
      *
-     * @param array $locator
+     * @param string $locator
      */
     public function switchToFrame($locator)
     {
-         $this->browser->switchToFrame(new Locator($locator, Locator::SELECTOR_XPATH));
-         $this->browser->switchToFrame(new Locator($locator, Locator::SELECTOR_XPATH));
+        $this->browser->switchToFrame(new Locator($locator, Locator::SELECTOR_XPATH));
+        $this->browser->switchToFrame(new Locator($this->authWindow3dSecure, Locator::SELECTOR_XPATH));
     }
 
     /**
@@ -56,13 +70,20 @@ public function submit()
      *
      * @param FixtureInterface $fixture
      * @param SimpleElement|null $element
+     *
      * @return $this|void
      */
     public function fill(FixtureInterface $fixture, SimpleElement $element = null)
     {
         $mapping = $this->dataMapping($fixture->getData());
         $this->switchToFrame($this->braintree3dSecure);
         $element = $this->browser->find('body');
+        $this->browser->waitUntil(
+            function () use ($element) {
+                $fieldElement = $element->find($this->passwordField, Locator::SELECTOR_XPATH);
+                return $fieldElement->isVisible() ? true : null;
+            }
+        );
         $this->_fill([$mapping['secure3d_password']], $element);
         $this->submit();
         $this->browser->switchToFrame();