MC-38443: [GraphQl] media_gallery has redundant entries in configurable_options_selection_metadata

- Fixed redundant entries and updated query name

Author: Prabhu Ram

app/code/Magento/ConfigurableProductGraphQl/Model/Resolver/OptionsSelectionMetadata.php

@@ -40,7 +40,7 @@ public function resolve(Field $field, $context, ResolveInfo $info, array $value
             throw new LocalizedException(__('"model" value should be specified'));
         }
 
-        $selectedOptions = $args['selectedConfigurableOptionValues'] ?? [];
+        $selectedOptions = $args['configurableOptionValueUids'] ?? [];
         /** @var ProductInterface $product */
         $product = $value['model'];
 

app/code/Magento/ConfigurableProductGraphQl/Model/Resolver/SelectionMediaGallery.php

@@ -30,8 +30,10 @@ public function resolve(Field $field, $context, ResolveInfo $info, array $value
         foreach ($usedProducts as $usedProduct) {
             if (in_array($usedProduct->getId(), $availableSelectionProducts)) {
                 foreach ($usedProduct->getMediaGalleryEntries() ?? [] as $key => $entry) {
-                    $index = $usedProduct->getId() . '_' . $key;
-                    $mediaGalleryEntries[$index] = $entry->getData();
+                    $entryData = $entry->getData();
+                    $initialIndex = $usedProduct->getId() . '_' . $key;
+                    $index = $this->prepareIndex($entryData, $initialIndex);
+                    $mediaGalleryEntries[$index] = $entryData;
                     $mediaGalleryEntries[$index]['model'] = $usedProduct;
                     if ($entry->getExtensionAttributes() && $entry->getExtensionAttributes()->getVideoContent()) {
                         $mediaGalleryEntries[$index]['video_content']
@@ -42,4 +44,26 @@ public function resolve(Field $field, $context, ResolveInfo $info, array $value
         }
         return $mediaGalleryEntries;
     }
+
+    /**
+     * Formulate an index to have unique set of media entries
+     *
+     * @param array $entryData
+     * @param string $initialIndex
+     * @return string
+     */
+    private function prepareIndex(array $entryData, string $initialIndex) : string
+    {
+        $index = $initialIndex;
+        if (isset($entryData['media_type'])) {
+            $index = $entryData['media_type'];
+        }
+        if (isset($entryData['file'])) {
+            $index = $index.'_'.$entryData['file'];
+        }
+        if (isset($entryData['position'])) {
+            $index = $index.'_'.$entryData['position'];
+        }
+        return $index;
+    }
 }

app/code/Magento/ConfigurableProductGraphQl/etc/schema.graphqls

@@ -7,7 +7,7 @@ type Mutation {
 type ConfigurableProduct implements ProductInterface, PhysicalProductInterface, CustomizableProductInterface @doc(description: "ConfigurableProduct defines basic features of a configurable product and its simple product variants") {
     variants: [ConfigurableVariant] @doc(description: "An array of variants of products") @resolver(class: "Magento\\ConfigurableProductGraphQl\\Model\\Resolver\\ConfigurableVariant")
     configurable_options: [ConfigurableProductOptions] @doc(description: "An array of linked simple product items") @resolver(class: "Magento\\ConfigurableProductGraphQl\\Model\\Resolver\\Options")
-    configurable_options_selection_metadata(selectedConfigurableOptionValues: [ID!]): ConfigurableOptionsSelectionMetadata @doc(description: "Metadata for the specified configurable options selection") @resolver(class: "Magento\\ConfigurableProductGraphQl\\Model\\Resolver\\OptionsSelectionMetadata")
+    configurable_product_options_selection(configurableOptionValueUids: [ID!]): ConfigurableProductOptionsSelection @doc(description: "Metadata for the specified configurable options selection") @resolver(class: "Magento\\ConfigurableProductGraphQl\\Model\\Resolver\\OptionsSelectionMetadata")
 }
 
 type ConfigurableVariant @doc(description: "An array containing all the simple product variants of a configurable product") {
@@ -80,7 +80,7 @@ type ConfigurableWishlistItem implements WishlistItemInterface @doc(description:
     configurable_options: [SelectedConfigurableOption!] @resolver(class: "\\Magento\\ConfigurableProductGraphQl\\Model\\Wishlist\\ConfigurableOptions") @doc (description: "An array of selected configurable options")
 }
 
-type ConfigurableOptionsSelectionMetadata @doc(description: "Metadata corresponding to the configurable options selection.") {
+type ConfigurableProductOptionsSelection @doc(description: "Metadata corresponding to the configurable options selection.") {
     options_available_for_selection: [ConfigurableOptionAvailableForSelection!] @doc(description: "Configurable options available for further selection based on current selection.")
     media_gallery: [MediaGalleryInterface!] @resolver(class: "Magento\\ConfigurableProductGraphQl\\Model\\Resolver\\SelectionMediaGallery") @doc(description: "Product images and videos corresponding to the specified configurable options selection.")
     variant: SimpleProduct @resolver(class: "Magento\\ConfigurableProductGraphQl\\Model\\Resolver\\Variant\\Variant") @doc(description: "Variant represented by the specified configurable options selection. It is expected to be null, until selections are made for each configurable option.")