MAGETWO-64802: Implement corrupted data reporting for fieldDataConverter

rganin · rganin · commit ead4b651841d · 2017-02-24T14:08:09.000+02:00
diff --git a/lib/internal/Magento/Framework/DB/FieldDataConverter.php b/lib/internal/Magento/Framework/DB/FieldDataConverter.php
@@ -116,7 +116,7 @@ public function convert(
     private function isValidJsonValue($value)
     {
         if (in_array($value, ['null', 'false', '0', '""', '[]'])
-            || (json_decode($value) !== null && !json_last_error())
+            || (json_decode($value) !== null && json_last_error() === JSON_ERROR_NONE)
         ) {
             return true;
         }

Original file line number	Diff line number	Diff line change
`@@ -116,7 +116,7 @@ public function convert(`
`116`	`116`	`private function isValidJsonValue($value)`
`117`	`117`	`{`
`118`	`118`	`if (in_array($value, ['null', 'false', '0', '""', '[]'])`
`119`		`- \|\| (json_decode($value) !== null && !json_last_error())`
	`119`	`+ \|\| (json_decode($value) !== null && json_last_error() === JSON_ERROR_NONE)`
`120`	`120`	`) {`
`121`	`121`	`return true;`
`122`	`122`	`}`