Skip to content

Commit eaedbba

Browse files
committed
MAGETWO-47555: [GITHUB] Import error message does not insert variable #2844
1 parent 85659a5 commit eaedbba

File tree

1 file changed

+14
-17
lines changed
  • app/code/Magento/CatalogImportExport/Model/Import/Product

1 file changed

+14
-17
lines changed

app/code/Magento/CatalogImportExport/Model/Import/Product/Validator.php

Lines changed: 14 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -34,13 +34,12 @@ class Validator extends AbstractValidator implements RowValidatorInterface
3434
* @var array
3535
*/
3636
protected $_rowData;
37-
37+
3838
/*
39-
* @var string
39+
* @var string|null
4040
*/
41-
protected $_invalidAttribute;
42-
43-
41+
protected $invalidAttribute;
42+
4443
/**
4544
* @param \Magento\Framework\Stdlib\StringUtils $string
4645
* @param RowValidatorInterface[] $validators
@@ -210,28 +209,26 @@ public function isAttributeValid($attrCode, array $attrParams, array $rowData)
210209
if (!$valid) {
211210
$this->setInvalidAttribute($attrCode);
212211
}
213-
212+
214213
return (bool)$valid;
215214

216215
}
217-
218-
219-
public function setInvalidAttribute($attribute)
216+
217+
/**
218+
* @param string|null $attribute
219+
*/
220+
protected function setInvalidAttribute($attribute)
220221
{
221-
$this->_invalidAttribute = $attribute;
222+
$this->invalidAttribute = $attribute;
222223
}
223-
224+
224225
/*
225226
* @return string
226227
*/
227228
public function getInvalidAttribute()
228229
{
229-
return $this->_invalidAttribute;
230+
return $this->invalidAttribute;
230231
}
231-
232-
233-
234-
235232

236233
/**
237234
* @return bool
@@ -240,7 +237,7 @@ public function getInvalidAttribute()
240237
protected function isValidAttributes()
241238
{
242239
$this->_clearMessages();
243-
$this->setInvalidAttribute(NULL);
240+
$this->setInvalidAttribute(null);
244241
if (!isset($this->_rowData['product_type'])) {
245242
return false;
246243
}

0 commit comments

Comments
 (0)