Skip to content

Commit ebce95b

Browse files
committed
B2B-2155: Use Redis as message queue
- fix MessageQueue framework integration tests
1 parent c8fdb42 commit ebce95b

File tree

4 files changed

+29
-7
lines changed

4 files changed

+29
-7
lines changed

dev/tests/integration/_files/Magento/TestModuleMessageQueueConfiguration/etc/queue.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
<broker topic="deprecated.config.sync.bool.topic" type="db" exchange="customExchange">
1717
<queue consumer="deprecatedConfigSyncBoolConsumer" name="deprecated.config.queue.4"/>
1818
</broker>
19-
<broker topic="overlapping.topic.declaration" type="db" exchange="overlappingDeprecatedExchange">
19+
<broker topic="overlapping.topic.declaration" exchange="overlappingDeprecatedExchange">
2020
<queue consumer="overlappingConsumerDeclaration" name="consumer.config.queue" consumerInstance="Magento\Framework\MessageQueue\BatchConsumer" maxMessages="222" handler="Magento\TestModuleMessageQueueConfiguration\AsyncHandler::methodWithMixedParam"/>
2121
</broker>
2222
</config>

dev/tests/integration/testsuite/Magento/Framework/MessageQueue/Consumer/DeprecatedConfigTest.php

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
namespace Magento\Framework\MessageQueue\Consumer;
77

88
use Magento\Framework\MessageQueue\Consumer\Config\ConsumerConfigItem\Handler\Iterator as HandlerIterator;
9+
use Magento\Framework\MessageQueue\DefaultValueProvider;
910

1011
/**
1112
* Test access to consumer configuration declared in deprecated queue.xml configs using Consumer\ConfigInterface.
@@ -19,9 +20,15 @@ class DeprecatedConfigTest extends \PHPUnit\Framework\TestCase
1920
*/
2021
private $objectManager;
2122

23+
/**
24+
* @var DefaultValueProvider
25+
*/
26+
private $defaultValueProvider;
27+
2228
protected function setUp(): void
2329
{
2430
$this->objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager();
31+
$this->defaultValueProvider = $this->objectManager->get(DefaultValueProvider::class);
2532
}
2633

2734
public function testGetConsumerMultipleHandlersFromCommunicationConfig()
@@ -53,7 +60,7 @@ public function testGetConsumerCustomHandler()
5360

5461
$this->assertEquals('deprecatedConfigAsyncMixedConsumer', $consumer->getName());
5562
$this->assertEquals('deprecated.config.queue.3', $consumer->getQueue());
56-
$this->assertEquals('db', $consumer->getConnection());
63+
$this->assertEquals($this->defaultValueProvider->getConnection(), $consumer->getConnection());
5764
$this->assertEquals(\Magento\Framework\MessageQueue\ConsumerInterface::class, $consumer->getConsumerInstance());
5865
$this->assertNull($consumer->getMaxMessages());
5966

@@ -91,7 +98,7 @@ public function testGetConsumerCustomConsumerAndMaxMessages()
9198

9299
$this->assertEquals('deprecatedConfigAsyncStringConsumer', $consumer->getName());
93100
$this->assertEquals('deprecated.config.queue.1', $consumer->getQueue());
94-
$this->assertEquals('db', $consumer->getConnection());
101+
$this->assertEquals($this->defaultValueProvider->getConnection(), $consumer->getConnection());
95102
$this->assertEquals(\Magento\Framework\MessageQueue\BatchConsumer::class, $consumer->getConsumerInstance());
96103
$this->assertEquals(200, $consumer->getMaxMessages());
97104

dev/tests/integration/testsuite/Magento/Framework/MessageQueue/Publisher/DeprecatedConfigTest.php

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
*/
66
namespace Magento\Framework\MessageQueue\Publisher;
77

8+
use Magento\Framework\MessageQueue\DefaultValueProvider;
9+
810
/**
911
* Test access to publisher configuration declared in deprecated queue.xml configs using Publisher\ConfigInterface.
1012
*
@@ -17,9 +19,15 @@ class DeprecatedConfigTest extends \PHPUnit\Framework\TestCase
1719
*/
1820
private $objectManager;
1921

22+
/**
23+
* @var DefaultValueProvider
24+
*/
25+
private $defaultValueProvider;
26+
2027
protected function setUp(): void
2128
{
2229
$this->objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager();
30+
$this->defaultValueProvider = $this->objectManager->get(DefaultValueProvider::class);
2331
}
2432

2533
public function testGetPublisher()
@@ -31,7 +39,7 @@ public function testGetPublisher()
3139
$this->assertFalse($publisher->isDisabled());
3240

3341
$connection = $publisher->getConnection();
34-
$this->assertEquals('db', $connection->getName());
42+
$this->assertEquals($this->defaultValueProvider->getConnection(), $connection->getName());
3543
$this->assertEquals('magento', $connection->getExchange());
3644
$this->assertFalse($connection->isDisabled());
3745
}
@@ -59,7 +67,7 @@ public function testGetOverlapWithQueueConfig()
5967
$this->assertFalse($publisher->isDisabled());
6068

6169
$connection = $publisher->getConnection();
62-
$this->assertEquals('db', $connection->getName());
70+
$this->assertEquals($this->defaultValueProvider->getConnection(), $connection->getName());
6371
$this->assertEquals('magento', $connection->getExchange());
6472
$this->assertFalse($connection->isDisabled());
6573
}

dev/tests/integration/testsuite/Magento/Framework/MessageQueue/Topology/DeprecatedConfigTest.php

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
*/
66
namespace Magento\Framework\MessageQueue\Topology;
77

8+
use Magento\Framework\MessageQueue\DefaultValueProvider;
89
use Magento\Framework\MessageQueue\Topology\Config\ExchangeConfigItem\Binding\Iterator as BindingIterator;
910

1011
/**
@@ -19,9 +20,15 @@ class DeprecatedConfigTest extends \PHPUnit\Framework\TestCase
1920
*/
2021
private $objectManager;
2122

23+
/**
24+
* @var DefaultValueProvider
25+
*/
26+
private $defaultValueProvider;
27+
2228
protected function setUp(): void
2329
{
2430
$this->objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager();
31+
$this->defaultValueProvider = $this->objectManager->get(DefaultValueProvider::class);
2532
}
2633

2734
public function testGetTopology()
@@ -62,10 +69,10 @@ public function testGetTopologyOverlapWithQueueConfig()
6269
{
6370
/** @var \Magento\Framework\MessageQueue\Topology\ConfigInterface $config */
6471
$config = $this->objectManager->create(\Magento\Framework\MessageQueue\Topology\ConfigInterface::class);
65-
$topology = $config->getExchange('overlappingDeprecatedExchange', 'db');
72+
$topology = $config->getExchange('overlappingDeprecatedExchange', $this->defaultValueProvider->getConnection());
6673
$this->assertEquals('overlappingDeprecatedExchange', $topology->getName());
6774
$this->assertEquals('topic', $topology->getType());
68-
$this->assertEquals('db', $topology->getConnection());
75+
$this->assertEquals($this->defaultValueProvider->getConnection(), $topology->getConnection());
6976
$this->assertTrue($topology->isDurable());
7077
$this->assertFalse($topology->isAutoDelete());
7178
$this->assertFalse($topology->isInternal());

0 commit comments

Comments
 (0)