MAGETWO-63945: Add extension point to sales grid indexer

- Rename IdListProviderComposite to IdListProvider
- Fix static

Author: viktym

app/code/Magento/Sales/Model/ResourceModel/AbstractGrid.php

@@ -67,6 +67,7 @@ public function getGridTable()
     {
         return $this->getTable($this->gridTableName);
     }
+
     /**
      * Purge grid row
      *

app/code/Magento/Sales/Model/ResourceModel/Provider/IdListProviderComposite.php renamed to app/code/Magento/Sales/Model/ResourceModel/Provider/IdListProvider.php

@@ -10,7 +10,7 @@
 /**
  * Implements IdListProviderInterface as composite
  */
-class IdListProviderComposite implements IdListProviderInterface
+class IdListProvider implements IdListProviderInterface
 {
     /**
      * @var IdListProviderInterface[]

app/code/Magento/Sales/Model/ResourceModel/Provider/IdListProviderInterface.php

@@ -6,7 +6,7 @@
 namespace Magento\Sales\Model\ResourceModel\Provider;
 
 /**
- * Interface provides entities ids list that should be updated in grid
+ * Interface provides entities id list that should be updated in grid
  */
 interface IdListProviderInterface
 {

app/code/Magento/Sales/Model/ResourceModel/Provider/UpdatedIdListProvider.php

@@ -62,6 +62,6 @@ private function getLastUpdatedAtValue($gridTableName)
      */
     private function getConnection()
     {
-        return $this->resourceConnection->getConnection('sales');
+        return $this->resourceConnection->getConnection();
     }
 }

app/code/Magento/Sales/Test/Unit/Model/ResourceModel/Provider/IdListProviderCompositeTest.php renamed to app/code/Magento/Sales/Test/Unit/Model/ResourceModel/Provider/IdListProviderTest.php

@@ -7,14 +7,14 @@
 
 use Magento\Framework\ObjectManager\TMap;
 use Magento\Framework\ObjectManager\TMapFactory;
-use Magento\Sales\Model\ResourceModel\Provider\IdListProviderComposite;
+use Magento\Sales\Model\ResourceModel\Provider\IdListProvider;
 use Magento\Sales\Model\ResourceModel\Provider\IdListProviderInterface;
 use PHPUnit_Framework_MockObject_MockObject as MockObject;
 
 /**
- * Class IdListProviderCompositeTest
+ * Class IdListProviderTest
  */
-class IdListProviderCompositeTest extends \PHPUnit_Framework_TestCase
+class IdListProviderTest extends \PHPUnit_Framework_TestCase
 {
     public function testGetEmpty()
     {
@@ -40,12 +40,12 @@ public function testGetEmpty()
             ->method('getIterator')
             ->willReturn(new \ArrayIterator([]));
 
-        $provider = new IdListProviderComposite($tMapFactory, []);
+        $provider = new IdListProvider($tMapFactory, []);
         static::assertEquals([], $provider->get('main_table', 'grid_table'));
     }
 
     /**
-     * @covers \Magento\Sales\Model\ResourceModel\Provider\IdListProviderComposite::get
+     * @covers \Magento\Sales\Model\ResourceModel\Provider\IdListProvider::get
      */
     public function testGet()
     {
@@ -86,7 +86,7 @@ public function testGet()
             ->method('getIterator')
             ->willReturn(new \ArrayIterator([$provider1, $provider2]));
 
-        $provider = new IdListProviderComposite(
+        $provider = new IdListProvider(
             $tMapFactory,
             [
                 'provider1' => IdListProviderInterface::class,

app/code/Magento/Sales/etc/di.xml

@@ -113,8 +113,8 @@
     <preference for="Magento\Sales\Model\Order\Creditmemo\NotifierInterface" type="Magento\Sales\Model\Order\Creditmemo\Notifier"/>
     <preference for="Magento\Sales\Api\RefundOrderInterface" type="Magento\Sales\Model\RefundOrder"/>
     <preference for="Magento\Sales\Api\RefundInvoiceInterface" type="Magento\Sales\Model\RefundInvoice"/>
-    <preference for="Magento\Sales\Model\ResourceModel\Provider\IdListProviderInterface" type="Magento\Sales\Model\ResourceModel\Provider\IdListProviderComposite" />
-    <type name="Magento\Sales\Model\ResourceModel\Provider\IdListProviderComposite">
+    <preference for="Magento\Sales\Model\ResourceModel\Provider\IdListProviderInterface" type="Magento\Sales\Model\ResourceModel\Provider\IdListProvider" />
+    <type name="Magento\Sales\Model\ResourceModel\Provider\IdListProvider">
         <arguments>
             <argument name="providers" xsi:type="array">
                 <item name="default" xsi:type="string">Magento\Sales\Model\ResourceModel\Provider\UpdatedIdListProvider</item>

dev/tests/integration/testsuite/Magento/Sales/Model/ResourceModel/GridTest.php

@@ -5,6 +5,9 @@
  */
 namespace Magento\Sales\Model\ResourceModel;
 
+use Magento\Sales\Model\ResourceModel\Order\Grid\Collection;
+use Magento\TestFramework\Helper\Bootstrap;
+
 /**
  * Class GridTest
  */
@@ -22,7 +25,7 @@ class GridTest extends \PHPUnit_Framework_TestCase
 
     protected function setUp()
     {
-        $this->objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager();
+        $this->objectManager = Bootstrap::getObjectManager();
         $this->resourceModel = $this->objectManager->create('Magento\Sales\Model\ResourceModel\Order\Grid');
     }
 
@@ -58,16 +61,14 @@ public function testRefreshByScheduleSyncModeSuccess()
     }
 
     /**
-     * Returns value of signifyd_guarantee_status column from sales order grid
+     * Returns sales order grid items
      *
-     * @return string|null
+     * @return \Magento\Framework\DataObject[]
      */
     private function getOrderGridItemList()
     {
-        /** @var \Magento\Sales\Model\ResourceModel\Order\Grid\Collection $orderGridCollection */
-        $orderGridCollection = $this->objectManager->get(
-            \Magento\Sales\Model\ResourceModel\Order\Grid\Collection::class
-        );
+        /** @var Collection $orderGridCollection */
+        $orderGridCollection = $this->objectManager->get(Collection::class);
 
         return $orderGridCollection->addFilter('increment_id', '100000001')->getItems();
     }