MC-5620: --convert-old-scripts mode does not convert indexes and constraints correctly

Author: fascinosum

lib/internal/Magento/Framework/Setup/Test/Unit/SchemaListenerTest.php

@@ -127,6 +127,7 @@ public function testCreateTable() : void
                         'default' => 'CURRENT_TIMESTAMP',
                         'disabled' => false,
                         'onCreate' => null,
+                        'comment' => 'Column with type timestamp init update',
                     ],
                 'integer' =>
                     [
@@ -139,6 +140,7 @@ public function testCreateTable() : void
                         'default' => null,
                         'disabled' => false,
                         'onCreate' => null,
+                        'comment' => 'Integer'
                     ],
                 'decimal' =>
                     [
@@ -151,6 +153,7 @@ public function testCreateTable() : void
                         'default' => null,
                         'disabled' => false,
                         'onCreate' => null,
+                        'comment' => 'Decimal'
                     ],
             ],
             $tables['First_Module']['new_table']['columns']

lib/internal/Magento/Framework/Setup/Test/Unit/SchemaPersistorTest.php

@@ -152,13 +152,13 @@ public function schemaListenerTablesDataProvider() : array
                                 <column xmlns:xsi="xsi" xsi:type="integer" name="first_column" nullable="1" 
                                     unsigned="0"/>
                                 <column xmlns:xsi="xsi" xsi:type="date" name="second_column" nullable="0"/>
-                                <constraint xmlns:xsi="xsi" xsi:type="foreign" name="some_foreign_constraint" 
+                                <constraint xmlns:xsi="xsi" xsi:type="foreign" referenceId="some_foreign_constraint" 
                                     referenceTable="table" referenceColumn="column" 
                                     table="first_table" column="first_column"/>
-                                <constraint xmlns:xsi="xsi" xsi:type="primary" name="PRIMARY">
+                                <constraint xmlns:xsi="xsi" xsi:type="primary" referenceId="PRIMARY">
                                     <column name="second_column"/>
                                 </constraint>
-                                <index name="TEST_INDEX" indexType="btree">
+                                <index referenceId="TEST_INDEX" indexType="btree">
                                     <column name="first_column"/>
                                 </index>
                             </table>