Skip to content

Commit ef86a88

Browse files
Chhandak.BaruaChhandak.Barua
Chhandak.Barua
authored and
Chhandak.Barua
committed
ACP2E-197: JS validation error doesn't work for the 2nd line of the street attribute
1 parent a8b1a8c commit ef86a88

File tree

4 files changed

+56
-22
lines changed

4 files changed

+56
-22
lines changed

‎app/code/Magento/Customer/Test/Mftf/ActionGroup/AdminEditCustomerAddressAttributePropertiesActionGroup.xml

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
9+
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
10+
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
11+
<!-- Same as "EditCustomerAddressesFromAdminActionGroup" but taking country and state from input "customerAddress" -->
12+
<actionGroup name="AdminEditCustomerAddressAttributePropertiesActionGroup">
13+
<annotations>
14+
<description>Adds the provided properties value to a customer address attribute edit page.</description>
15+
</annotations>
16+
<arguments>
17+
<argument name="minimumTextLength" type="string" defaultValue="1"/>
18+
<argument name="maximumTextLength" type="string" defaultValue="255"/>
19+
</arguments>
20+
<!--Update customer attribute properties-->
21+
<amOnPage url="{{CustomerAttributePrefixPage.url(CustomerStreetAddressPrefixAttribute.attribute_code)}}" stepKey="goToPrefix"/>
22+
<waitForPageLoad stepKey="waitForPrefixPageOpened"/>
23+
<fillField selector="{{AdminReturnAttributePropertiesSection.minTextLength}}" userInput="{{minimumTextLength}}" stepKey="minimumTextLength"/>
24+
<fillField selector="{{AdminReturnAttributePropertiesSection.maxTextLength}}" userInput="{{maximumTextLength}}" stepKey="maximumTextLength"/>
25+
<click selector="{{CustomerAddressPrefixSection.save}}" stepKey="ClickToSave"/>
26+
<waitForPageLoad stepKey="waitForValueSaved"/>
27+
</actionGroup>
28+
</actionGroups>

‎app/code/Magento/Customer/Test/Mftf/Data/AddressData.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,8 @@
8787
<data key="lastname">Doe</data>
8888
<data key="company">Magento</data>
8989
<array key="street">
90-
<item>7700 West Parmer Lane</item>
91-
<item>Apt</item>
90+
<item>7700 West</item>
91+
<item>Parmer Lane Apt</item>
9292
</array>
9393
<data key="city">Austin</data>
9494
<data key="state">Texas</data>

‎app/code/Magento/Customer/Test/Mftf/Data/CustomerConfigData.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,4 +61,7 @@
6161
<data key="label">Global</data>
6262
<data key="value">0</data>
6363
</entity>
64+
<entity name="CustomerStreetAddressPrefixAttribute">
65+
<data key="attribute_code">28</data>
66+
</entity>
6467
</entities>

‎app/code/Magento/Customer/Test/Mftf/Test/StorefrontUpdateCustomerAddressTest/StorefrontUpdateCustomerShippingAddressFromBlockFailedTest.xml

Lines changed: 23 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -6,38 +6,41 @@
66
*/
77
-->
88
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
9-
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
9+
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
1010
<test name="StorefrontUpdateCustomerShippingAddressFromBlockFailedTest">
1111
<annotations>
12-
<features value="Customer"/>
13-
<stories value="Update Customer Address"/>
14-
<title value="Update customer shipping address via the Storefront fails if validation is not passed"/>
15-
<description value="Update customer shipping address via the Storefront fails if validation is not passed"/>
16-
<severity value="MINOR"/>
12+
<features value="Customer address"/>
13+
<stories value="JS validation error doesn't work for the 2nd line of the street attribute"/>
14+
<title value="JS validation error does not work for the 2nd line of the street attribute"/>
15+
<description value="Storefront user should be able to see error for 2nd line of the street attribute if length more than maximum text length property value."/>
16+
<severity value="AVERAGE"/>
1717
<testCaseId value="MC-43268"/>
18+
<useCaseId value="ACP2E-197"/>
1819
<group value="customer"/>
19-
<group value="update"/>
2020
</annotations>
2121
<before>
22-
<createData entity="US_Address_TX_Default_Billing_With_Long_Line_Apartment" stepKey="createCustomer"/>
22+
<createData entity="Simple_Customer_Without_Address" stepKey="createCustomer"/>
23+
<actionGroup ref="AdminLoginActionGroup" stepKey="login"/>
2324
</before>
2425
<after>
2526
<deleteData createDataKey="createCustomer" stepKey="DeleteCustomer"/>
27+
<actionGroup ref="AdminEditCustomerAddressAttributePropertiesActionGroup" stepKey="editCustomerAddressProperties">
28+
<argument name="minimumTextLength" value="1"/>
29+
<argument name="maximumTextLength" value="255"/>
30+
</actionGroup>
31+
<actionGroup ref="AdminLogoutActionGroup" stepKey="adminLogout"/>
2632
</after>
27-
33+
<actionGroup ref="AdminEditCustomerAddressAttributePropertiesActionGroup" stepKey="editCustomerAddressProperties">
34+
<argument name="minimumTextLength" value="1"/>
35+
<argument name="maximumTextLength" value="10"/>
36+
</actionGroup>
2837
<!--Log in to Storefront as Customer 1 -->
2938
<actionGroup ref="LoginToStorefrontActionGroup" stepKey="signUp">
30-
<argument name="Customer" value="$createCustomer$"/>
39+
<argument name="Customer" value="$$createCustomer$$"/>
40+
</actionGroup>
41+
<actionGroup ref="EnterCustomerAddressInfoActionGroup" stepKey="AddNewAddress">
42+
<argument name="Address" value="US_Address_TX_Default_Billing_With_Long_Line_Apartment"/>
3143
</actionGroup>
32-
<amOnPage url="{{StorefrontCustomerAddressesPage.url}}" stepKey="OpenCustomerAddNewAddress"/>
33-
<waitForElementVisible selector="{{StorefrontCustomerAddressesSection.editDefaultShippingAddress}}" stepKey="waitForChangeShippingAddressLinkVisible"/>
34-
<click selector="{{StorefrontCustomerAddressesSection.editDefaultShippingAddress}}" stepKey="ClickEditDefaultShippingAddress"/>
35-
<fillField userInput="{{US_Address_TX_Default_Billing_With_Long_Line_Apartment.street}}" selector="{{StorefrontCustomerAddressFormSection.firstName}}" stepKey="fillStreetTwoLines"/>
36-
<click selector="{{StorefrontCustomerAddressFormSection.saveAddress}}" stepKey="saveCustomerAddress"/>
37-
<waitForElementVisible stepKey="waitForErrorAppears" selector="{{StorefrontMessagesSection.error}}"/>
38-
<see selector="{{StorefrontMessagesSection.error}}" userInput='Please enter less or equal than 10 symbols.' stepKey="seeErrorMessages"/>
39-
<fillField userInput="{{US_Address_TX_Default_Billing.street}}" selector="{{StorefrontCustomerAddressFormSection.firstName}}" stepKey="fillStreetLine"/>
40-
<waitForElementVisible selector="{{StorefrontMessagesSection.success}}" stepKey="waitForSuccessMessageVisible"/>
41-
<see userInput="You saved the address." selector="{{StorefrontMessagesSection.success}}" stepKey="verifyAddressAdded"/>
44+
<see userInput='"Street Address" length must be equal or less than 10 characters.' selector='{{StorefrontMessagesSection.error}}' stepKey='verifyAddressAdded'/>
4245
</test>
4346
</tests>

0 commit comments

Comments
 (0)