Merge branch 'develop' of github.corp.magento.com:magento2/magento2ce into develop

Author: YevSent

.htaccess

@@ -243,10 +243,6 @@
         order allow,deny
         deny from all
     </Files>
-    <Files CONTRIBUTOR_LICENSE_AGREEMENT.html>
-        order allow,deny
-        deny from all
-    </Files>
     <Files COPYING.txt>
         order allow,deny
         deny from all

.htaccess.sample

@@ -209,10 +209,6 @@
         order allow,deny
         deny from all
     </Files>
-    <Files CONTRIBUTOR_LICENSE_AGREEMENT.html>
-        order allow,deny
-        deny from all
-    </Files>
     <Files COPYING.txt>
         order allow,deny
         deny from all

CONTRIBUTING.md

@@ -10,7 +10,7 @@ The Magento 2 development team will review all issues and contributions submitte
 
 ## Contribution requirements
 
-1. Contributions must adhere to [Magento coding standards](http://devdocs.magento.com/guides/v1.0/coding-standards/bk-coding-standards.html).
+1. Contributions must adhere to [Magento coding standards](http://devdocs.magento.com/guides/v2.0/coding-standards/bk-coding-standards.html).
 2. Pull requests (PRs) must be accompanied by a meaningful description of their purpose. Comprehensive descriptions increase the chances of a pull request to be merged quickly and without additional clarification requests.
 3. Commits must be accompanied by meaningful commit messages.
 4. PRs which include bug fixing, must be accompanied with step-by-step description of how to reproduce the bug.
@@ -25,7 +25,7 @@ The Magento 2 development team will review all issues and contributions submitte
 If you are a new GitHub user, we recommend that you create your own [free github account](https://github.com/signup/free). By doing that, you will be able to collaborate with the Magento 2 development team, “fork” the Magento 2 project and be able to easily send “pull requests”.
 
 1. Search current [listed issues](https://github.com/magento/magento2/issues) (open or closed) for similar proposals of intended contribution before starting work on a new contribution.
-2. Review the [Contributor License Agreement](https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html) if this is your first time contributing.
+2. Review the [Contributor License Agreement](https://magento.com/legaldocuments/mca) if this is your first time contributing.
 3. Create and test your work.
-4. Fork the Magento 2 repository according to [Fork a repository instructions](http://devdocs.magento.com/guides/v1.0/contributor-guide/CONTRIBUTING.html#fork) and when you are ready to send us a pull request – follow [Create a pull request instructions](http://devdocs.magento.com/guides/v1.0/contributor-guide/CONTRIBUTING.html#pull_request).
+4. Fork the Magento 2 repository according to [Fork a repository instructions](http://devdocs.magento.com/guides/v2.0/contributor-guide/contributing.html#fork) and when you are ready to send us a pull request – follow [Create a pull request instructions](http://devdocs.magento.com/guides/v2.0/contributor-guide/contributing.html#pull_request).
 5. Once your contribution is received, Magento 2 development team will review the contribution and collaborate with you as needed to improve the quality of the contribution.

CONTRIBUTOR_LICENSE_AGREEMENT.html

@@ -30,7 +30,7 @@ public function render(\Magento\Framework\DataObject $row)
             $truncateLength = $this->getColumn()->getTruncate();
         }
         $text = $this->filterManager->truncate(parent::_getValue($row), ['length' => $truncateLength]);
-        if ($this->getColumn()->getEscape()) {
+        if (!$this->getColumn()->hasEscape() || $this->getColumn()->getEscape()) {
             $text = $this->escapeHtml($text);
         }
         if ($this->getColumn()->getNl2br()) {

app/code/Magento/Backend/Block/Widget/Grid/Column/Renderer/Longtext.php

@@ -98,29 +98,18 @@ public function execute()
             return $resultRedirect->setPath('catalog/*/', ['_current' => true, 'id' => null]);
         }
 
-        $refreshTree = false;
         $data['general'] = $this->getRequest()->getPostValue();
+        $isNewCategory = !isset($data['general']['entity_id']);
         $data = $this->stringToBoolConverting($this->stringToBoolInputs, $data);
         $data = $this->imagePreprocessing($data);
         $storeId = isset($data['general']['store_id']) ? $data['general']['store_id'] : null;
-        if ($data) {
+        $parentId = isset($data['general']['parent']) ? $data['general']['parent'] : null;
+        if ($data['general']) {
             $category->addData($this->_filterCategoryPostData($data['general']));
-            if (!$category->getId()) {
-                $parentId = isset($data['general']['parent']) ? $data['general']['parent'] : null;
-                if (!$parentId) {
-                    if ($storeId) {
-                        $parentId = $this->_objectManager->get(
-                            'Magento\Store\Model\StoreManagerInterface'
-                        )->getStore(
-                            $storeId
-                        )->getRootCategoryId();
-                    } else {
-                        $parentId = \Magento\Catalog\Model\Category::TREE_ROOT_ID;
-                    }
-                }
-                $parentCategory = $this->_objectManager->create('Magento\Catalog\Model\Category')->load($parentId);
+            if ($isNewCategory) {
+                $parentCategory = $this->getParentCategory($parentId, $storeId);
                 $category->setPath($parentCategory->getPath());
-                $category->setParentId($parentId);
+                $category->setParentId($parentCategory->getId());
             }
 
             /**
@@ -193,15 +182,21 @@ public function execute()
 
                 $category->save();
                 $this->messageManager->addSuccess(__('You saved the category.'));
-                $refreshTree = true;
+            } catch (\Magento\Framework\Exception\AlreadyExistsException $e) {
+                $this->messageManager->addError($e->getMessage());
+                $this->_objectManager->get(\Psr\Log\LoggerInterface::class)->critical($e);
+                $this->_getSession()->setCategoryData($data);
             } catch (\Exception $e) {
                 $this->messageManager->addError(__('Something went wrong while saving the category.'));
                 $this->_objectManager->get(\Psr\Log\LoggerInterface::class)->critical($e);
                 $this->_getSession()->setCategoryData($data);
-                $refreshTree = false;
             }
         }
 
+        $hasError = (bool)$this->messageManager->getMessages()->getCountByType(
+            \Magento\Framework\Message\MessageInterface::TYPE_ERROR
+        );
+
         if ($this->getRequest()->getPost('return_session_messages_only')) {
             $category->load($category->getId());
             // to obtain truncated category name
@@ -214,23 +209,17 @@ public function execute()
             return $resultJson->setData(
                 [
                     'messages' => $block->getGroupedHtml(),
-                    'error' => !$refreshTree,
+                    'error' => $hasError,
                     'category' => $category->toArray(),
                 ]
             );
         }
 
-        $redirectParams = [
-            '_current' => true,
-            'id' => $category->getId()
-        ];
-        if ($storeId) {
-            $redirectParams['store'] = $storeId;
-        }
+        $redirectParams = $this->getRedirectParams($isNewCategory, $hasError, $category->getId(), $parentId, $storeId);
 
         return $resultRedirect->setPath(
-            'catalog/*/edit',
-            $redirectParams
+            $redirectParams['path'],
+            $redirectParams['params']
         );
     }
 
@@ -283,4 +272,56 @@ public function stringToBoolConverting($stringToBoolInputs, $data)
         }
         return $data;
     }
+
+    /**
+     * Get parent category
+     *
+     * @param int $parentId
+     * @param int $storeId
+     *
+     * @return \Magento\Catalog\Model\Category
+     */
+    protected function getParentCategory($parentId, $storeId)
+    {
+        if (!$parentId) {
+            if ($storeId) {
+                $parentId = $this->_objectManager->get(
+                    \Magento\Store\Model\StoreManagerInterface::class
+                )->getStore(
+                    $storeId
+                )->getRootCategoryId();
+            } else {
+                $parentId = \Magento\Catalog\Model\Category::TREE_ROOT_ID;
+            }
+        }
+        return $this->_objectManager->create(\Magento\Catalog\Model\Category::class)->load($parentId);
+    }
+
+    /**
+     * Get category redirect path
+     *
+     * @param bool $isNewCategory
+     * @param bool $hasError
+     * @param int $categoryId
+     * @param int $parentId
+     * @param int $storeId
+     *
+     * @return array
+     */
+    protected function getRedirectParams($isNewCategory, $hasError, $categoryId, $parentId, $storeId)
+    {
+        $params = ['_current' => true];
+        if ($storeId) {
+            $params['store'] = $storeId;
+        }
+        if ($isNewCategory && $hasError) {
+            $path = 'catalog/*/add';
+            $params['parent'] = $parentId;
+        } else {
+            $path = 'catalog/*/edit';
+            $params['id'] = $categoryId;
+
+        }
+        return ['path' => $path, 'params' => $params];
+    }
 }

app/code/Magento/Catalog/Controller/Adminhtml/Category/Save.php

@@ -442,6 +442,7 @@ public function move($parentId, $afterCategoryId)
         if (!$productIndexer->isScheduled()) {
             $productIndexer->reindexList(array_merge($this->getPathIds(), $oldParentIds));
         }
+        $this->_eventManager->dispatch('clean_cache_by_tags', ['object' => $this]);
         $this->_cacheManager->clean([self::CACHE_TAG]);
 
         return $this;