Skip to content

Commit f5a7c10

Browse files
author
Oleksii Korshenko
committed
MAGETWO-64399: [GitHub] [PR] Added missing _() wrap on execption. Fix for issues/8287 #8474
1 parent c4e2ec4 commit f5a7c10

File tree

3 files changed

+13
-3
lines changed

3 files changed

+13
-3
lines changed

app/code/Magento/Quote/Model/Quote/Validator/MinimumOrderAmount/ValidationMessage.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,9 @@ public function __construct(
3838
}
3939

4040
/**
41-
* @return \Magento\Framework\Phrase|mixed
41+
* Get validation message.
42+
*
43+
* @return \Magento\Framework\Phrase
4244
* @throws \Zend_Currency_Exception
4345
*/
4446
public function getMessage()
@@ -56,6 +58,9 @@ public function getMessage()
5658
)
5759
);
5860
$message = __('Minimum order amount is %1', $minimumAmount);
61+
} else {
62+
//Added in order to address the issue: https://github.com/magento/magento2/issues/8287
63+
$message = __($message);
5964
}
6065

6166
return $message;

app/code/Magento/Quote/Model/ShippingAddressManagement.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ public function assign($cartId, \Magento\Quote\Api\Data\AddressInterface $addres
118118
$address->setCollectShippingRates(true);
119119

120120
if (!$quote->validateMinimumAmount($quote->getIsMultiShipping())) {
121-
throw new InputException(__($this->getMinimumAmountErrorMessage()->getMessage()));
121+
throw new InputException($this->getMinimumAmountErrorMessage()->getMessage());
122122
}
123123

124124
try {

app/code/Magento/Quote/Test/Unit/Model/Quote/Validator/MinimumOrderAmount/ValidationMessageTest.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
*/
66
namespace Magento\Quote\Test\Unit\Model\Quote\Validator\MinimumOrderAmount;
77

8+
use Magento\Framework\Phrase;
9+
810
class ValidationMessageTest extends \PHPUnit_Framework_TestCase
911
{
1012
/**
@@ -86,6 +88,9 @@ public function testGetConfigMessage()
8688
->with('sales/minimum_order/description', \Magento\Store\Model\ScopeInterface::SCOPE_STORE)
8789
->willReturn($configMessage);
8890

89-
$this->assertEquals($configMessage, $this->model->getMessage());
91+
$message = $this->model->getMessage();
92+
93+
$this->assertEquals(Phrase::class , get_class($message));
94+
$this->assertEquals($configMessage, $message->__toString());
9095
}
9196
}

0 commit comments

Comments
 (0)