AC-12092:: Remove Deprecations- PhpUnit10 Unit Tests

Author: Shradddha

app/code/Magento/AdminNotification/Test/Unit/Model/System/Message/CacheOutdatedTest.php

@@ -57,62 +57,64 @@ protected function setUp(): void
 
     /**
      * @param string $expectedSum
-     * @param array $types
+     * @param array $cacheTypes
      * @dataProvider getIdentityDataProvider
      */
-    public function testGetIdentity($expectedSum, $types)
+    public function testGetIdentity($expectedSum, $cacheTypes)
     {
-        $cacheTypes = [];
-        foreach ($types as $type)
-        {
-            $cacheTypeMock = $this->getMockBuilder(\stdClass::class)->addMethods(['getCacheType'])
-                ->disableOriginalConstructor()
-                ->getMock();
-            $cacheTypeMock->method('getCacheType')->willReturn($type);
-            $cacheTypes[] = $cacheTypeMock;
+        $cacheType1 = [];
+        foreach($cacheTypes as $cacheType){
+            $cacheType1[] = $cacheType($this);
         }
 
         $this->_cacheTypeListMock->method(
             'getInvalidated'
         )->willReturn(
-            $cacheTypes
+            $cacheType1
         );
         $this->assertEquals($expectedSum, $this->_messageModel->getIdentity());
     }
 
+    protected function getMockForStdClass($mockReturn)
+    {
+        $cacheTypeMock = $this->getMockBuilder(\stdClass::class)->addMethods(['getCacheType'])
+            ->disableOriginalConstructor()
+            ->getMock();
+        $cacheTypeMock->method('getCacheType')->willReturn($mockReturn);
+        return $cacheTypeMock;
+    }
+
     /**
      * @return array
      */
     public static function getIdentityDataProvider()
     {
+        $cacheTypeMock1 = static fn (self $testCase) => $testCase->getMockForStdClass('Simple');
+        $cacheTypeMock2 = static fn (self $testCase) => $testCase->getMockForStdClass('Advanced');
+
         return [
-            ['c13cfaddc2c53e8d32f59bfe89719beb', ['Simple']],
-            ['69aacdf14d1d5fcef7168b9ac308215e', ['Simple', 'Advanced']]
+            ['c13cfaddc2c53e8d32f59bfe89719beb', [$cacheTypeMock1]],
+            ['69aacdf14d1d5fcef7168b9ac308215e', [$cacheTypeMock1, $cacheTypeMock2]]
         ];
     }
 
     /**
      * @param bool $expected
      * @param bool $allowed
-     * @param array $types
+     * @param array $cacheTypes
      * @dataProvider isDisplayedDataProvider
      */
-    public function testIsDisplayed($expected, $allowed, $types)
+    public function testIsDisplayed($expected, $allowed, $cacheTypes)
     {
-        $cacheTypes = [];
-        foreach ($types as $type)
-        {
-            $cacheTypeMock = $this->getMockBuilder(\stdClass::class)->addMethods(['getCacheType'])
-                ->disableOriginalConstructor()
-                ->getMock();
-            $cacheTypeMock->method('getCacheType')->willReturn($type);
-            $cacheTypes[] = $cacheTypeMock;
+        $cacheType1 = [];
+        foreach($cacheTypes as $cacheType){
+            $cacheType1[] = $cacheType($this);
         }
         $this->_authorizationMock->expects($this->once())->method('isAllowed')->willReturn($allowed);
         $this->_cacheTypeListMock->method(
             'getInvalidated'
         )->willReturn(
-            $cacheTypes
+            $cacheType1
         );
         $this->assertEquals($expected, $this->_messageModel->isDisplayed());
     }
@@ -122,7 +124,8 @@ public function testIsDisplayed($expected, $allowed, $types)
      */
     public static function isDisplayedDataProvider()
     {
-        $cacheTypes = ['someVal', 'someVal'];
+        $cacheTypesMock = static fn (self $testCase) => $testCase->getMockForStdClass('someVal');
+        $cacheTypes = [$cacheTypesMock, $cacheTypesMock];
         return [
             [false, false, []],
             [false, false, $cacheTypes],

app/code/Magento/CustomerImportExport/Test/Unit/Model/Import/CustomerCompositeTest.php

@@ -21,7 +21,9 @@
 use Magento\Framework\Filesystem\Directory\Write;
 use Magento\Framework\Filesystem\Driver\File;
 use Magento\Framework\Filesystem\File\Read;
+use Magento\Framework\Serialize\Serializer\Json;
 use Magento\Framework\Stdlib\StringUtils;
+use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
 use Magento\Framework\Translate\InlineInterface;
 use Magento\ImportExport\Model\Import;
 use Magento\ImportExport\Model\Import\AbstractSource;
@@ -177,6 +179,15 @@ protected function setUp(): void
      */
     protected function _createModelMock($data)
     {
+        $objectManager = new ObjectManager($this);
+        $objects = [
+            [
+                Json::class,
+                $this->createMock(Json::class)
+            ]
+        ];
+        $objectManager->prepareObjectManager($objects);
+
         return new CustomerComposite(
             $this->_string,
             $this->_scopeConfigMock,

app/code/Magento/Multishipping/Test/Unit/Model/Checkout/Type/MultishippingTest.php

@@ -1191,7 +1191,7 @@ private function getCurrencyMock($shippingPrice): MockObject
      *
      * @return array
      */
-    public function getConfigCreateOrders(): array
+    public static function getConfigCreateOrders(): array
     {
         return [
             [

app/code/Magento/Multishipping/Test/Unit/Model/DisableMultishippingTest.php

@@ -84,7 +84,7 @@ public function testExecuteWithMultishippingModeEnabled(bool $hasShippingAssignm
      *
      * @return array
      */
-    public function executeWithMultishippingModeEnabledDataProvider(): array
+    public static function executeWithMultishippingModeEnabledDataProvider(): array
     {
         return [
             'check_with_shipping_assignments' => [true],

app/code/Magento/Multishipping/Test/Unit/Model/Payment/Method/Specification/EnabledTest.php

@@ -75,7 +75,7 @@ public function testIsSatisfiedBy($methodsInfo, $result)
      *
      * @return array
      */
-    public function methodsDataProvider()
+    public static function methodsDataProvider()
     {
         return [
             [['allow_multiple_address' => 1], true],

app/code/Magento/Multishipping/Test/Unit/Plugin/DisableMultishippingModeTest.php

@@ -92,7 +92,7 @@ public function testPluginWithChangedMultishippingMode(bool $totalsCollectedBefo
      *
      * @return array
      */
-    public function pluginWithChangedMultishippingModeDataProvider(): array
+    public static function pluginWithChangedMultishippingModeDataProvider(): array
     {
         return [
             'check_when_totals_are_collected' => [true],

app/code/Magento/Paypal/Test/Unit/Model/InfoTest.php

@@ -156,7 +156,7 @@ private function _prepareLabelValuesExpectation($expectation)
      *
      * @return array
      */
-    public function additionalInfoDataProvider()
+    public static function additionalInfoDataProvider()
     {
         return include __DIR__ . '/_files/additional_info_data.php';
     }

app/code/Magento/Translation/Test/Unit/Model/Json/PreProcessorTest.php

@@ -144,25 +144,25 @@ public function testProcess(array $data, array $expects)
      *
      * @return array
      */
-    public function processDataProvider()
+    public static function processDataProvider()
     {
         return [
             [
                 [
                     'area_code' => FrontNameResolver::AREA_CODE
                 ],
                 [
-                    'areaList_getArea' => $this->never(),
-                    'area_load' => $this->never(),
+                    'areaList_getArea' => self::never(),
+                    'area_load' => self::never(),
                 ]
             ],
             [
                 [
                     'area_code' => 'frontend'
                 ],
                 [
-                    'areaList_getArea' => $this->once(),
-                    'area_load' => $this->once(),
+                    'areaList_getArea' => self::once(),
+                    'area_load' => self::once(),
                 ]
             ],
         ];

app/code/Magento/Vault/Test/Unit/Model/Method/VaultTest.php

@@ -93,7 +93,7 @@ public function testAuthorizeNoTokenMetadata(array $additionalInfo)
      * Get list of additional information variations
      * @return array
      */
-    public function additionalInfoDataProvider()
+    public static function additionalInfoDataProvider()
     {
         return [
             ['additionalInfo' => []],
@@ -380,7 +380,7 @@ public function testCanUseInternal($configValue, $paymentValue, $expected)
      * Get list of variations for testing canUseInternal method
      * @return array
      */
-    public function internalUsageDataProvider()
+    public static function internalUsageDataProvider()
     {
         return [
             ['configValue' => true, 'paymentValue' => true, 'expected' => true],

lib/internal/Magento/Framework/HTTP/Test/Unit/HeaderTest.php

@@ -73,7 +73,7 @@ public function testHttpMethods($method, $clean, $expectedValue)
     /**
      * @return array
      */
-    public function methodsDataProvider()
+    public static function methodsDataProvider()
     {
         return [
             'getHttpHost clean true' => [
@@ -154,7 +154,7 @@ public function testGetRequestUri($clean, $expectedValue)
     /**
      * @return array
      */
-    public function getRequestUriDataProvider()
+    public static function getRequestUriDataProvider()
     {
         return [
             'getRequestUri clean true' => ['clean' => true, 'expectedValue' => 'converted value'],