Rename summary_count to total_quanity

pmclain · pmclain · commit f6f0aef0be6f · 2019-08-21T21:11:15.000-04:00
diff --git a/app/code/Magento/QuoteGraphQl/Model/Resolver/CartTotalQuantity.php b/app/code/Magento/QuoteGraphQl/Model/Resolver/CartTotalQuantity.php
@@ -16,7 +16,7 @@
 /**
  * @inheritdoc
  */
-class CartSummaryCount implements ResolverInterface
+class CartTotalQuantity implements ResolverInterface
 {
     /**
      * @inheritdoc
diff --git a/app/code/Magento/QuoteGraphQl/etc/schema.graphqls b/app/code/Magento/QuoteGraphQl/etc/schema.graphqls
@@ -197,7 +197,7 @@ type Cart {
     available_payment_methods: [AvailablePaymentMethod] @resolver(class: "Magento\\QuoteGraphQl\\Model\\Resolver\\AvailablePaymentMethods") @doc(description: "Available payment methods")
     selected_payment_method: SelectedPaymentMethod @resolver(class: "\\Magento\\QuoteGraphQl\\Model\\Resolver\\SelectedPaymentMethod")
     prices: CartPrices @resolver(class: "\\Magento\\QuoteGraphQl\\Model\\Resolver\\CartPrices")
-    summary_count: Int! @resolver(class: "\\Magento\\QuoteGraphQl\\Model\\Resolver\\CartSummaryCount")
+    total_quantity: Int! @resolver(class: "\\Magento\\QuoteGraphQl\\Model\\Resolver\\CartTotalQuantity")
 }
 
 interface CartAddressInterface @typeResolver(class: "\\Magento\\QuoteGraphQl\\Model\\Resolver\\CartAddressTypeResolver") {
diff --git a/dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/GetCartTotalQuantityTest.php b/dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/GetCartTotalQuantityTest.php
@@ -11,9 +11,9 @@
 use Magento\TestFramework\TestCase\GraphQlAbstract;
 
 /**
- * Test for getting summary count from cart query
+ * Test for getting total quantity from cart query
  */
-class GetCartSummaryCountTest extends GraphQlAbstract
+class GetCartTotalQuantityTest extends GraphQlAbstract
 {
     /**
      * @var GetMaskedQuoteIdByReservedOrderId
@@ -31,7 +31,7 @@ protected function setUp()
      * @magentoApiDataFixture Magento/GraphQl/Quote/_files/guest/create_empty_cart.php
      * @magentoApiDataFixture Magento/GraphQl/Quote/_files/add_simple_product.php
      */
-    public function testSetNewBillingAddress()
+    public function testGetTotalQuantity()
     {
         $maskedQuoteId = $this->getMaskedQuoteIdByReservedOrderId->execute('test_quote');
 
@@ -41,8 +41,8 @@ public function testSetNewBillingAddress()
 
         self::assertArrayHasKey('cart', $response);
         $cart = $response['cart'];
-        self::assertArrayHasKey('summary_count', $cart);
-        self::assertEquals(2, $cart['summary_count']);
+        self::assertArrayHasKey('total_quantity', $cart);
+        self::assertEquals(2, $cart['total_quantity']);
     }
 
     /**
@@ -56,7 +56,7 @@ private function getQuery(string $maskedQuoteId): string
         return <<<QUERY
 {
   cart(cart_id: "{$maskedQuoteId}") {
-    summary_count
+    total_quantity
   }
 }
 QUERY;

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@`
`16`	`16`	`/**`
`17`	`17`	`* @inheritdoc`
`18`	`18`	`*/`
`19`		`-class CartSummaryCount implements ResolverInterface`
	`19`	`+class CartTotalQuantity implements ResolverInterface`
`20`	`20`	`{`
`21`	`21`	`/**`
`22`	`22`	`* @inheritdoc`
Original file line number	Diff line number	Diff line change
`@@ -197,7 +197,7 @@ type Cart {`
`197`	`197`	`available_payment_methods: [AvailablePaymentMethod] @resolver(class: "Magento\\QuoteGraphQl\\Model\\Resolver\\AvailablePaymentMethods") @doc(description: "Available payment methods")`
`198`	`198`	`selected_payment_method: SelectedPaymentMethod @resolver(class: "\\Magento\\QuoteGraphQl\\Model\\Resolver\\SelectedPaymentMethod")`
`199`	`199`	`prices: CartPrices @resolver(class: "\\Magento\\QuoteGraphQl\\Model\\Resolver\\CartPrices")`
`200`		`- summary_count: Int! @resolver(class: "\\Magento\\QuoteGraphQl\\Model\\Resolver\\CartSummaryCount")`
	`200`	`+ total_quantity: Int! @resolver(class: "\\Magento\\QuoteGraphQl\\Model\\Resolver\\CartTotalQuantity")`
`201`	`201`	`}`
`202`	`202`
`203`	`203`	`interface CartAddressInterface @typeResolver(class: "\\Magento\\QuoteGraphQl\\Model\\Resolver\\CartAddressTypeResolver") {`
Original file line number	Diff line number	Diff line change
`@@ -11,9 +11,9 @@`
`11`	`11`	`use Magento\TestFramework\TestCase\GraphQlAbstract;`
`12`	`12`
`13`	`13`	`/**`
`14`		`- * Test for getting summary count from cart query`
	`14`	`+ * Test for getting total quantity from cart query`
`15`	`15`	`*/`
`16`		`-class GetCartSummaryCountTest extends GraphQlAbstract`
	`16`	`+class GetCartTotalQuantityTest extends GraphQlAbstract`
`17`	`17`	`{`
`18`	`18`	`/**`
`19`	`19`	`* @var GetMaskedQuoteIdByReservedOrderId`
`@@ -31,7 +31,7 @@ protected function setUp()`
`31`	`31`	`* @magentoApiDataFixture Magento/GraphQl/Quote/_files/guest/create_empty_cart.php`
`32`	`32`	`* @magentoApiDataFixture Magento/GraphQl/Quote/_files/add_simple_product.php`
`33`	`33`	`*/`
`34`		`- public function testSetNewBillingAddress()`
	`34`	`+ public function testGetTotalQuantity()`
`35`	`35`	`{`
`36`	`36`	`$maskedQuoteId = $this->getMaskedQuoteIdByReservedOrderId->execute('test_quote');`
`37`	`37`
`@@ -41,8 +41,8 @@ public function testSetNewBillingAddress()`
`41`	`41`
`42`	`42`	`self::assertArrayHasKey('cart', $response);`
`43`	`43`	`$cart = $response['cart'];`
`44`		`- self::assertArrayHasKey('summary_count', $cart);`
`45`		`- self::assertEquals(2, $cart['summary_count']);`
	`44`	`+ self::assertArrayHasKey('total_quantity', $cart);`
	`45`	`+ self::assertEquals(2, $cart['total_quantity']);`
`46`	`46`	`}`
`47`	`47`
`48`	`48`	`/**`
`@@ -56,7 +56,7 @@ private function getQuery(string $maskedQuoteId): string`
`56`	`56`	`return <<<QUERY`
`57`	`57`	`{`
`58`	`58`	`cart(cart_id: "{$maskedQuoteId}") {`
`59`		`- summary_count`
	`59`	`+ total_quantity`
`60`	`60`	`}`
`61`	`61`	`}`
`62`	`62`	`QUERY;`