Skip to content

Commit f785f92

Browse files
committed
B2B-1648: Implement Solution for Unblocking S3 MFTF Import Tests
- Addressing CR feedback
1 parent 97daa9f commit f785f92

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

app/code/Magento/Catalog/Test/Mftf/Helper/LocalFileAssertions.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ public function copy($source, $destination): void
112112
*/
113113
public function createDirectory($path, $permissions = 0777): void
114114
{
115-
$permissions = $this->convertToOctal($permissions);
115+
$permissions = $this->convertOctalStringToDecimalInt($permissions);
116116
$sourceRealPath = $this->expandPath($path);
117117
$oldUmask = umask(0);
118118
$this->driver->createDirectory($sourceRealPath, $permissions);
@@ -227,13 +227,13 @@ public function assertDirectoryEmpty($path, $message = ""): void
227227
}
228228

229229
/**
230-
* Helper function to convert a string to an octal
230+
* Helper function to convert an octal string to its decimal equivalent
231231
*
232232
* @param string $string
233233
* @return int
234234
*
235235
*/
236-
private function convertToOctal($string): int
236+
private function convertOctalStringToDecimalInt($string): int
237237
{
238238
if (is_string($string)) {
239239
$string = octdec($string);

0 commit comments

Comments
 (0)