Skip to content

Commit f7aa872

Browse files
committed
Improve accesibility on the sections
1 parent 0611e75 commit f7aa872

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

app/code/Magento/Theme/view/frontend/templates/html/sections.phtml

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,15 @@
77
/**
88
* General template for displaying group of blocks divided into sections
99
*/
10+
/** @var \Magento\Framework\Escaper $escaper */
1011

1112
$group = $block->getGroupName();
1213
$groupCss = $block->getGroupCss();
1314
?>
1415
<?php if ($detailedInfoGroup = $block->getGroupChildNames($group)):?>
15-
<div class="sections <?= $block->escapeHtmlAttr($groupCss) ?>">
16+
<div class="sections <?= $escaper->escapeHtmlAttr($groupCss) ?>">
1617
<?php $layout = $block->getLayout(); ?>
17-
<div class="section-items <?= $block->escapeHtmlAttr($groupCss) ?>-items"
18+
<div class="section-items <?= $escaper->escapeHtmlAttr($groupCss) ?>-items"
1819
data-mage-init='{"tabs":{"openedState":"active"}}'>
1920
<?php foreach ($detailedInfoGroup as $name):?>
2021
<?php
@@ -25,19 +26,19 @@ $groupCss = $block->getGroupCss();
2526
$alias = $layout->getElementAlias($name);
2627
$label = $block->getChildData($alias, 'title');
2728
?>
28-
<div class="section-item-title <?= $block->escapeHtmlAttr($groupCss) ?>-item-title"
29+
<div class="section-item-title <?= $escaper->escapeHtmlAttr($groupCss) ?>-item-title"
2930
data-role="collapsible">
30-
<a class="<?= $block->escapeHtmlAttr($groupCss) ?>-item-switch"
31-
data-toggle="switch" href="#<?= $block->escapeHtmlAttr($alias) ?>">
31+
<a class="<?= $escaper->escapeHtmlAttr($groupCss) ?>-item-switch"
32+
data-toggle="switch" href="#<?= $escaper->escapeHtmlAttr($alias) ?>">
3233
<?= /* @noEscape */ $label ?>
3334
</a>
3435
</div>
35-
<div class="section-item-content <?= $block->escapeHtmlAttr($groupCss) ?>-item-content"
36-
id="<?= $block->escapeHtmlAttr($alias) ?>"
37-
data-role="content">
36+
<div class="section-item-content <?= $escaper->escapeHtmlAttr($groupCss) ?>-item-content"
37+
id="<?= $escaper->escapeHtmlAttr($alias) ?>"
38+
role="tab">
3839
<?= /* @noEscape */ $html ?>
3940
</div>
4041
<?php endforeach;?>
4142
</div>
4243
</div>
43-
<?php endif; ?>
44+
<?php endif; ?>

0 commit comments

Comments
 (0)