MAGETWO-63910: Create infrastructure for mapper in Payment module

 - Added payment method code validation to Braintree mappers
 - Updated default payment verification mapper and factory for creating mappers

Author: YevSent

app/code/Magento/Braintree/Model/AvsEmsCodeMapper.php

@@ -5,6 +5,7 @@
  */
 namespace Magento\Braintree\Model;
 
+use Magento\Braintree\Model\Ui\ConfigProvider;
 use Magento\Braintree\Gateway\Response\PaymentDetailsHandler;
 use Magento\Payment\Api\PaymentVerificationInterface;
 use Magento\Sales\Api\Data\OrderPaymentInterface;
@@ -43,18 +44,25 @@ class AvsEmsCodeMapper implements PaymentVerificationInterface
     /**
      * Gets payment AVS verification code.
      * Returns null if payment does not contain any AVS details.
+     * Throws an exception if specified order payment has different payment method code.
      *
      * @param OrderPaymentInterface $orderPayment
      * @return string
+     * @throws \Exception
      */
     public function getCode(OrderPaymentInterface $orderPayment)
     {
+        if ($orderPayment->getMethod() !== ConfigProvider::CODE) {
+            throw new \Exception('"' . $orderPayment->getMethod() . '" does not supported by Braintree AVS mapper.');
+        }
+
         $additionalInfo = $orderPayment->getAdditionalInformation();
         if (empty($additionalInfo[PaymentDetailsHandler::AVS_POSTAL_RESPONSE_CODE]) ||
             empty($additionalInfo[PaymentDetailsHandler::AVS_STREET_ADDRESS_RESPONSE_CODE])
         ) {
             return self::$unavailableCode;
         }
+
         $streetCode = $additionalInfo[PaymentDetailsHandler::AVS_STREET_ADDRESS_RESPONSE_CODE];
         $zipCode = $additionalInfo[PaymentDetailsHandler::AVS_POSTAL_RESPONSE_CODE];
         $key = $zipCode . $streetCode;

app/code/Magento/Braintree/Model/CvvEmsCodeMapper.php

@@ -6,6 +6,7 @@
 namespace Magento\Braintree\Model;
 
 use Magento\Braintree\Gateway\Response\PaymentDetailsHandler;
+use Magento\Braintree\Model\Ui\ConfigProvider;
 use Magento\Payment\Api\PaymentVerificationInterface;
 use Magento\Sales\Api\Data\OrderPaymentInterface;
 
@@ -42,12 +43,18 @@ class CvvEmsCodeMapper implements PaymentVerificationInterface
     /**
      * Gets payment CVV verification code.
      * Returns null if payment does not contain any CVV details.
+     * Throws an exception if specified order payment has different payment method code.
      *
      * @param OrderPaymentInterface $orderPayment
      * @return string
+     * @throws \Exception
      */
     public function getCode(OrderPaymentInterface $orderPayment)
     {
+        if ($orderPayment->getMethod() !== ConfigProvider::CODE) {
+            throw new \Exception('"' . $orderPayment->getMethod() . '" does not supported by Braintree CVV mapper.');
+        }
+
         $additionalInfo = $orderPayment->getAdditionalInformation();
         if (empty($additionalInfo[PaymentDetailsHandler::CVV_RESPONSE_CODE])) {
             return self::$notProvidedCode;

app/code/Magento/Braintree/Test/Unit/Model/AvsEmsCodeMapperTest.php

@@ -6,6 +6,7 @@
 namespace Magento\Braintree\Test\Unit\Model;
 
 use Magento\Braintree\Model\AvsEmsCodeMapper;
+use Magento\Braintree\Model\Ui\ConfigProvider;
 use Magento\Sales\Api\Data\OrderPaymentInterface;
 use PHPUnit_Framework_MockObject_MockObject as MockObject;
 
@@ -40,6 +41,10 @@ public function testGetCode($avsZip, $avsStreet, $expected)
             ->disableOriginalConstructor()
             ->getMock();
 
+        $orderPayment->expects(self::once())
+            ->method('getMethod')
+            ->willReturn(ConfigProvider::CODE);
+
         $orderPayment->expects(self::once())
             ->method('getAdditionalInformation')
             ->willReturn([
@@ -50,6 +55,27 @@ public function testGetCode($avsZip, $avsStreet, $expected)
         self::assertEquals($expected, $this->mapper->getCode($orderPayment));
     }
 
+    /**
+     * Checks a test case, when payment order is not Braintree payment method.
+     *
+     * @covers \Magento\Braintree\Model\AvsEmsCodeMapper::getCode
+     * @expectedException \Exception
+     * @expectedExceptionMessage "some_payment" does not supported by Braintree AVS mapper.
+     */
+    public function testGetCodeWithException()
+    {
+        /** @var OrderPaymentInterface|MockObject $orderPayment */
+        $orderPayment = $this->getMockBuilder(OrderPaymentInterface::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $orderPayment->expects(self::exactly(2))
+            ->method('getMethod')
+            ->willReturn('some_payment');
+
+        $this->mapper->getCode($orderPayment);
+    }
+
     /**
      * Gets list of AVS codes.
      *

app/code/Magento/Braintree/Test/Unit/Model/CvvEmsCodeMapperTest.php

@@ -6,6 +6,7 @@
 namespace Magento\Braintree\Test\Unit\Model;
 
 use Magento\Braintree\Model\CvvEmsCodeMapper;
+use Magento\Braintree\Model\Ui\ConfigProvider;
 use Magento\Sales\Api\Data\OrderPaymentInterface;
 use PHPUnit_Framework_MockObject_MockObject as MockObject;
 
@@ -39,13 +40,38 @@ public function testGetCode($cvvCode, $expected)
             ->disableOriginalConstructor()
             ->getMock();
 
+        $orderPayment->expects(self::once())
+            ->method('getMethod')
+            ->willReturn(ConfigProvider::CODE);
+
         $orderPayment->expects(self::once())
             ->method('getAdditionalInformation')
             ->willReturn(['cvvResponseCode' => $cvvCode]);
 
         self::assertEquals($expected, $this->mapper->getCode($orderPayment));
     }
 
+    /**
+     * Checks a test case, when payment order is not Braintree payment method.
+     *
+     * @covers \Magento\Braintree\Model\CvvEmsCodeMapper::getCode
+     * @expectedException \Exception
+     * @expectedExceptionMessage "some_payment" does not supported by Braintree CVV mapper.
+     */
+    public function testGetCodeWithException()
+    {
+        /** @var OrderPaymentInterface|MockObject $orderPayment */
+        $orderPayment = $this->getMockBuilder(OrderPaymentInterface::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $orderPayment->expects(self::exactly(2))
+            ->method('getMethod')
+            ->willReturn('some_payment');
+
+        $this->mapper->getCode($orderPayment);
+    }
+
     /**
      * Gets variations of cvv codes and expected mapping result.
      *