Skip to content

Commit f82299b

Browse files
committed
Move element id to component parameters, fix JS coding style
1 parent 96793fe commit f82299b

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

app/code/Magento/Checkout/view/frontend/templates/cart/form.phtml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@
1414
method="post"
1515
id="form-validate"
1616
data-mage-init='{"Magento_Checkout/js/action/update-shopping-cart":
17-
{"validationURL" : "/checkout/cart/updateItemQty"}
17+
{"validationURL" : "/checkout/cart/updateItemQty",
18+
"updateCartActionContainer": "#update_cart_action_container"}
1819
}'
1920
class="form form-cart">
2021
<?= $block->getBlockHtml('formkey') ?>

app/code/Magento/Checkout/view/frontend/web/js/action/update-shopping-cart.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@ define([
1414
$.widget('mage.updateShoppingCart', {
1515
options: {
1616
validationURL: '',
17-
eventName: 'updateCartItemQty'
17+
eventName: 'updateCartItemQty',
18+
updateCartActionContainer: ''
1819
},
1920

2021
/** @inheritdoc */
@@ -31,11 +32,12 @@ define([
3132
* @return {Boolean}
3233
*/
3334
onSubmit: function (event) {
35+
var action = this.element.find(this.options.updateCartActionContainer).val();
36+
3437
if (!this.options.validationURL) {
3538
return true;
3639
}
3740

38-
var action = this.element.find('#update_cart_action_container').val();
3941
if (action === 'empty_cart') {
4042
return true;
4143
}

0 commit comments

Comments
 (0)