SEARCH-1968: Static tests to check for dependency of Elasticsearch modules.

Author: RuslanKostiv1

dev/tests/static/testsuite/Magento/Test/Integrity/DependencyTest.php

@@ -31,6 +31,7 @@
 /**
  * @SuppressWarnings(PHPMD.ExcessiveClassComplexity)
  * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ * @SuppressWarnings(PHPMD.TooManyFields)
  */
 class DependencyTest extends \PHPUnit\Framework\TestCase
 {
@@ -1252,10 +1253,10 @@ function ($fileType, $file) use ($extensionConflictList, $allowedDependencies) {
                 $modulesDependencies = array_merge(...$modules);
 
                 foreach ($extensionConflictList as $extension => $disabledModules) {
-                    $foundedModules = \array_unique(array_intersect($modulesDependencies, $disabledModules));
-                    if (!empty($foundedModules)) {
+                    $modulesThatMustBeDisabled = \array_unique(array_intersect($modulesDependencies, $disabledModules));
+                    if (!empty($modulesThatMustBeDisabled)) {
 
-                        foreach ($foundedModules as $foundedModule) {
+                        foreach ($modulesThatMustBeDisabled as $foundedModule) {
                             if (!empty($allowedDependencies[$foundedModule])
                                 && \in_array($module, $allowedDependencies[$foundedModule])
                             ) {
@@ -1270,7 +1271,7 @@ function ($fileType, $file) use ($extensionConflictList, $allowedDependencies) {
                                     ' because it must be disabled when "%s" extension is used.' .
                                     ' See AC-2516 for more details',
                                     $module,
-                                    \implode(', ', $foundedModules),
+                                    \implode(', ', $modulesThatMustBeDisabled),
                                     $module,
                                     $extension
                                 )
@@ -1297,7 +1298,7 @@ private static function getExtensionConflicts(): array
             foreach (glob($extensionConflictsFilePattern) as $fileName) {
                 $extensionConflicts[] = include $fileName;
             }
-            self::$extensionConflicts = array_merge([], ...$extensionConflicts);
+            self::$extensionConflicts = \array_merge_recursive([], ...$extensionConflicts);
         }
         return self::$extensionConflicts;
     }
@@ -1316,7 +1317,7 @@ private static function getAllowedDependencies(): array
             foreach (glob($allowedDependenciesFilePattern) as $fileName) {
                 $allowedDependencies[] = include $fileName;
             }
-            self::$allowedDependencies = array_merge([], ...$allowedDependencies);
+            self::$allowedDependencies = \array_merge_recursive([], ...$allowedDependencies);
         }
         return self::$allowedDependencies;
     }

dev/tests/static/testsuite/Magento/Test/Integrity/_files/extension_dependencies_test/allowed_dependencies/ce.php

@@ -10,7 +10,5 @@
         'Magento\Elasticsearch',
         'Magento\Elasticsearch6',
         'Magento\Elasticsearch7',
-        'Magento\ElasticsearchCatalogPermissions', // move to EE repo
-        'Magento\ElasticsearchCatalogPermissionsGraphQl', // move to EE repo
     ]
 ];

dev/tests/static/testsuite/Magento/Test/Integrity/_files/extension_dependencies_test/extension_conflicts/ce.php

@@ -12,8 +12,5 @@
         'Magento\Elasticsearch',
         'Magento\Elasticsearch6',
         'Magento\Elasticsearch7',
-        'Magento\ElasticsearchCatalogPermissions',// move to EE repo
-        'Magento\ElasticsearchCatalogPermissionsGraphQl', // move to EE repo
-        'Magento\InventoryElasticSearch', // move to Inventory repo
     ],
 ];