graphQl-961: ShippingAddressInput.postcode: String, is not required by Schema

Author: kisroman

app/code/Magento/QuoteGraphQl/Model/Cart/QuoteAddressFactory.php

@@ -16,7 +16,6 @@
 use Magento\Framework\GraphQl\Exception\GraphQlNoSuchEntityException;
 use Magento\Quote\Model\Quote\Address as QuoteAddress;
 use Magento\Quote\Model\Quote\AddressFactory as BaseQuoteAddressFactory;
-use Magento\Framework\App\ObjectManager;
 
 /**
  * Create QuoteAddress
@@ -47,20 +46,19 @@ class QuoteAddressFactory
      * @param BaseQuoteAddressFactory $quoteAddressFactory
      * @param GetCustomerAddress $getCustomerAddress
      * @param AddressHelper $addressHelper
-     * @param CountryInformationAcquirerInterface|null $countryInformationAcquirer
+     * @param CountryInformationAcquirerInterface $countryInformationAcquirer
      */
     public function __construct(
         BaseQuoteAddressFactory $quoteAddressFactory,
         GetCustomerAddress $getCustomerAddress,
         AddressHelper $addressHelper,
-        CountryInformationAcquirerInterface $countryInformationAcquirer = null
+        CountryInformationAcquirerInterface $countryInformationAcquirer
     ) {
         $this->quoteAddressFactory = $quoteAddressFactory;
         $this->getCustomerAddress = $getCustomerAddress;
         $this->addressHelper = $addressHelper;
         $this->countryInformationAcquirer = $countryInformationAcquirer;
-        $this->countryInformationAcquirer = $countryInformationAcquirer
-            ?: ObjectManager::getInstance()->get(CountryInformationAcquirerInterface::class);
+        $this->countryInformationAcquirer = $countryInformationAcquirer;
     }
 
     /**

app/code/Magento/QuoteGraphQl/Model/Cart/SetBillingAddressOnCart.php

@@ -140,6 +140,8 @@ private function validateAddress(Address $shippingAddress)
      *
      * @param array $errors
      * @return string
+     *
+     * @todo change implementation in https://github.com/magento/graphql-ce/issues/970.
      */
     private function getAddressErrors(array $errors): string
     {

app/code/Magento/QuoteGraphQl/Model/Cart/SetShippingAddressesOnCart.php

@@ -81,6 +81,8 @@ private function validateAddress(Address $shippingAddress)
      *
      * @param array $errors
      * @return string
+     *
+     * @todo change implementation in https://github.com/magento/graphql-ce/issues/970.
      */
     private function getAddressErrors(array $errors): string
     {

dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Customer/SetShippingAddressOnCartTest.php

@@ -441,6 +441,22 @@ public function dataProviderUpdateWithMissedRequiredParameters(): array
                     }]',
                 '"regionId" is required. Enter and try again.'
             ],
+            'missed_multiple_fields' => [
+                'cart_id: "cart_id_value"
+                 shipping_addresses: [{
+                    address: {
+                        firstname: "test firstname"
+                        lastname: "test lastname"
+                        company: "test company"
+                        street: ["test street 1", "test street 2"]
+                        city: "test city"
+                        country_code: "US"
+                        telephone: "88776655"
+                        }
+                    }]',
+                '"postcode" is required. Enter and try again.
+"regionId" is required. Enter and try again.'
+            ],
         ];
     }