Skip to content

Commit fa26519

Browse files
AC-1437: Admin site freeze after closing GiftWrapping pop up
1 parent 27833f3 commit fa26519

File tree

2 files changed

+31
-12
lines changed
  • app
    • code/Magento/Sales/view/adminhtml/web/order/create
    • design/adminhtml/Magento/backend/web/css/source/components

2 files changed

+31
-12
lines changed

app/code/Magento/Sales/view/adminhtml/web/order/create/giftmessage.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,10 @@ define([
203203

204204
var topMargin = jQuery(this).closest('.ui-dialog').children('.ui-dialog-titlebar').outerHeight() + 30;
205205

206-
jQuery(this).closest('.ui-dialog').css('margin-top', topMargin);
206+
jQuery(this).closest('.ui-dialog').css({
207+
'margin-top' : topMargin,
208+
'z-index': 1000
209+
});
207210
},
208211
close: function () {
209212
jQuery(this).closest('.ui-dialog').removeClass('ui-dialog-active');

app/design/adminhtml/Magento/backend/web/css/source/components/_popups.less

Lines changed: 27 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -38,16 +38,13 @@
3838
}
3939

4040
.ui-dialog-titlebar-close {
41+
background-color: @color-white;
42+
border-color: @color-white;
4143
cursor: pointer;
42-
.lib-icon-font(
43-
@_icon-font-content: @popup-close-icon__content,
44-
@_icon-font: @popup-close-icon__font,
45-
@_icon-font-size: @popup-close-icon__font-size,
46-
@_icon-font-color: @popup-close-icon__color,
47-
@_icon-font-color-hover: @popup-close-icon__hover__color
48-
);
44+
.lib-icon-font(@_icon-font-content: @popup-close-icon__content, @_icon-font: @popup-close-icon__font, @_icon-font-size: @popup-close-icon__font-size, @_icon-font-color: @popup-close-icon__color, @_icon-font-color-hover: @popup-close-icon__hover__color);
4945
position: absolute;
5046
right: @popup-close-icon__right;
47+
text-shadow: none;
5148
top: @popup-close-icon__top - .3;
5249

5350
.ui-icon {
@@ -57,6 +54,23 @@
5754
&.ui-state-hover {
5855
border: none;
5956
}
57+
58+
&.ui-button-icon-only {
59+
text-indent: -9999px;
60+
white-space: nowrap;
61+
}
62+
63+
&:before {
64+
float: left;
65+
text-indent: 0;
66+
}
67+
68+
&:hover {
69+
background-color: @color-white;
70+
border-color: @color-white;
71+
box-shadow: none;
72+
text-shadow: none;
73+
}
6074
}
6175

6276
.ui-dialog-content {
@@ -416,13 +430,14 @@
416430
// Attribute Popup
417431
// _____________________________________________
418432

419-
.attribute-popup { // ToDo UI: remove or refactor after New attribute popup refactored to sliding panel
433+
// ToDo UI: remove or refactor after New attribute popup refactored to sliding panel
434+
.attribute-popup {
420435
.page-content {
421436
padding: 0;
422437
}
423438
}
424-
425-
.attribute-popup-actions { // ToDo UI: remove or refactor after New attribute popup refactored to sliding panel
439+
// ToDo UI: remove or refactor after New attribute popup refactored to sliding panel
440+
.attribute-popup-actions {
426441
&:extend(.abs-clearfix all);
427442
background: @page-main-actions__background-color;
428443
border-bottom: 1px solid @page-main-actions__border-color;
@@ -433,7 +448,8 @@
433448
float: none;
434449
}
435450

436-
&.fixed { // ToDo UI: remove or refactor after New attribute popup refactored to sliding panel
451+
// ToDo UI: remove or refactor after New attribute popup refactored to sliding panel
452+
&.fixed {
437453
background: @color-white !important;
438454
border-bottom: 0 !important;
439455
left: 0 !important;

0 commit comments

Comments
 (0)