MAGETWO-99152: Special Prices cannot save over 4 characters in Japanese Yen - The comma separator seems to be the issue

Author: serhii-balko

lib/internal/Magento/Framework/Locale/Format.php

@@ -10,6 +10,11 @@
  */
 class Format implements \Magento\Framework\Locale\FormatInterface
 {
+    /**
+     * Japan locale code
+     */
+    private const JAPAN_LOCALE_CODE = 'ja_JP';
+
     /**
      * @var \Magento\Framework\App\ScopeResolverInterface
      */
@@ -25,11 +30,6 @@ class Format implements \Magento\Framework\Locale\FormatInterface
      */
     protected $currencyFactory;
 
-    /**
-     * @var array
-     */
-    private $groupSeparatorByLocale = [];
-
     /**
      * @param \Magento\Framework\App\ScopeResolverInterface $scopeResolver
      * @param ResolverInterface $localeResolver
@@ -87,12 +87,14 @@ public function getNumber($value)
             }
         } elseif ($separatorComa !== false) {
             $locale = $this->_localeResolver->getLocale();
-            $groupSeparator = $this->retrieveLocaleGroupSeparator($locale);
-            if ($groupSeparator === ',') {
-                $value = str_replace(',', '', $value);
-            } else {
-                $value = str_replace(',', '.', $value);
-            }
+            /**
+             * It's hard code for Japan locale.
+             * Comma separator uses as group separator: 4,000 saves as 4,000.00
+             */
+            $value = str_replace(
+                ',',
+                $locale === self::JAPAN_LOCALE_CODE ? '' : '.',
+                $value);
         }
 
         return (float)$value;
@@ -160,22 +162,4 @@ public function getPriceFormat($localeCode = null, $currencyCode = null)
 
         return $result;
     }
-
-    /**
-     * Retrieve group separator symbol by locale
-     *
-     * @param string $locale
-     * @return string
-     */
-    private function retrieveLocaleGroupSeparator(string $locale): string
-    {
-        if (!array_key_exists($locale, $this->groupSeparatorByLocale)) {
-            $formatter = new \NumberFormatter($locale, \NumberFormatter::DECIMAL);
-            $this->groupSeparatorByLocale[$locale] = $formatter->getSymbol(
-                \NumberFormatter::GROUPING_SEPARATOR_SYMBOL
-            );
-        }
-
-        return $this->groupSeparatorByLocale[$locale];
-    }
 }

lib/internal/Magento/Framework/Locale/Test/Unit/FormatTest.php

@@ -129,15 +129,13 @@ public function provideNumbers(): array
             ['12343', 12343],
             ['-9456km', -9456],
             ['0', 0],
-            ['2 054,10', 205410, 'en_US'],
-            ['2 054,10', 2054.1, 'de_DE'],
-            ['2046,45', 204645, 'en_US'],
-            ['2046,45', 2046.45, 'de_DE'],
+            ['2 054,10', 2054.1],
+            ['2046,45', 2046.45],
             ['2 054.52', 2054.52],
-            ['2,46 GB', 246, 'en_US'],
-            ['2,46 GB', 2.46, 'de_DE'],
+            ['2,46 GB', 2.46],
             ['2,054.00', 2054],
-            ['2,000', 2000, 'ja_JP'],
+            ['4,000', 4000.0, 'ja_JP'],
+            ['4,000', 4.0, 'en_US'],
         ];
     }
 }