Skip to content

Commit fcd6f27

Browse files
committed
MAGETWO-93978: Footer Overlaps Storefront Page Content In Mobile View
1 parent a7893f9 commit fcd6f27

File tree

3 files changed

+20
-24
lines changed

3 files changed

+20
-24
lines changed

app/design/frontend/Magento/blank/Magento_Theme/web/css/source/_module.less

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,16 @@
5252
.lib-css(background-color, @page__background-color);
5353
}
5454

55+
.page-wrapper {
56+
.lib-vendor-prefix-display(flex);
57+
.lib-vendor-prefix-flex-direction(column);
58+
min-height: 100vh; // Stretch content area for sticky footer
59+
}
60+
61+
.page-main {
62+
.lib-vendor-prefix-flex-grow(1);
63+
}
64+
5565
//
5666
// Header
5767
// ---------------------------------------------
@@ -279,17 +289,7 @@
279289
// _____________________________________________
280290

281291
.media-width(@extremum, @break) when (@extremum = 'min') and (@break = @screen__m) {
282-
283-
html,
284-
body {
285-
height: 100%; // Stretch screen area for sticky footer
286-
}
287-
288292
.page-wrapper {
289-
.lib-vendor-prefix-display(flex);
290-
.lib-vendor-prefix-flex-direction(column);
291-
min-height: 100%; // Stretch content area for sticky footer
292-
293293
> .breadcrumbs,
294294
> .top-container,
295295
> .widget {

app/design/frontend/Magento/blank/web/css/source/_layout.less

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -94,10 +94,6 @@
9494

9595
.page-main {
9696
width: 100%;
97-
98-
.lib-vendor-prefix-flex-grow(1);
99-
.lib-vendor-prefix-flex-shrink(0);
100-
.lib-vendor-prefix-flex-basis(auto);
10197
}
10298

10399
.columns {

app/design/frontend/Magento/luma/Magento_Theme/web/css/source/_module.less

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,16 @@
6767
.lib-css(background-color, @page__background-color);
6868
}
6969

70+
.page-wrapper {
71+
.lib-vendor-prefix-display(flex);
72+
.lib-vendor-prefix-flex-direction(column);
73+
min-height: 100vh; // Stretch content area for sticky footer
74+
}
75+
76+
.page-main {
77+
.lib-vendor-prefix-flex-grow(1);
78+
}
79+
7080
//
7181
// Header
7282
// ---------------------------------------------
@@ -306,7 +316,6 @@
306316
//
307317
// Widgets
308318
// ---------------------------------------------
309-
310319
.sidebar {
311320
.widget.block:not(:last-child),
312321
.widget:not(:last-child) {
@@ -411,12 +420,6 @@
411420
}
412421
}
413422
}
414-
.page-footer,
415-
.copyright {
416-
bottom: 0;
417-
position: absolute;
418-
width: 100%;
419-
}
420423
}
421424

422425
.media-width(@extremum, @break) when (@extremum = 'max') and (@break = @screen__s) {
@@ -614,10 +617,7 @@
614617
}
615618

616619
.page-wrapper {
617-
.lib-vendor-prefix-display(flex);
618-
.lib-vendor-prefix-flex-direction(column);
619620
margin: 0;
620-
min-height: 100%; // Stretch content area for sticky footer
621621
position: relative;
622622
transition: margin .3s ease-out 0s;
623623

0 commit comments

Comments
 (0)