MC-37006: Adding/removing disabled products to Magento flushes categories cache

Author: dhorytskyi

dev/tests/integration/testsuite/Magento/Catalog/Controller/Adminhtml/Product/Initialization/HelperTest.php

@@ -27,15 +27,14 @@ protected function setUp(): void
     }
 
     /**
-     * @magentoDataFixture Magento/Catalog/_files/categories.php
-     * @magentoDataFixture Magento/Catalog/_files/second_product_simple.php
+     * @magentoDataFixture Magento/Catalog/_files/products_in_categories.php
      * @dataProvider initializeCategoriesFromDataProvider
      * @param string $sku
      * @param array $categoryIds
      */
     public function testInitializeCategoriesFromData(string $sku, array $categoryIds): void
     {
-        $productRepository = Bootstrap::getObjectManager()->get(ProductRepositoryInterface::class);
+        $productRepository = Bootstrap::getObjectManager()->create(ProductRepositoryInterface::class);
         /** @var \Magento\Catalog\Model\Product $product */
         $product = $productRepository->get($sku);
         $productData = $product->getData();
@@ -55,34 +54,15 @@ public function testInitializeCategoriesFromData(string $sku, array $categoryIds
     public function initializeCategoriesFromDataProvider(): array
     {
         return [
-            'assign categories' => [
-                'simple',
-                [2, 3, 4, 11, 12, 13],
-            ],
-            'unassign categories' => [
-                'simple-4',
-                [11, 12],
-            ],
-            'update categories' => [
-                'simple-3',
-                [10, 12, 13],
-            ],
-            'change all categories' => [
-                'simple-3',
-                [4, 5]
-            ],
-            'unassign all categories' => [
-                'simple-3',
-                [],
-            ],
-            'assign new category' => [
-                'simple2',
-                [11],
-            ],
-            'assign new categories' => [
-                'simple2',
-                [11, 13],
-            ],
+            'assign category' => ['simple1', [3, 4]],
+            'assign categories' => ['simple1', [3, 5, 6]],
+            'unassign category' => ['simple2', [3, 6]],
+            'unassign categories' => ['simple2', [3]],
+            'update categories' => ['simple2', [3, 4, 6]],
+            'change all categories' => ['simple2', [4]],
+            'unassign all categories' => ['simple2', []],
+            'assign new category' => ['simple3', [4]],
+            'assign new categories' => ['simple3', [4, 5]],
         ];
     }
 }

dev/tests/integration/testsuite/Magento/Catalog/_files/categories.php

@@ -12,15 +12,11 @@
 $productRepository = $objectManager->create(
     \Magento\Catalog\Api\ProductRepositoryInterface::class
 );
-$categoryRepository = $objectManager->create(
-    \Magento\Catalog\Api\CategoryRepositoryInterface::class
-);
 
 $categoryLinkRepository = $objectManager->create(
     \Magento\Catalog\Api\CategoryLinkRepositoryInterface::class,
     [
-        'productRepository' => $productRepository,
-        'categoryRepository' => $categoryRepository,
+        'productRepository' => $productRepository
     ]
 );
 

dev/tests/integration/testsuite/Magento/Catalog/_files/products_in_categories.php

@@ -0,0 +1,57 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+$objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager();
+
+foreach (range(3, 7) as $categoryId) {
+    $category = $objectManager->create(\Magento\Catalog\Model\Category::class);
+    $category->isObjectNew(true);
+    $category->setId($categoryId)
+        ->setName('Category ' . $categoryId)
+        ->setParentId(2)
+        ->setPath('1/2/' . $categoryId)
+        ->setLevel(2)
+        ->setIsActive(true)
+        ->save();
+}
+
+foreach (range(1, 3) as $productId) {
+    $product = $objectManager->create(\Magento\Catalog\Model\Product::class);
+    $product->isObjectNew(true);
+    $product->setId($productId)
+        ->setTypeId(\Magento\Catalog\Model\Product\Type::TYPE_SIMPLE)
+        ->setAttributeSetId(4)
+        ->setStoreId(1)
+        ->setWebsiteIds([1])
+        ->setName('Simple Product ' . $productId)
+        ->setSku('simple' . $productId)
+        ->setPrice(10)
+        ->setWeight(1)
+        ->setStockData(['use_config_manage_stock' => 1, 'qty' => 100, 'is_qty_decimal' => 0, 'is_in_stock' => 1])
+        ->setVisibility(\Magento\Catalog\Model\Product\Visibility::VISIBILITY_BOTH)
+        ->setStatus(\Magento\Catalog\Model\Product\Attribute\Source\Status::STATUS_ENABLED)
+        ->save();
+}
+
+$categoryRepository = $objectManager->create(\Magento\Catalog\Api\CategoryRepositoryInterface::class);
+$categoryLinkRepository = $objectManager->create(
+    \Magento\Catalog\Api\CategoryLinkRepositoryInterface::class,
+    [
+        'categoryRepository' => $categoryRepository,
+    ]
+);
+$categoryLinkManagement = $objectManager->create(
+    \Magento\Catalog\Api\CategoryLinkManagementInterface::class,
+    [
+        'categoryRepository' => $categoryRepository,
+    ]
+);
+$reflectionClass = new \ReflectionClass(get_class($categoryLinkManagement));
+$reflectionProperty = $reflectionClass->getProperty('categoryLinkRepository');
+$reflectionProperty->setAccessible(true);
+$reflectionProperty->setValue($categoryLinkManagement, $categoryLinkRepository);
+$categoryLinkManagement->assignProductToCategories('simple1', [3]);
+$categoryLinkManagement->assignProductToCategories('simple2', [3, 5, 6]);

dev/tests/integration/testsuite/Magento/Catalog/_files/products_in_categories_rollback.php

@@ -0,0 +1,31 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+$objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager();
+
+$registry = $objectManager->get(\Magento\Framework\Registry::class);
+$registry->unregister('isSecureArea');
+$registry->register('isSecureArea', true);
+
+$productRepository = $objectManager->create(\Magento\Catalog\Api\ProductRepositoryInterface::class);
+$productsToDelete = ['simple1', 'simple2', 'simple3'];
+foreach ($productsToDelete as $sku) {
+    try {
+        $product = $productRepository->get($sku, false, null, true);
+        $productRepository->delete($product);
+    } catch (\Magento\Framework\Exception\NoSuchEntityException $e) {
+        //Product already removed
+    }
+}
+
+$collection = $objectManager->create(\Magento\Catalog\Model\ResourceModel\Category\Collection::class);
+foreach ($collection->addAttributeToFilter('level', 2) as $category) {
+    /** @var \Magento\Catalog\Model\Category $category */
+    $category->delete();
+}
+
+$registry->unregister('isSecureArea');
+$registry->register('isSecureArea', false);