Order creation in backoffice with multiple products of which at least one contains custom options, leads to unwanted extra products to get added to the order

[hostep]

Preconditions and environment

• Magento version: 2.4.7-p6, 2.4.8-p1, 2.4-develop (tried with commit b209408) (for what it's worth, this bug didn't happen on Magento 2.3.6-p1)

Steps to reproduce

Everything happens in the backoffice:

1. Create a simple product, nothing special
2. Create a second simple product, but this time with 2 custom options, of which one is a file upload (see screenshot)

3. Reindex
4. Still in backoffice, go to Sales > Orders > Create New Order
5. Click 'Create new Customer' button
6. Click 'Add Products' button
7. Add the simple product with custom options, just select one of the 2 radio buttons, and pick qty: 10, nothing else
8. Click 'Add Selected Product(s) to Order' button
9. Click 'Add Products' button again
10. Now select the other simple product, the one without custom options, qty: 1
11. Click 'Add Selected Product(s) to Order' again

Expected result

We expect 2 item rows in the order:

• simple product with custom options - qty 10
• simple product - qty 1

Actual result

We see 3 item rows in the order:

• simple product with custom options - qty 10
• simple product with custom options - qty 1 - and some errors about missing required options
• simple product - qty 1

Additional information

This happens because with the second product you add, a POST request goes to the url /sales/order_create/loadBlock/key/{redacted}/block/search,items,shipping_method,totals,giftmessage,billing_method?isAjax=true and contains the following in the payload:

item[2][options][files_prefix] => item_2_
item[1][qty] => 1
customer_id =>
store_id => 1
currency_id => 
form_key => {redacted}
payment[method] => checkmo
reset_shipping => 1
json => 1
as_js_varname => iFrameResponse
form_key => {redacted}

The first line is the one that causes problems and causes the unwanted product to be added to the cart

Temporary workaround

I have figured out this very ugly workaround that prevents this, but I'm very sure that this isn't the best solution. But no idea what the best solution would be ... (probably to fix the JS to not send data for product items you didn't add?)

diff --git a/app/code/Magento/Sales/Model/AdminOrder/Create.php b/app/code/Magento/Sales/Model/AdminOrder/Create.php
index 4b1868e6852..68ed656d8e3 100644
--- a/app/code/Magento/Sales/Model/AdminOrder/Create.php
+++ b/app/code/Magento/Sales/Model/AdminOrder/Create.php
@@ -1142,6 +1142,20 @@ class Create extends \Magento\Framework\DataObject implements \Magento\Checkout\
     public function addProducts(array $products)
     {
         foreach ($products as $productId => $config) {
+            // VERY DIRTY HACK TO PREVENT ADDING UNWANTED PRODUCTS TO ORDER, WHEN CREATING ORDER IN ADMIN
+            $configToIgnore = [
+                'options' => [
+                    'files_prefix' => sprintf('item_%d_', (int) $productId),
+                ],
+            ];
+            $strippedConfigToCompare = $config;
+            unset($strippedConfigToCompare['_processing_params']);
+
+            if ($strippedConfigToCompare === $configToIgnore) {
+                continue;
+            }
+            // END VERY DIRTY HACK
+
             $config['qty'] = isset($config['qty']) ? (double)$config['qty'] : 1;
             try {
                 $this->addProduct($productId, $config);

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @hostep. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant]

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-November]

Hello @hostep

Thank for you report and collaboration.

We attempt to reproduce this issue in our latest 2.4 develop instances. issue is reproducible here is the attached screenshot for the references.

Steps to Reproduce:

• Create a simple product, nothing special
• Create a second simple product, but this time with 2 custom options, of which one is a file upload
• Still in backoffice, go to Sales > Orders > Create New Order
• Click 'Create new Customer' button
• Click 'Add Products' button
• Add the simple product with custom options, just select one of the 2 radio buttons, and pick qty: 10, nothing else
• Click 'Add Selected Product(s) to Order' button
• Click 'Add Products' button again
• Now select the other simple product, the one without custom options, qty: 1
• Click 'Add Selected Product(s) to Order' again

As we followed the Precondition and the steps to reproducible and issue is encountered and Hence this issue is marking as "Issue:Confirmed"

Thank You!

[github-jira-sync-bot]

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.