Issue with around plugins on both parent and child classes in Magento 2

[MagePsycho]

I am trying to use plugins on the following Magento 2 core methods:

• \Magento\Bundle\Model\Product\Type::checkProductBuyState()
• \Magento\Bundle\Model\Product\Type::getOptionsIds()
• \Magento\Catalog\Model\Product\Type\AbstractType::checkProductBuyState()

Core classes (simplified)

Magento\Bundle\Model\Product\Type extends Magento\Catalog\Model\Product\Type\AbstractType:

class \Magento\Bundle\Model\Product\Type extends \Magento\Catalog\Model\Product\Type\AbstractType
{
    public function checkProductBuyState($product)
    {
        parent::checkProductBuyState($product);
        $productOptionIds = $this->getOptionsIds($product);
        // ... more logic
        return $this;
    }

    public function getOptionsIds($product)
    {
        return $this->getOptionsCollection($product)->getAllIds();
    }
}

AbstractType itself has its own checkProductBuyState:

abstract class \Magento\Catalog\Model\Product\Type\AbstractType
{
    public function checkProductBuyState($product)
    {
        if (!$product->getSkipCheckRequiredOption() && $product->getHasOptions()) {
            // ... validate required options
            throw new \Magento\Framework\Exception\LocalizedException(
                __('The product has required options. Enter the options and try again.')
            );
        }
        return $this;
    }
}

My plugins

<type name="Magento\Catalog\Model\Product\Type\AbstractType">
    <plugin name="MagePsycho_Catalog_AbstractType::aroundCheckProductBuyState"
            type="MagePsycho\Catalog\Plugin\Model\Product\Type\AbstractTypePlugin"
            sortOrder="10"/>
</type>

<type name="Magento\Bundle\Model\Product\Type">
    <plugin name="MagePsycho_Catalog_Bundle_Type::aroundCheckProductBuyState"
            type="MagePsycho\Catalog\Plugin\Bundle\Model\Product\Type\AroundCheckProductBuyStatePlugin"
            sortOrder="10"/>
    <plugin name="MagePsycho_Catalog_Bundle_Type::aroundGetOptionsIds"
            type="MagePsycho\Catalog\Plugin\Bundle\Model\Product\Type\AroundGetOptionsIdsPlugin"
            sortOrder="10"/>
</type>

Problem

If I add a plugin around Magento\Catalog\Model\Product\Type\AbstractType::checkProductBuyState(), then my plugins for the bundle product type (getOptionsIds, checkProductBuyState) stop working.

If I remove the plugin on AbstractType::checkProductBuyState(), the bundle plugins work fine.

Question

Why is my plugin on Magento\Bundle\Model\Product\Type not being executed when I also have a plugin on Magento\Catalog\Model\Product\Type\AbstractType?

• Is it because Bundle\Type extends AbstractType and the interceptor chain is broken?
• Do I need to handle $proceed differently in the AbstractType plugin?
• Or should I move my logic directly to the bundle type instead of the abstract type?

💡 What am I missing here? How can I make both plugins (AbstractType::checkProductBuyState and Bundle\Type::getOptionsIds) work together?

[m2-assistant]

Hi @MagePsycho. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[engcom-Hotel]

Hello @MagePsycho,

After going through the issue description, it seems you have some queries but not a Magento core issue. I suggest you to post the query to Magento Stackexchange.

We are using this platform to handle the issues posted for Magento 2 core.

Let us know if we missed anything.