\Magento\Csp\Helper\CspNonceProvider is not an actual Helper class - misleading naming

[ioweb-gr]

Summary

ON magento 2.4.8-p3 I noticed that \Magento\Csp\Helper\CspNonceProvider is misleadingly named

it lives under the Helper namespace but does not extend \Magento\Framework\App\Helper\AbstractHelper.

It behaves however as a standalone service used for generating CSP nonces, not as a traditional Magento helper.

This inconsistency can confuse developers and tools expecting helper behavior.

Examples

• Misleading:

  use Magento\Csp\Helper\CspNonceProvider;
  $nonce = $this->cspNonceProvider->generateNonce(); // not a real Helper

• What it should have been:

  use Magento\Csp\Service\CspNonceProvider;
  // or
  use Magento\Csp\Model\CspNonceProvider;

• Expected Helper (if it really were one):

  class CspNonceProvider extends \Magento\Framework\App\Helper\AbstractHelper
  {
      // typical helper access to store config, context, etc.
  }

In short: the class name implies framework helper semantics, but it’s just a regular service.

Morever if it's not extending AbstractHelper then it's not possible to use it directly in PHTML files but you have to inject the viewModel instead.

In any case either the namespace should be corrected or it should extend the AbstractHelper, leaving it like this is misleading as to it's purpose.

Proposed solution

Either move it under another namespace or extend AbstractHelper

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @ioweb-gr. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant]

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Hotel]

Hello @ioweb-gr,

Thank you for your report and collaboration!

In order to reproduce the issue, we have reviewed the code from the latest development branch i.e. 2.4-develop and it seems the issue has been reproducible for us.

We have referred the below helper classes to verify if it extends the \Magento\Framework\App\Helper\AbstractHelper:

magento2/app/code/Magento/Backend/Helper/Dashboard/AbstractDashboard.php

Line 15 in 3cf1a10

abstract class AbstractDashboard extends \Magento\Framework\App\Helper\AbstractHelper

magento2/app/code/Magento/Backend/Helper/Dashboard/Data.php

Line 23 in 3cf1a10

class Data extends AbstractHelper

Hence confirming the issue.