Allow overriding constant values of integration test settings per ENV

[stollr]

Summary

This request is mainly about overriding the TESTS_CLEANUP constant value in integration tests. Currently this value can be changed in the phpunit.xml. But this is very static and cannot be overridden easily.

My use case:
In my local dev environment I usually want to run the integration tests without the cleanup, because it takes too long. But when there are new migration scripts or modules, I want the cleanup to be executed.

Currently this requires me to edit the phpunit.xml, which is quite annoying.

Therefore I suggest to make the integration test settings overridable per env variables.

Then I can run TESTS_CLEANUP=disable vendor/bin/phpunit -c dev/tests/integration/phpunit.xml

Examples

The patch would simply be

diff --git a/dev/tests/integration/framework/bootstrap.php b/dev/tests/integration/framework/bootstrap.php
index 09f599217ca..749f3394c1b 100644
--- a/dev/tests/integration/framework/bootstrap.php
+++ b/dev/tests/integration/framework/bootstrap.php
@@ -30,7 +30,10 @@ try {
     setCustomErrorHandler();
 
     /* Bootstrap the application */
-    $settings = new \Magento\TestFramework\Bootstrap\Settings($testsBaseDir, get_defined_constants());
+    $settings = new \Magento\TestFramework\Bootstrap\Settings($testsBaseDir, array_replace(
+        get_defined_constants(),
+        getenv()
+    ));
 
     $testFrameworkDir = __DIR__;
     require_once 'deployTestModules.php';

Proposed solution

No response

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @stollr. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[stollr]

PR is available.

[m2-assistant]

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Hotel]

Hello @stollr,

Thank you for the contribution!

After going through with the issue description, it seems that this can be categorised as a feature request. Its a good to have feature.

Hence marking this issue as a feature request.

Thank you