Merge pull request #166 from magento-commerce/feature/decouple-business-from-sales-extension

decouple Meta_BusinessExtension from Meta_Sales

Author: bgiamarino

app/code/Meta/BusinessExtension/Helper/GraphAPIAdapter.php

@@ -18,7 +18,6 @@
 namespace Meta\BusinessExtension\Helper;
 
 use CURLFile;
-use Meta\Sales\Model\FacebookOrder;
 use Meta\BusinessExtension\Model\System\Config as SystemConfig;
 use GuzzleHttp\Client;
 use GuzzleHttp\Exception\BadResponseException;
@@ -29,6 +28,9 @@ class GraphAPIAdapter
 {
     const GET_ORDERS_LIMIT = 25;
 
+    /** @var string */
+    private const ORDER_STATE_CREATED = 'STATE_CREATED';
+
     /**
      * @var mixed
      */
@@ -375,7 +377,7 @@ public function getOrders($pageId, $cursorAfter = false)
         ];
         $request = [
             'access_token' => $this->accessToken,
-            'state' => FacebookOrder::STATE_CREATED,
+            'state' => self::ORDER_STATE_CREATED,
             'fields' => implode(',', $requestFields),
             'limit' => self::GET_ORDERS_LIMIT,
         ];

app/code/Meta/Conversion/view/frontend/web/js/metaPixelTracker.js

@@ -1,16 +1,17 @@
+/* global fbq */
 define([
     'jquery'
 ], function ($) {
     'use strict';
 
     return function (config) {
-
-        var browserEventData = config.browserEventData;
-        var eventId = crypto.randomUUID();
+        var browserEventData = config.browserEventData,
+            eventId = crypto.randomUUID();
 
         config.payload.eventId = eventId;
 
-        let browserPayload = config.browserEventData.payload
+        let browserPayload = config.browserEventData.payload;
+
         browserPayload.source = browserEventData.source;
 
         browserPayload.pluginVersion = browserEventData.pluginVersion;
@@ -24,12 +25,12 @@ define([
         $.ajax({
             showLoader: true,
             url: config.url,
-            type: "POST",
+            type: 'POST',
             data: config.payload,
-            dataType: "json",
+            dataType: 'json',
             error: function (error) {
-                console.log(error)
+                console.log(error);
             }
         });
-    }
+    };
 });