make extension code compatible with Magento v2.4.3 and PHP 7 (#240)

Author: zlik

app/code/Meta/Catalog/Model/Product/Feed/Builder/MultiSourceInventory.php

@@ -104,7 +104,7 @@ private function isInStock(Product $product, int $stockId): bool
      * @param int $stockId
      * @return int|float
      */
-    private function getStockQty(Product $product, int $stockId): int|float
+    private function getStockQty(Product $product, int $stockId)
     {
         try {
             return $this->getProductSalableQtyInterface->execute(

app/code/Meta/Catalog/Model/Product/Feed/Builder/Tools.php

@@ -105,13 +105,18 @@ public function htmlDecode($value)
     public function formatPrice($price, $storeId = null)
     {
         $currencyModel = $this->priceCurrency->getCurrency($storeId);
+        $currencySymbol = $currencyModel->getCurrencySymbol();
+
         $amount = $this->priceCurrency->convert($price, $storeId, $currencyModel);
         try {
-            return sprintf(
+            $price = sprintf(
                 '%s %s',
                 $currencyModel->formatTxt($amount, ['display' => Currency::NO_SYMBOL]),
                 $currencyModel->getCode()
             );
+            // workaround for 2.4.3
+            $price = trim($price, $currencySymbol);
+            return $price;
         } catch (Exception $e) {
             return '';
         }
@@ -133,14 +138,18 @@ public function getUnitPrice(Product $product)
         }
 
         $currencyModel = $this->priceCurrency->getCurrency($product->getStoreId());
+        $currencySymbol = $currencyModel->getCurrencySymbol();
 
         try {
-            return sprintf(
+            $price = sprintf(
                 "{'value':'%s','currency':'%s','unit':'%s'}",
                 $currencyModel->formatTxt($value, ['display' => Currency::NO_SYMBOL]),
                 $currencyModel->getCode(),
                 $unit
             );
+            // workaround for 2.4.3
+            $price = trim($price, $currencySymbol);
+            return $price;
         } catch (Exception $e) {
             return '';
         }

app/code/Meta/Catalog/Observer/Product/DeleteAfter.php

@@ -67,7 +67,7 @@ public function __construct(
         GraphApiAdapter $graphApiAdapter,
         FBEHelper $fbeHelper,
         Identifier $identifier,
-        ManagerInterface $messageManager,
+        ManagerInterface $messageManager
     ) {
         $this->systemConfig = $systemConfig;
         $this->graphApiAdapter = $graphApiAdapter;

app/code/Meta/Conversion/Helper/ServerSideHelper.php

@@ -60,7 +60,7 @@ class ServerSideHelper
     public function __construct(
         FBEHelper $fbeHelper,
         AAMFieldsExtractorHelper $aamFieldsExtractorHelper,
-        SystemConfig $systemConfig,
+        SystemConfig $systemConfig
     ) {
         $this->fbeHelper = $fbeHelper;
         $this->aamFieldsExtractorHelper = $aamFieldsExtractorHelper;