Skip to content

Commit 0fe4561

Browse files
authored
Respecting cookie values in common.php (#774)
* Respecting cookie values in common.php * adding a more accurate check * address comment * address comment2
1 parent 01cea50 commit 0fe4561

File tree

1 file changed

+17
-1
lines changed

1 file changed

+17
-1
lines changed

app/code/Meta/Conversion/Observer/Common.php

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
<?php
2+
23
declare(strict_types=1);
34

45
namespace Meta\Conversion\Observer;
56

67
use Magento\Framework\Json\Helper\Data as JsonHelper;
78
use Magento\Framework\Stdlib\Cookie\CookieMetadataFactory;
89
use Magento\Framework\Stdlib\CookieManagerInterface;
10+
use Magento\Cookie\Helper\Cookie as CookieHelper;
911

1012
/**
1113
* Set cookie with payload data for event pixel
@@ -29,21 +31,29 @@ class Common
2931
*/
3032
private CookieManagerInterface $cookieManager;
3133

34+
/**
35+
* @var CookieHelper
36+
*/
37+
private CookieHelper $cookieHelper;
38+
3239
/**
3340
* Constructor common
3441
*
3542
* @param CookieManagerInterface $cookieManager
3643
* @param CookieMetadataFactory $cookieMetadataFactory
3744
* @param JsonHelper $jsonHelper
45+
* @param CookieHelper $cookieHelper
3846
*/
3947
public function __construct(
4048
CookieManagerInterface $cookieManager,
4149
CookieMetadataFactory $cookieMetadataFactory,
42-
JsonHelper $jsonHelper
50+
JsonHelper $jsonHelper,
51+
CookieHelper $cookieHelper
4352
) {
4453
$this->cookieManager = $cookieManager;
4554
$this->cookieMetadataFactory = $cookieMetadataFactory;
4655
$this->jsonHelper = $jsonHelper;
56+
$this->cookieHelper = $cookieHelper;
4757
}
4858

4959
/**
@@ -58,6 +68,12 @@ public function __construct(
5868
*/
5969
public function setCookieForMetaPixel($cookieName, $dataForMetaPixel)
6070
{
71+
if ($this->cookieHelper->isCookieRestrictionModeEnabled()
72+
&& $this->cookieHelper->isUserNotAllowSaveCookie()
73+
) {
74+
return;
75+
}
76+
6177
$publicCookieMetadata = $this->cookieMetadataFactory->createPublicCookieMetadata()
6278
->setDuration(3600)
6379
->setPath('/')

0 commit comments

Comments
 (0)