Catalog update script called in FBE installs response (#472)

* Catalog update script called in FBE installs response

* Int type casted

* comment updated

Author: singhramanpreett

app/code/Meta/BusinessExtension/Helper/CatalogConfigUpdateHelper.php

@@ -64,18 +64,22 @@ public function __construct(
      * @param string $catalogId
      * @param string $commercePartnerIntegrationId
      * @param string $pixelId
+     * @param bool $triggerFullSync
      * @return void
      */
     public function updateCatalogConfiguration(
         int $storeId,
         string $catalogId,
         string $commercePartnerIntegrationId,
-        string $pixelId
+        string $pixelId,
+        bool $triggerFullSync = true,
     ): void {
         $oldCatalogId = $this->systemConfig->getCatalogId($storeId);
         try {
+            $isCatalogUpdated = $oldCatalogId != $catalogId;
+
             // if Catalog id is updated, only then we update the config
-            if ($oldCatalogId != $catalogId) {
+            if ($isCatalogUpdated) {
                 // updates catalog id
                 $this->systemConfig->saveConfig(
                     SystemConfig::XML_PATH_FACEBOOK_BUSINESS_EXTENSION_CATALOG_ID,
@@ -115,7 +119,9 @@ public function updateCatalogConfiguration(
             // Dispatch the facebook_update_catalog_configuration_after event,
             // so observers in other Meta modules can subscribe and trigger their syncs,
             // such as full catalog sync, and shipping profiles sync
-            $this->eventManager->dispatch('facebook_update_catalog_configuration_after', ['store_id' => $storeId]);
+            if ($triggerFullSync || $isCatalogUpdated) {
+                $this->eventManager->dispatch('facebook_update_catalog_configuration_after', ['store_id' => $storeId]);
+            }
         } catch (\Throwable $e) {
             $context = [
                 'store_id' => $storeId,

app/code/Meta/BusinessExtension/Model/SaveFBEInstallsResponse.php

@@ -23,6 +23,7 @@
 use GuzzleHttp\Exception\GuzzleException;
 use Magento\Framework\Exception\LocalizedException;
 use Magento\Store\Model\ScopeInterface;
+use Meta\BusinessExtension\Helper\CatalogConfigUpdateHelper;
 use Meta\BusinessExtension\Helper\FBEHelper;
 use Meta\BusinessExtension\Helper\GraphAPIAdapter;
 use Meta\BusinessExtension\Model\ResourceModel\FacebookInstalledFeature;
@@ -50,24 +51,32 @@ class SaveFBEInstallsResponse
      */
     private $installedFeatureResource;
 
+    /**
+     * @var CatalogConfigUpdateHelper
+     */
+    private CatalogConfigUpdateHelper $catalogConfigUpdateHelper;
+
     /**
      * Construct
      *
      * @param FBEHelper $fbeHelper
      * @param SystemConfig $systemConfig
      * @param GraphAPIAdapter $graphApiAdapter
      * @param FacebookInstalledFeature $installedFeatureResource
+     * @param CatalogConfigUpdateHelper $catalogConfigUpdateHelper
      */
     public function __construct(
         FBEHelper $fbeHelper,
         SystemConfig $systemConfig,
         GraphAPIAdapter $graphApiAdapter,
-        FacebookInstalledFeature $installedFeatureResource
+        FacebookInstalledFeature $installedFeatureResource,
+        CatalogConfigUpdateHelper $catalogConfigUpdateHelper
     ) {
         $this->fbeHelper = $fbeHelper;
         $this->systemConfig = $systemConfig;
         $this->graphApiAdapter = $graphApiAdapter;
         $this->installedFeatureResource = $installedFeatureResource;
+        $this->catalogConfigUpdateHelper = $catalogConfigUpdateHelper;
     }
 
     /**
@@ -86,15 +95,24 @@ public function save($response, $storeId)
             return false;
         }
         $data = $response[0];
+        $catalogId = $data['catalog_id'] ?? '';
+        $pixelId = $data['pixel_id'] ?? '';
+        $commercePartnerIntegrationId = $data['commerce_partner_integration_id'] ?? '';
+
+        // we will update catalog config if catalog has been updated in Meta
+        $this->catalogConfigUpdateHelper->updateCatalogConfiguration(
+            (int) $storeId,
+            $catalogId,
+            $commercePartnerIntegrationId,
+            $pixelId,
+            false
+        );
 
-        $this->savePixelId($data['pixel_id'] ?? '', $storeId);
+        $this->savePixelId($pixelId, $storeId);
         $this->saveProfiles($data['profiles'] ?? '', $storeId);
         $this->savePages($data['pages'] ?? '', $storeId);
-        $this->saveCatalogId($data['catalog_id'] ?? '', $storeId);
-        $this->saveCommercePartnerIntegrationId(
-            $data['commerce_partner_integration_id'] ?? '',
-            $storeId
-        );
+        $this->saveCatalogId($catalogId, $storeId);
+        $this->saveCommercePartnerIntegrationId($commercePartnerIntegrationId, $storeId);
         $this->saveMerchantSettingsId($data['commerce_merchant_settings_id'] ?? '', $storeId);
         $this->saveInstalledFeatures($data['installed_features'] ?? '', $storeId);
         $this->systemConfig->cleanCache();