Bigger Category collection class split into core sync and utility helper class (#504)

* Category collection class split into 2 small files

* Comments addressed

* supress warning added

* Category repository get size issue removed

* extra space removed

Author: singhramanpreett

app/code/Meta/Catalog/Controller/Adminhtml/Ajax/CategoryUpload.php

@@ -25,7 +25,7 @@
 use Meta\BusinessExtension\Controller\Adminhtml\Ajax\AbstractAjax;
 use Meta\BusinessExtension\Helper\FBEHelper;
 use Meta\BusinessExtension\Model\System\Config as SystemConfig;
-use Meta\Catalog\Model\Feed\CategoryCollection;
+use Meta\Catalog\Model\Category\CategoryCollection;
 
 class CategoryUpload extends AbstractAjax
 {

app/code/Meta/Catalog/Cron/CategorySyncCron.php

@@ -22,7 +22,7 @@
 
 use Meta\BusinessExtension\Helper\FBEHelper;
 use Meta\BusinessExtension\Model\System\Config as SystemConfig;
-use Meta\Catalog\Model\Feed\CategoryCollection;
+use Meta\Catalog\Model\Category\CategoryCollection;
 
 class CategorySyncCron
 {

app/code/Meta/Catalog/Helper/CatalogSyncHelper.php

@@ -22,7 +22,7 @@
 
 use Meta\BusinessExtension\Helper\FBEHelper;
 use Meta\BusinessExtension\Model\System\Config as SystemConfig;
-use Meta\Catalog\Model\Feed\CategoryCollection;
+use Meta\Catalog\Model\Category\CategoryCollection;
 use Meta\Catalog\Model\Product\Feed\Uploader;
 
 class CatalogSyncHelper

app/code/Meta/Catalog/Helper/Product/Identifier.php

@@ -49,6 +49,21 @@ public function __construct(SystemConfig $systemConfig, ProductRepository $produ
         $this->productRepository = $productRepository;
     }
 
+    /**
+     * Get product's identifier col name(SKU or entity ID, depending on configuration)
+     *
+     * @return string
+     */
+    public function getProductIdentifierColName(): string
+    {
+        if ($this->identifierAttr === IdentifierConfig::PRODUCT_IDENTIFIER_SKU) {
+            return 'sku';
+        } elseif ($this->identifierAttr === IdentifierConfig::PRODUCT_IDENTIFIER_ID) {
+            return 'entity_id';
+        }
+        return '';
+    }
+
     /**
      * Get product's identifier (SKU or ID, depending on configuration)
      *