Cleaning up Shipping syncing code (#420)

* changes

* changes

* changes

---------

Co-authored-by: Daniel M Connolly <[email protected]>

Author: danielmetaconnolly

app/code/Meta/BusinessExtension/Controller/Adminhtml/Ajax/PostFBEOnboardingSync.php

@@ -63,12 +63,12 @@ class PostFBEOnboardingSync extends AbstractAjax
      * @param ShippingSyncer $shippingSyncer
      */
     public function __construct(
-        Context $context,
-        JsonFactory $resultJsonFactory,
-        FBEHelper $fbeHelper,
-        SystemConfig $systemConfig,
+        Context           $context,
+        JsonFactory       $resultJsonFactory,
+        FBEHelper         $fbeHelper,
+        SystemConfig      $systemConfig,
         CatalogSyncHelper $catalogSyncHelper,
-        ShippingSyncer $shippingSyncer
+        ShippingSyncer    $shippingSyncer
     ) {
         parent::__construct($context, $resultJsonFactory, $fbeHelper);
         $this->fbeHelper = $fbeHelper;
@@ -93,7 +93,8 @@ public function executeForJson(): array
         }
 
         try {
-            $storeName = $this->systemConfig->getStoreManager()->getStore($storeId)->getName();
+            $store = $this->systemConfig->getStoreManager()->getStore($storeId);
+            $storeName = $store->getName();
             if (!$this->systemConfig->getAccessToken($storeId)) {
                 $response['success'] = false;
                 $response['message'] = __(
@@ -112,7 +113,7 @@ public function executeForJson(): array
             // Immediately after onboarding we initiate full catalog sync.
             // It syncs all products and all categories to Meta Catalog
             $this->catalogSyncHelper->syncFullCatalog($storeId);
-            $this->shippingSyncer->syncShippingProfiles();
+            $this->shippingSyncer->syncShippingProfiles('post_fbe_onboarding', $store);
 
             $response['success'] = true;
             $response['message'] = 'Post FBE Onboarding Sync successful';

app/code/Meta/Sales/Plugin/ShippingSettingsUpdatePlugin.php

@@ -50,6 +50,6 @@ public function afterSave(Config $config): void
         if ($sectionName !== 'carriers') {
             return;
         }
-        $this->shippingSyncer->syncShippingProfiles();
+        $this->shippingSyncer->syncShippingProfiles('after_save');
     }
 }

app/code/Meta/Sales/Plugin/ShippingSyncer.php

@@ -22,6 +22,7 @@
 
 use Exception;
 use Magento\Framework\Filesystem;
+use Magento\Store\Api\Data\StoreInterface;
 use Magento\Store\Model\StoreManagerInterface;
 use Meta\BusinessExtension\Helper\GraphAPIAdapter;
 use Meta\BusinessExtension\Helper\FBEHelper;
@@ -96,39 +97,59 @@ public function __construct(
     /**
      * Syncing shipping profiles to Meta
      *
-     * @param string|null $accessToken
-     * @param string|null $partnerIntegrationId
+     * @param string $event_type
+     * @param StoreInterface|null $store
      * @return void
      */
-    public function syncShippingProfiles(string $accessToken = null, string $partnerIntegrationId = null)
+    public function syncShippingProfiles(string $event_type, StoreInterface $store = null)
     {
+        if ($store !== null) {
+            $this->syncShippingProfilesForStore($event_type, $store);
+            return;
+        }
         foreach ($this->storeManager->getStores() as $store) {
-            try {
-                $this->shippingData->setStoreId((int)$store->getId());
-                $shippingProfiles = [
-                    $this->shippingData->buildShippingProfile(ShippingProfileTypes::TABLE_RATE),
-                    $this->shippingData->buildShippingProfile(ShippingProfileTypes::FLAT_RATE),
-                    $this->shippingData->buildShippingProfile(ShippingProfileTypes::FREE_SHIPPING),
-                ];
-                $fileUri = $this->shippingFileBuilder->createFile($shippingProfiles);
-                $accessToken = $accessToken ?? $this->systemConfig->getAccessToken($store->getId());
-                $partnerIntegrationId = $partnerIntegrationId ??
-                    $this->systemConfig->getCommercePartnerIntegrationId($store->getId());
-                $this->graphApiAdapter->setDebugMode($this->systemConfig->isDebugMode($store->getId()))
-                    ->setAccessToken($accessToken);
-                $this->graphApiAdapter->uploadFile(
-                    $partnerIntegrationId,
-                    $fileUri,
-                    'SHIPPING_PROFILES',
-                    'CREATE'
-                );
-            } catch (Exception $e) {
-                $this->fbeHelper->logExceptionImmediatelyToMeta($e, [
-                    'store_id' => $this->fbeHelper->getStore()->getId(),
-                    'event' => 'shipping_profile_sync',
-                    'event_type' => 'after_save'
-                ]);
+            $this->syncShippingProfilesForStore($event_type, $store);
+        }
+    }
+
+    /**
+     * Syncing shipping profiles for an individual store
+     *
+     * @param string $event_type
+     * @param StoreInterface $store
+     * @return void
+     */
+    private function syncShippingProfilesForStore(string $event_type, StoreInterface $store)
+    {
+        try {
+            $accessToken = $accessToken ?? $this->systemConfig->getAccessToken($store->getId());
+            if ($accessToken === null) {
+                return;
             }
+            $this->shippingData->setStoreId((int)$store->getId());
+            $shippingProfiles = [
+                $this->shippingData->buildShippingProfile(ShippingProfileTypes::TABLE_RATE),
+                $this->shippingData->buildShippingProfile(ShippingProfileTypes::FLAT_RATE),
+                $this->shippingData->buildShippingProfile(ShippingProfileTypes::FREE_SHIPPING),
+            ];
+            $fileUri = $this->shippingFileBuilder->createFile($shippingProfiles);
+            $accessToken = $accessToken ?? $this->systemConfig->getAccessToken($store->getId());
+            $partnerIntegrationId = $partnerIntegrationId ??
+                $this->systemConfig->getCommercePartnerIntegrationId($store->getId());
+            $this->graphApiAdapter->setDebugMode($this->systemConfig->isDebugMode($store->getId()))
+                ->setAccessToken($accessToken);
+            $this->graphApiAdapter->uploadFile(
+                $partnerIntegrationId,
+                $fileUri,
+                'SHIPPING_PROFILES',
+                'CREATE'
+            );
+        } catch (Exception $e) {
+            $this->fbeHelper->logExceptionImmediatelyToMeta($e, [
+                'store_id' => $this->fbeHelper->getStore()->getId(),
+                'event' => 'shipping_profile_sync',
+                'event_type' => $event_type
+            ]);
         }
     }
 }