[ADO-424] Add additional phpunit for Meta_BusinessExtension module

Author: pradeepkanaka

app/code/Meta/BusinessExtension/Test/Unit/Api/AdobeCloudConfigTest.php

@@ -5,7 +5,9 @@
 namespace Meta\BusinessExtension\Test\Unit\Api;
 
 use Meta\BusinessExtension\Model\Api\AdobeCloudConfig;
+use Meta\BusinessExtension\Api\AdobeCloudConfigInterface;
 use PHPUnit\Framework\TestCase;
+use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
 
 class AdobeCloudConfigTest extends TestCase
 {
@@ -22,10 +24,11 @@ class AdobeCloudConfigTest extends TestCase
     protected function setUp(): void
     {
         parent::setUp();
-
-        $this->adobeCloudConfig = $this->getMockBuilder(AdobeCloudConfig::class)
-            ->disableOriginalConstructor()
-            ->getMock();
+        $objectManager = new ObjectManager($this);
+        
+        $this->adobeCloudConfig = $objectManager->getObject(
+            AdobeCloudConfig::class
+        );
     }
 
     /**
@@ -37,8 +40,6 @@ public function testIsSellerOnAdobeCloudReturnsTrueWhenEnvVarIsSet(): void
     {
         /** check if the envinorment is non-premise */
         $_ENV['MAGENTO_CLOUD_ENVIRONMENT'] = 'MAGENTO_CLOUD_ENVIRONMENT';
-        $this->adobeCloudConfig->method('isSellerOnAdobeCloud')
-            ->willReturn(true);
 
         $this->assertTrue($this->adobeCloudConfig->isSellerOnAdobeCloud());
         unset($_ENV['MAGENTO_CLOUD_ENVIRONMENT']);
@@ -53,9 +54,33 @@ public function testIsSellerOnAdobeCloudReturnsFalseWhenEnvVarIsNotSet(): void
     {
         /** check if the envinorment is on-premise */
         unset($_ENV['MAGENTO_CLOUD_ENVIRONMENT']);
-        $this->adobeCloudConfig->method('isSellerOnAdobeCloud')
-            ->willReturn(false);
 
         $this->assertFalse($this->adobeCloudConfig->isSellerOnAdobeCloud());
     }
+
+    /**
+     * Validate if seller is on-premise
+     * 
+     * @return void
+     */
+    public function testGetCommercePartnerSellerPlatformType(): void
+    {
+        /** check if the envinorment is on-premise */
+        $_ENV['MAGENTO_CLOUD_ENVIRONMENT'] = 'MAGENTO_CLOUD_ENVIRONMENT';
+        
+        $this->assertSame(AdobeCloudConfigInterface::ADOBE_COMMERCE_CLOUD, $this->adobeCloudConfig->getCommercePartnerSellerPlatformType());
+    }
+
+    /**
+     * Validate if seller is on-premise
+     * 
+     * @return void
+     */
+    public function testGetCommercePartnerSellerPlatformTypeIsNotOnCloud(): void
+    {
+        /** check if the envinorment is on-premise */
+        unset($_ENV['MAGENTO_CLOUD_ENVIRONMENT']);
+        
+        $this->assertSame(AdobeCloudConfigInterface::MAGENTO_OPEN_SOURCE, $this->adobeCloudConfig->getCommercePartnerSellerPlatformType());
+    }
 }

app/code/Meta/BusinessExtension/Test/Unit/Api/CoreConfigTest.php

@@ -6,6 +6,7 @@
 
 use PHPUnit\Framework\TestCase;
 use Meta\BusinessExtension\Model\Api\CoreConfig;
+use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
 
 class CoreConfigTest extends TestCase
 {
@@ -23,9 +24,13 @@ protected function setup(): void
     {
         parent::setup();
 
-        $this->metaCoreConfig = $this->getMockBuilder(CoreConfig::class)
-            ->disableOriginalConstructor()
-            ->getMock();
+        $objectManager = new ObjectManager($this);
+        $this->metaCoreConfig = $objectManager->getObject(
+            CoreConfig::class,
+            [
+                'data' => []
+            ]
+        );
     }
 
     /**
@@ -34,26 +39,10 @@ protected function setup(): void
      * @return void
      */
     public function testGetExternalBusinessId(): void
-    {
-        $this->metaCoreConfig->method('getExternalBusinessId')
-            ->willReturn('');
-        
-        $this->assertEmpty($this->metaCoreConfig->getExternalBusinessId());
-    }
-
-    /**
-     * Validate if the external business ID is set
-     * 
-     * @return void
-     */
-    public function testSetExternalBusinessId(): void
-    {
+    {   
         $businessId = 'ZmJfaWRfMQ==';
         $this->metaCoreConfig->setExternalBusinessId($businessId);
-        $this->metaCoreConfig->method('getExternalBusinessId')
-            ->willReturn($businessId);
-        
-        $this->assertSame($businessId, $this->metaCoreConfig->getExternalBusinessId());
+        $this->assertEquals($businessId, $this->metaCoreConfig->getExternalBusinessId());
     }
 
     /**
@@ -65,9 +54,6 @@ public function testSetIsOrderSyncEnabled(): void
     {
         $isOrderSyncEnabled = true;
         $this->metaCoreConfig->setIsOrderSyncEnabled($isOrderSyncEnabled);
-
-        $this->metaCoreConfig->method('isOrderSyncEnabled')
-            ->willReturn($isOrderSyncEnabled);
 
         $this->assertSame($isOrderSyncEnabled, $this->metaCoreConfig->isOrderSyncEnabled());
     }
@@ -81,9 +67,6 @@ public function testSetIsCatalogSyncEnabled(): void
     {
         $isCatalogSyncEnabled = true;
         $this->metaCoreConfig->setIsCatalogSyncEnabled($isCatalogSyncEnabled);
-
-        $this->metaCoreConfig->method('isCatalogSyncEnabled')
-            ->willReturn($isCatalogSyncEnabled);
 
         $this->assertSame($isCatalogSyncEnabled, $this->metaCoreConfig->isCatalogSyncEnabled());
     }
@@ -97,9 +80,6 @@ public function testSetIsPromotionsSyncEnabled(): void
     {
         $isPromotionsSyncEnabled = true;
         $this->metaCoreConfig->setIsPromotionsSyncEnabled($isPromotionsSyncEnabled);
-
-        $this->metaCoreConfig->method('isPromotionsSyncEnabled')
-            ->willReturn($isPromotionsSyncEnabled);
 
         $this->assertSame($isPromotionsSyncEnabled, $this->metaCoreConfig->isPromotionsSyncEnabled());
     }
@@ -113,9 +93,6 @@ public function testSetIsActiveExtension(): void
     {
         $isActiveExtension = true;
         $this->metaCoreConfig->setIsActiveExtension($isActiveExtension);
-
-        $this->metaCoreConfig->method('isActiveExtension')
-            ->willReturn($isActiveExtension);
 
         $this->assertSame($isActiveExtension, $this->metaCoreConfig->isActiveExtension());
     }
@@ -129,9 +106,6 @@ public function testSetProductIdentifierAttr(): void
     {
         $productIdentifierAttr = 'sku';
         $this->metaCoreConfig->setProductIdentifierAttr($productIdentifierAttr);
-
-        $this->metaCoreConfig->method('getProductIdentifierAttr')
-            ->willReturn($productIdentifierAttr);
 
         $this->assertSame($productIdentifierAttr, $this->metaCoreConfig->getProductIdentifierAttr());
     }
@@ -145,9 +119,6 @@ public function testSetOutOfStockThreshold(): void
     {
         $outOfStockThreshold = '10';
         $this->metaCoreConfig->setOutOfStockThreshold($outOfStockThreshold);
-
-        $this->metaCoreConfig->method('getOutOfStockThreshold')
-            ->willReturn($outOfStockThreshold);
 
         $this->assertSame($outOfStockThreshold, $this->metaCoreConfig->getOutOfStockThreshold());
     }
@@ -161,9 +132,6 @@ public function testSetFeedId(): void
     {
         $feedId = 'feed-id';
         $this->metaCoreConfig->setFeedId($feedId);
-
-        $this->metaCoreConfig->method('getFeedId')
-            ->willReturn($feedId);
 
         $this->assertSame($feedId, $this->metaCoreConfig->getFeedId());
     }
@@ -177,9 +145,6 @@ public function testSetInstalledMetaExtensionVersion(): void
     {
         $version = '1.0.0';
         $this->metaCoreConfig->setInstalledMetaExtensionVersion($version);
-
-        $this->metaCoreConfig->method('getInstalledMetaExtensionVersion')
-            ->willReturn($version);
 
         $this->assertSame($version, $this->metaCoreConfig->getInstalledMetaExtensionVersion());
     }
@@ -193,9 +158,6 @@ public function testSetGraphApiVersion(): void
     {
         $graphApiVersion = 'v1.0';
         $this->metaCoreConfig->setGraphApiVersion($graphApiVersion);
-
-        $this->metaCoreConfig->method('getGraphApiVersion')
-            ->willReturn($graphApiVersion);
 
         $this->assertSame($graphApiVersion, $this->metaCoreConfig->getGraphApiVersion());
     }
@@ -209,9 +171,6 @@ public function testSetMagentoVersion(): void
     {
         $magentoVersion = '2.4.5';
         $this->metaCoreConfig->setMagentoVersion($magentoVersion);
-
-        $this->metaCoreConfig->method('getMagentoVersion')
-            ->willReturn($magentoVersion);
 
         $this->assertSame($magentoVersion, $this->metaCoreConfig->getMagentoVersion());
     }

app/code/Meta/BusinessExtension/Test/Unit/Api/CustomApiKey/APIKeyServiceTest.php

@@ -66,6 +66,27 @@ public function testUpsertApiKey()
         $this->assertEquals($apiKey, $result);
     }
 
+    public function testGetCustomApiKeyWithNull()
+    {
+        $this->scopeConfig->method('getValue')
+            ->with('meta_extension/general/api_key')
+            ->willReturn(null);
+        $apiKeyService = new ApiKeyService(
+            $this->apiKeyGenerator,
+            $this->configWriter,
+            $this->scopeConfig,
+            $this->logger
+        );
+        $this->logger->expects($this->exactly(2))
+            ->method('info')
+            ->withConsecutive(['API key does not exist. Generating a new key.'],['API key has been generated and saved.'])
+            ->willReturnSelf();
+        $this->configWriter->expects($this->once())->method('save');
+        $result = $apiKeyService->getCustomApiKey();
+        
+        $this->assertIsString($result);
+    }
+
     public function testCustomApiKey()
     {
         $apiKey = 'generated-api-key';