Skip to content

Commit 35f085a

Browse files
author
Dima Dromov
committed
Remove before node from mftf tests
1 parent 13e3bf4 commit 35f085a

6 files changed

+26
-38
lines changed

app/code/Meta/Sales/Test/Mftf/Test/AdminChangeProductAttributeGroupTest.xml

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,9 @@
33
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
44
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
55
<test name="AdminChangeProductAttributeGroupTest">
6-
<before>
7-
<actionGroup ref="AssignAttributeToGroupActionGroup" stepKey="assignAttributeToGroup">
8-
<argument name="group" value="General"/>
9-
<argument name="attribute" value="$createProductAttribute.attribute_code$"/>
10-
</actionGroup>
11-
</before>
6+
<actionGroup ref="AssignAttributeToGroupActionGroup" stepKey="assignAttributeToGroup">
7+
<argument name="group" value="General"/>
8+
<argument name="attribute" value="$createProductAttribute.attribute_code$"/>
9+
</actionGroup>
1210
</test>
1311
</tests>

app/code/Meta/Sales/Test/Mftf/Test/AdminChangeProductAttributeSetTest.xml

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,9 @@
33
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
44
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
55
<test name="AdminChangeProductAttributeSetTest">
6-
<before>
7-
<actionGroup ref="AssignAttributeToGroupActionGroup" stepKey="assignAttributeToGroup">
8-
<argument name="group" value="General"/>
9-
<argument name="attribute" value="$$createProductAttribute.attribute_code$$"/>
10-
</actionGroup>
11-
</before>
6+
<actionGroup ref="AssignAttributeToGroupActionGroup" stepKey="assignAttributeToGroup">
7+
<argument name="group" value="General"/>
8+
<argument name="attribute" value="$$createProductAttribute.attribute_code$$"/>
9+
</actionGroup>
1210
</test>
1311
</tests>

app/code/Meta/Sales/Test/Mftf/Test/AdminCheckResultsOfColorAndOtherFiltersTest.xml

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,11 @@
88
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
99
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
1010
<test name="AdminCheckResultsOfColorAndOtherFiltersTest">
11-
<before>
12-
<actionGroup ref="AdminAddUnassignedAttributeToGroupActionGroup" stepKey="createDefaultAttributeSet">
13-
<argument name="label" value="mySet"/>
14-
<argument name="firstOption" value="$$createConfigProductAttribute.attribute_code$$"/>
15-
<argument name="secondOption" value="$$createConfigProductAttribute2.attribute_code$$"/>
16-
<argument name="group" value="General"/>
17-
</actionGroup>
18-
</before>
11+
<actionGroup ref="AdminAddUnassignedAttributeToGroupActionGroup" stepKey="createDefaultAttributeSet">
12+
<argument name="label" value="mySet"/>
13+
<argument name="firstOption" value="$$createConfigProductAttribute.attribute_code$$"/>
14+
<argument name="secondOption" value="$$createConfigProductAttribute2.attribute_code$$"/>
15+
<argument name="group" value="General"/>
16+
</actionGroup>
1917
</test>
2018
</tests>

app/code/Meta/Sales/Test/Mftf/Test/ProductAttributeWithoutValueInCompareListTest.xml

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,9 @@
33
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
44
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
55
<test name="ProductAttributeWithoutValueInCompareListTest">
6-
<before>
7-
<actionGroup ref="AssignAttributeToGroupActionGroup" stepKey="assignAttributeToGroup">
8-
<argument name="group" value="General"/>
9-
<argument name="attribute" value="$$createProductAttribute.attribute_code$$"/>
10-
</actionGroup>
11-
</before>
6+
<actionGroup ref="AssignAttributeToGroupActionGroup" stepKey="assignAttributeToGroup">
7+
<argument name="group" value="General"/>
8+
<argument name="attribute" value="$$createProductAttribute.attribute_code$$"/>
9+
</actionGroup>
1210
</test>
1311
</tests>

app/code/Meta/Sales/Test/Mftf/Test/StorefrontNoJavascriptErrorOnAddYourReviewClickTest.xml

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,9 @@
33
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
44
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
55
<test name="StorefrontNoJavascriptErrorOnAddYourReviewClickTest">
6-
<before>
7-
<actionGroup ref="AssignAttributeToGroupActionGroup" stepKey="assignAttributeToGroup">
8-
<argument name="group" value="General"/>
9-
<argument name="attribute" value="$$createProductAttribute.attribute_code$$"/>
10-
</actionGroup>
11-
</before>
6+
<actionGroup ref="AssignAttributeToGroupActionGroup" stepKey="assignAttributeToGroup">
7+
<argument name="group" value="General"/>
8+
<argument name="attribute" value="$$createProductAttribute.attribute_code$$"/>
9+
</actionGroup>
1210
</test>
1311
</tests>

app/code/Meta/Sales/Test/Mftf/Test/StorefrontQuickSearchConfigurableChildrenTest.xml

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,9 @@
33
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
44
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
55
<test name="StorefrontQuickSearchConfigurableChildrenTest">
6-
<before>
7-
<actionGroup ref="AssignAttributeToGroupActionGroup" stepKey="assignAttributeToGroup">
8-
<argument name="group" value="General"/>
9-
<argument name="attribute" value="$createProductAttribute.attribute_code$"/>
10-
</actionGroup>
11-
</before>
6+
<actionGroup ref="AssignAttributeToGroupActionGroup" stepKey="assignAttributeToGroup">
7+
<argument name="group" value="General"/>
8+
<argument name="attribute" value="$createProductAttribute.attribute_code$"/>
9+
</actionGroup>
1210
</test>
1311
</tests>

0 commit comments

Comments
 (0)