Remove choosing feed methods (#216) (#248)

* remove configs for inventory sync and incremental update; they will be on by default

* remove choosing feed method

* remove choosing feed method

* remove choosing feed method

* fix test

* remove feed method in config.xml

Co-authored-by: Wayne Zhang <[email protected]>

Author: zlik

app/code/Meta/BusinessExtension/Model/System/Config.php

@@ -56,7 +56,6 @@ class Config
     private const XML_PATH_FACEBOOK_BUSINESS_EXTENSION_STORE = 'facebook/business_extension/store';
 
     private const XML_PATH_FACEBOOK_DAILY_PRODUCT_FEED = 'facebook/catalog_management/daily_product_feed';
-    private const XML_PATH_FACEBOOK_FEED_UPLOAD_METHOD = 'facebook/catalog_management/feed_upload_method';
     private const XML_PATH_FACEBOOK_PRODUCT_IDENTIFIER = 'facebook/catalog_management/product_identifier';
     private const XML_PATH_FACEBOOK_PRICE_INCL_TAX = 'facebook/catalog_management/price_incl_tax';
     private const XML_PATH_FACEBOOK_COLLECTIONS_SYNC_IS_ACTIVE = 'facebook/catalog_management/collections_sync';
@@ -765,18 +764,6 @@ public function isActiveDailyProductFeed($scopeId = null, $scope = ScopeInterfac
         return (bool)$this->getConfig(self::XML_PATH_FACEBOOK_DAILY_PRODUCT_FEED, $scopeId, $scope);
     }
 
-    /**
-     * Get feed upload method
-     *
-     * @param int $scopeId
-     * @param string $scope
-     * @return mixed
-     */
-    public function getFeedUploadMethod($scopeId = null, $scope = ScopeInterface::SCOPE_STORES)
-    {
-        return $this->getConfig(self::XML_PATH_FACEBOOK_FEED_UPLOAD_METHOD, $scopeId, $scope);
-    }
-
     /**
      * Get feed id
      *

app/code/Meta/Catalog/Model/Product/Feed/Uploader.php

@@ -18,7 +18,6 @@
 namespace Meta\Catalog\Model\Product\Feed;
 
 use Exception;
-use Meta\Catalog\Model\Config\Source\FeedUploadMethod;
 use Meta\Catalog\Model\Product\Feed\Method\BatchApi as MethodBatchApi;
 use Meta\Catalog\Model\Product\Feed\Method\FeedApi as MethodFeedApi;
 use Meta\BusinessExtension\Model\System\Config as SystemConfig;
@@ -66,20 +65,7 @@ public function __construct(
      */
     public function uploadFullCatalog($storeId = null)
     {
-        $uploadMethod = $this->systemConfig->getFeedUploadMethod($storeId);
-
-        if ($uploadMethod === FeedUploadMethod::UPLOAD_METHOD_CATALOG_BATCH_API) {
-            try {
-                $response = $this->methodBatchApi->generateProductRequestData($storeId);
-            } catch (Exception $e) {
-                throw new LocalizedException(__($e->getMessage()));
-            }
-        } elseif ($uploadMethod === FeedUploadMethod::UPLOAD_METHOD_FEED_API) {
-            $response = $this->methodFeedApi->execute($storeId);
-        } else {
-            throw new LocalizedException(__('Unknown feed upload method'));
-        }
-        return $response;
+        return $this->methodFeedApi->execute($storeId);
     }
 
     /**

app/code/Meta/Catalog/etc/adminhtml/system.xml

@@ -14,11 +14,6 @@
                     <source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
                     <comment>Scheduled full catalog upload</comment>
                 </field>
-                <field id="feed_upload_method" translate="label comment" type="select" sortOrder="20" showInDefault="1" showInWebsite="0" showInStore="1">
-                    <label>Feed Upload Method</label>
-                    <config_path>facebook/catalog_management/feed_upload_method</config_path>
-                    <source_model>Meta\Catalog\Model\Config\Source\FeedUploadMethod</source_model>
-                </field>
                 <field id="product_feed" translate="label" type="text" sortOrder="30" showInDefault="1" showInWebsite="0" showInStore="1">
                     <label>Push Products</label>
                     <frontend_model>Meta\Catalog\Block\Adminhtml\System\Config\ProductFeed</frontend_model>

app/code/Meta/Catalog/etc/config.xml

@@ -4,7 +4,6 @@
         <facebook>
             <catalog_management>
                 <daily_product_feed>0</daily_product_feed>
-                <feed_upload_method>feed_api</feed_upload_method>
                 <incremental_product_updates>0</incremental_product_updates>
                 <price_incl_tax>0</price_incl_tax>
                 <collections_sync>0</collections_sync>