[FBE] Split FBE css so that we don't load all of it on every page throughout Magento (#529)

dalongi · web-flow · commit 4456b32aca3c · 2023-11-08T13:11:25.000-08:00
diff --git a/app/code/Meta/BusinessExtension/view/adminhtml/layout/default.xml b/app/code/Meta/BusinessExtension/view/adminhtml/layout/default.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0"?>
 <page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/page_configuration.xsd">
     <head>
-        <css src="Meta_BusinessExtension::css/fbe.css"/>
+        <css src="Meta_BusinessExtension::css/meta_sidebar_icon.css"/>
     </head>
 </page>
diff --git a/app/code/Meta/BusinessExtension/view/adminhtml/layout/fbeadmin_setup_index.xml b/app/code/Meta/BusinessExtension/view/adminhtml/layout/fbeadmin_setup_index.xml
@@ -1,5 +1,9 @@
 <?xml version="1.0"?>
 <page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/page_configuration.xsd">
+    <head>
+        <css src="Meta_BusinessExtension::css/commerce_extension.css"/>
+    </head>
+
     <body>
         <referenceBlock remove="true" name="header.inner.left" />
         <referenceBlock remove="true" name="header.inner.right" />
diff --git a/app/code/Meta/BusinessExtension/view/adminhtml/web/css/commerce_extension.css b/app/code/Meta/BusinessExtension/view/adminhtml/web/css/commerce_extension.css
@@ -38,20 +38,4 @@
     border-radius: 4px;
     max-width: 800px;
     padding: 16px;
-}
-
-/* Add a grayscale Meta logo to the left sidebar item for this extension. */
-.admin__menu .level-0.item-facebook > a {
-    padding-top: 4px;
-}
-.admin__menu .level-0.item-facebook > a:before {
-    content: url('../images/meta.svg');
-    filter: contrast(0) grayscale(1) brightness(1.50);
-    height: 28px;
-    margin: 0 auto;
-    width: 38px;
-}
-.admin__menu .level-0.item-facebook:hover > a:before,
-.admin__menu .level-0.item-facebook._active > a:before {
-    filter: contrast(0) grayscale(1) brightness(2) ;
-}
+}
diff --git a/app/code/Meta/BusinessExtension/view/adminhtml/web/css/meta_sidebar_icon.css b/app/code/Meta/BusinessExtension/view/adminhtml/web/css/meta_sidebar_icon.css
@@ -0,0 +1,26 @@
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ * All rights reserved.
+ *
+ * This source code is licensed under the BSD-style license found in the
+ * LICENSE file in the root directory of this source tree. An additional grant
+ * of patent rights can be found in the PATENTS file in the code directory.
+ */
+
+/* Add a grayscale Meta logo to the left sidebar item for this extension. */
+.admin__menu .level-0.item-facebook > a {
+    padding-top: 4px;
+}
+
+.admin__menu .level-0.item-facebook > a:before {
+    content: url('../images/meta.svg');
+    filter: contrast(0) grayscale(1) brightness(1.50);
+    height: 28px;
+    margin: 0 auto;
+    width: 38px;
+}
+
+.admin__menu .level-0.item-facebook:hover > a:before,
+.admin__menu .level-0.item-facebook._active > a:before {
+    filter: contrast(0) grayscale(1) brightness(2);
+}
diff --git a/app/code/Meta/Catalog/view/adminhtml/layout/fbeadmin_diagnostic_index.xml b/app/code/Meta/Catalog/view/adminhtml/layout/fbeadmin_diagnostic_index.xml
@@ -5,7 +5,6 @@
         <title>
             Catalog Diagnostics
         </title>
-        <css src="Meta_BusinessExtension::css/fbe.css"/>
         <link src="Meta_Catalog::js/diagnostics.js"/>
     </head>
     <body>
