Connection not deleted for store (#181)

Author: dimadidr

app/code/Meta/BusinessExtension/Controller/Adminhtml/Ajax/Fbdeleteasset.php

@@ -23,10 +23,10 @@
 
 class Fbdeleteasset extends AbstractAjax
 {
-    const DELETE_SUCCESS_MESSAGE = "You have successfully deleted Meta Business Extension.
+    public const DELETE_SUCCESS_MESSAGE = "You have successfully deleted Meta Business Extension.
     The pixel installed on your website is now deleted.";
 
-    const DELETE_FAILURE_MESSAGE = "There was a problem deleting the connection.
+    private const DELETE_FAILURE_MESSAGE = "There was a problem deleting the connection.
       Please try again.";
 
     /**
@@ -51,12 +51,21 @@ public function __construct(
     }
 
     /**
+     * Execute for json
+     *
      * @return array
      */
     public function executeForJson()
     {
+        $storeId = $this->getRequest()->getParam('storeId');
+        if ($storeId === null) {
+            return [
+                'success' => false,
+                'error_message' => __(self::DELETE_FAILURE_MESSAGE)
+            ];
+        }
         try {
-            $this->fbeHelper->deleteConfigKeys();
+            $this->fbeHelper->deleteConfigKeys($storeId);
             $response = [
                 'success' => true,
                 'message' => __(self::DELETE_SUCCESS_MESSAGE),

app/code/Meta/BusinessExtension/Helper/FBEHelper.php

@@ -423,18 +423,27 @@ public function logPixelEvent($pixelId, $pixelEvent)
     /**
      * Delete config keys
      *
+     * @param string $storeId
      * @return FBEHelper
      */
-    public function deleteConfigKeys()
+    public function deleteConfigKeys($storeId)
     {
-        $this->systemConfig->deleteConfig(SystemConfig::XML_PATH_FACEBOOK_BUSINESS_EXTENSION_EXTERNAL_BUSINESS_ID)
-            ->deleteConfig(SystemConfig::XML_PATH_FACEBOOK_BUSINESS_EXTENSION_PIXEL_ID)
-            ->deleteConfig(SystemConfig::XML_PATH_FACEBOOK_BUSINESS_EXTENSION_PIXEL_AAM_SETTINGS)
-            ->deleteConfig(SystemConfig::XML_PATH_FACEBOOK_BUSINESS_EXTENSION_PROFILES)
-            ->deleteConfig(SystemConfig::XML_PATH_FACEBOOK_BUSINESS_EXTENSION_CATALOG_ID)
-            ->deleteConfig(SystemConfig::XML_PATH_FACEBOOK_BUSINESS_EXTENSION_FEED_ID)
-            ->deleteConfig(SystemConfig::XML_PATH_FACEBOOK_BUSINESS_EXTENSION_API_VERSION)
-            ->deleteConfig(SystemConfig::XML_PATH_FACEBOOK_BUSINESS_EXTENSION_API_VERSION_LAST_UPDATE);
+        $this->systemConfig->deleteConfig(
+            SystemConfig::XML_PATH_FACEBOOK_BUSINESS_EXTENSION_EXTERNAL_BUSINESS_ID,
+            $storeId
+        )
+            ->deleteConfig(SystemConfig::XML_PATH_FACEBOOK_BUSINESS_EXTENSION_INSTALLED, $storeId)
+            ->deleteConfig(SystemConfig::XML_PATH_FACEBOOK_BUSINESS_EXTENSION_ACCESS_TOKEN, $storeId)
+            ->deleteConfig(SystemConfig::XML_PATH_FACEBOOK_BUSINESS_EXTENSION_PAGE_ID, $storeId)
+            ->deleteConfig(SystemConfig::XML_PATH_FACEBOOK_BUSINESS_EXTENSION_PAGE_ACCESS_TOKEN, $storeId)
+            ->deleteConfig(SystemConfig::XML_PATH_FACEBOOK_BUSINESS_EXTENSION_COMMERCE_ACCOUNT_ID, $storeId)
+            ->deleteConfig(SystemConfig::XML_PATH_FACEBOOK_BUSINESS_EXTENSION_PIXEL_ID, $storeId)
+            ->deleteConfig(SystemConfig::XML_PATH_FACEBOOK_BUSINESS_EXTENSION_PIXEL_AAM_SETTINGS, $storeId)
+            ->deleteConfig(SystemConfig::XML_PATH_FACEBOOK_BUSINESS_EXTENSION_PROFILES, $storeId)
+            ->deleteConfig(SystemConfig::XML_PATH_FACEBOOK_BUSINESS_EXTENSION_CATALOG_ID, $storeId)
+            ->deleteConfig(SystemConfig::XML_PATH_FACEBOOK_BUSINESS_EXTENSION_FEED_ID, $storeId)
+            ->deleteConfig(SystemConfig::XML_PATH_FACEBOOK_BUSINESS_EXTENSION_API_VERSION, $storeId)
+            ->deleteConfig(SystemConfig::XML_PATH_FACEBOOK_BUSINESS_EXTENSION_API_VERSION_LAST_UPDATE, $storeId);
 
         return $this;
     }

app/code/Meta/BusinessExtension/Test/Unit/Controller/Adminhtml/Ajax/FbdeleteassetTest.php

@@ -69,8 +69,10 @@ public function setUp(): void
      */
     public function testExecuteForJson()
     {
+        $storeId = 2;
+        $this->request->method('getParam')->willReturn($storeId);
         $this->fbeHelper->expects($this->once())
-            ->method('deleteConfigKeys');
+            ->method('deleteConfigKeys')->with($storeId)->willReturnSelf();
 
         $result = $this->fbdeleteasset->executeForJson();
         $this->assertNotNull($result);