Merge pull request #896 from pradeepkanaka/fix-app-issue

Fix app issue - PHPCS warnings

Author: priyambad

app/code/Meta/BusinessExtension/Model/Api/AdobeCloudConfig.php

@@ -22,6 +22,7 @@
 
 use Meta\BusinessExtension\Api\AdobeCloudConfigInterface;
 use Magento\Framework\Filesystem\DirectoryList;
+use  Magento\Framework\Filesystem\Driver\File;
 
 class AdobeCloudConfig implements AdobeCloudConfigInterface
 {
@@ -39,15 +40,23 @@ class AdobeCloudConfig implements AdobeCloudConfigInterface
      */
     private $directoryList;
 
+    /**
+     * @var File
+     */
+    private $file;
+
     /**
      * Class constructor
      *
      * @param DirectoryList $directoryList
+     * @param File $file
      */
     public function __construct(
-        DirectoryList $directoryList
+        DirectoryList $directoryList,
+        File $file
     ) {
         $this->directoryList = $directoryList;
+        $this->file = $file;
     }
 
     /**
@@ -60,8 +69,11 @@ public function isSellerOnAdobeCloud(): bool
         $rootPath = $this->directoryList->getRoot();
 
         foreach (self::CLOUD_FILES as $file) {
-            if (file_exists($rootPath . '/' . $file)) {
-                return true;
+            try {
+                if ($this->file->isExists($rootPath . '/' . $file)) {
+                    return true;
+                }
+            } catch (\Exception $ex) {
             }
         }
 

app/code/Meta/BusinessExtension/Test/Unit/Api/AdobeCloudConfigTest.php

@@ -18,7 +18,7 @@ class AdobeCloudConfigTest extends TestCase
 
     /**
      * Class setup function
-     * 
+     *
      * @return void
      */
     protected function setUp(): void
@@ -33,7 +33,7 @@ protected function setUp(): void
 
     /**
      * Validate if seller is on Cloud
-     * 
+     *
      * @return void
      */
     public function testIsSellerOnAdobeCloudReturnsTrueWhenEnvVarIsSet(): void
@@ -47,7 +47,7 @@ public function testIsSellerOnAdobeCloudReturnsTrueWhenEnvVarIsSet(): void
 
     /**
      * Validate if seller is on-premise
-     * 
+     *
      * @return void
      */
     public function testIsSellerOnAdobeCloudReturnsFalseWhenEnvVarIsNotSet(): void
@@ -60,7 +60,7 @@ public function testIsSellerOnAdobeCloudReturnsFalseWhenEnvVarIsNotSet(): void
 
     /**
      * Validate if seller is on-premise
-     * 
+     *
      * @return void
      */
     public function testGetCommercePartnerSellerPlatformType(): void
@@ -73,7 +73,7 @@ public function testGetCommercePartnerSellerPlatformType(): void
 
     /**
      * Validate if seller is on-premise
-     * 
+     *
      * @return void
      */
     public function testGetCommercePartnerSellerPlatformTypeIsNotOnCloud(): void

app/code/Meta/BusinessExtension/Test/Unit/Api/CoreConfigFactoryTest.php

@@ -36,7 +36,7 @@ protected function setUp(): void
 
     /**
      * Test create method
-     * 
+     *
      * @return void
      */
     public function testCreate(): void
@@ -57,7 +57,7 @@ public function testCreate(): void
 
     /**
      * Get data for testing
-     * 
+     *
      * @return array
      */
     private function getData()

app/code/Meta/BusinessExtension/Test/Unit/Api/CoreConfigTest.php

@@ -17,7 +17,7 @@ class CoreConfigTest extends TestCase
 
     /**
      * Class setup function
-     * 
+     *
      * @return void
      */
     protected function setup(): void
@@ -35,19 +35,19 @@ protected function setup(): void
 
     /**
      * Validate if the external business ID is empty
-     * 
+     *
      * @return void
      */
     public function testGetExternalBusinessId(): void
-    {   
+    {
         $businessId = 'ZmJfaWRfMQ==';
         $this->metaCoreConfig->setExternalBusinessId($businessId);
         $this->assertEquals($businessId, $this->metaCoreConfig->getExternalBusinessId());
     }
 
     /**
      * Validate if the order sync is enabled
-     * 
+     *
      * @return void
      */
     public function testSetIsOrderSyncEnabled(): void
@@ -60,7 +60,7 @@ public function testSetIsOrderSyncEnabled(): void
 
     /**
      * Validate if the catalog sync is enabled
-     * 
+     *
      * @return void
      */
     public function testSetIsCatalogSyncEnabled(): void
@@ -73,7 +73,7 @@ public function testSetIsCatalogSyncEnabled(): void
 
     /**
      * Validate if the Promotion sync is enabled
-     * 
+     *
      * @return void
      */
     public function testSetIsPromotionsSyncEnabled(): void
@@ -86,7 +86,7 @@ public function testSetIsPromotionsSyncEnabled(): void
 
     /**
      * Validate if the extension is active
-     * 
+     *
      * @return void
      */
     public function testSetIsActiveExtension(): void
@@ -99,7 +99,7 @@ public function testSetIsActiveExtension(): void
 
     /**
      * Validate if the product identifier attribute is set
-     * 
+     *
      * @return void
      */
     public function testSetProductIdentifierAttr(): void
@@ -112,7 +112,7 @@ public function testSetProductIdentifierAttr(): void
 
     /**
      * Validate if the product stock threashold is set
-     * 
+     *
      * @return void
      */
     public function testSetOutOfStockThreshold(): void
@@ -125,7 +125,7 @@ public function testSetOutOfStockThreshold(): void
 
     /**
      * Validate if the feed ID is set
-     * 
+     *
      * @return void
      */
     public function testSetFeedId(): void
@@ -138,7 +138,7 @@ public function testSetFeedId(): void
 
     /**
      * Validate if the installed meta extension version is set
-     * 
+     *
      * @return void
      */
     public function testSetInstalledMetaExtensionVersion(): void
@@ -151,7 +151,7 @@ public function testSetInstalledMetaExtensionVersion(): void
 
     /**
      * Validate if the Graph API version is set
-     * 
+     *
      * @return void
      */
     public function testSetGraphApiVersion(): void
@@ -164,7 +164,7 @@ public function testSetGraphApiVersion(): void
 
     /**
      * Validate if the Graph API version is set
-     * 
+     *
      * @return void
      */
     public function testSetMagentoVersion(): void

app/code/Meta/BusinessExtension/Test/Unit/Api/CustomApiKey/APIKeyServiceTest.php

@@ -79,7 +79,7 @@ public function testGetCustomApiKeyWithNull()
         );
         $this->logger->expects($this->exactly(2))
             ->method('info')
-            ->withConsecutive(['API key does not exist. Generating a new key.'],['API key has been generated and saved.'])
+            ->withConsecutive(['API key does not exist. Generating a new key.'], ['API key has been generated and saved.'])
             ->willReturnSelf();
         $this->configWriter->expects($this->once())->method('save');
         $result = $apiKeyService->getCustomApiKey();

app/code/Meta/BusinessExtension/Test/Unit/Api/SettingsWebhookListenerImplTest.php

@@ -73,7 +73,7 @@ class SettingsWebhookListenerImplTest extends TestCase
 
     /**
      * Class setup function
-     * 
+     *
      * @return void
      */
     protected function setUp(): void
@@ -107,7 +107,7 @@ protected function setUp(): void
 
     /**
      * Validate if the settings webhook listener is working as expected
-     * 
+     *
      * @return void
      */
     public function testGetCoreConfig(): void
@@ -152,4 +152,4 @@ public function testGetCoreConfig(): void
         $actual = $this->settingsWebhookListenerImplMockObj->getCoreConfig($externalBusinessId);
         $this->assertInstanceOf(CoreConfigInterface::class, $actual);
     }
-}
+}

app/code/Meta/BusinessExtension/Test/Unit/Api/SettingsWebhookRequestImplTest.php

@@ -18,7 +18,7 @@ class SettingsWebhookRequestImplTest extends TestCase
 
     /**
      * Class setup function
-     * 
+     *
      * @return void
      */
     protected function setUp(): void
@@ -32,7 +32,7 @@ protected function setUp(): void
 
     /**
      * Validate if the settings external business ID is working
-     * 
+     *
      * @return void
      */
     public function testSetExternalBusinessId(): void
@@ -45,7 +45,7 @@ public function testSetExternalBusinessId(): void
 
     /**
      * Validate if the settings notification is working
-     * 
+     *
      * @return void
      */
     public function testSetNotification(): void
@@ -65,7 +65,7 @@ public function testSetNotification(): void
 
     /**
      * Validate if the graphql version is set correctly
-     * 
+     *
      * @return void
      */
     public function testSetGraphAPIVersion(): void
@@ -75,4 +75,4 @@ public function testSetGraphAPIVersion(): void
 
         $this->assertEquals($graphqlVersion, $this->settingsWebhookRequestImpl->getGraphAPIVersion());
     }
-}
+}