Fix Magento Health Index protected modifier issues in Meta_Sales (#255)

* Fix Health Index checks by removing protected modifiers in Meta_Sales

* Fix extra public method in Refund Observer

* Fix static test integrity issue for PHP 8.2 in Meta_Sales

* Revert changes to public modifiers for unecessary updates

* Remove php7.4 from Meta_Sales composer.json

---------

Co-authored-by: Ben Giamarino <[email protected]>

Author: nabhanmaswood98

app/code/Meta/Sales/Helper/ShippingHelper.php

@@ -14,12 +14,12 @@ class ShippingHelper extends AbstractHelper
     /**
      * @var RegionFactory
      */
-    protected $regionFactory;
+    private $regionFactory;
 
     /**
      * @var LoggerInterface
      */
-    protected $logger;
+    private $logger;
 
     /**
      * @var string[string] Supported carrier names by carrier code.
@@ -81,7 +81,7 @@ public function getRegionName($stateId)
      *
      * @return array
      */
-    protected function getSupplementaryCarriersMap()
+    private function getSupplementaryCarriersMap()
     {
         return [
             'UPS'   => 'United Parcel Service',
@@ -97,7 +97,7 @@ protected function getSupplementaryCarriersMap()
      * @param array $carriersMap
      * @return string|false
      */
-    protected function findCodeByTitle($carrierTitle, array $carriersMap)
+    private function findCodeByTitle($carrierTitle, array $carriersMap)
     {
         foreach ($carriersMap as $code => $title) {
             if (stripos($carrierTitle, $title) !== false || stripos($carrierTitle, $code) !== false) {
@@ -113,7 +113,7 @@ protected function findCodeByTitle($carrierTitle, array $carriersMap)
      * @param Track $track
      * @return string
      */
-    protected function getCanonicalCarrierCode($track)
+    private function getCanonicalCarrierCode($track)
     {
         $carrierCode = strtoupper($track->getCarrierCode());
         $carrierTitle = $track->getTitle();

app/code/Meta/Sales/Model/Order/Shipper.php

@@ -81,7 +81,7 @@ public function getOrderShipEvent($storeId = null)
      * @param OrderItem $orderItem
      * @return string|int|bool
      */
-    protected function getRetailerId(OrderItem $orderItem)
+    private function getRetailerId(OrderItem $orderItem)
     {
         $storeId = $orderItem->getStoreId();
         $productIdentifierAttr = $this->systemConfig->getProductIdentifierAttr($storeId);

app/code/Meta/Sales/Observer/Facebook/OrderCreateAfter.php

@@ -32,17 +32,17 @@ class OrderCreateAfter implements ObserverInterface
     /**
      * @var SystemConfig
      */
-    protected $systemConfig;
+    private $systemConfig;
 
     /**
      * @var LoggerInterface
      */
-    protected $logger;
+    private $logger;
 
     /**
      * @var FBEHelper
      */
-    protected $fbeHelper;
+    private $fbeHelper;
 
     /**
      * @var SubscriptionManager

app/code/Meta/Sales/Observer/Order/Refund.php

@@ -68,7 +68,7 @@ public function __construct(
      * @param CreditmemoItem $creditmemoItem
      * @return string|int|bool
      */
-    protected function getRetailerId(CreditmemoItem $creditmemoItem)
+    private function getRetailerId(CreditmemoItem $creditmemoItem)
     {
         if ($this->systemConfig->getProductIdentifierAttr() === IdentifierConfig::PRODUCT_IDENTIFIER_SKU) {
             return $creditmemoItem->getSku();

app/code/Meta/Sales/Plugin/OrderGet.php

@@ -27,12 +27,12 @@ class OrderGet
     /**
      * @var OrderExtensionFactory
      */
-    protected $orderExtensionFactory;
+    private $orderExtensionFactory;
 
     /**
      * @var FacebookOrderInterfaceFactory
      */
-    protected $facebookOrderFactory;
+    private $facebookOrderFactory;
 
     /**
      * @param OrderExtensionFactory $orderExtensionFactory

app/code/Meta/Sales/composer.json

@@ -3,7 +3,7 @@
     "description": "Meta Business Extension Sales module",
     "type": "magento2-module",
     "require": {
-        "php": "~7.4.0||~8.1.0",
+        "php": "~8.1.0||~8.2.0",
         "magento/framework": "*",
         "magento/module-sales": "*",
         "magento/module-sales-sequence": "*",